Add KEY_ZENKAKUHANKAKU mapping for touchpad toggle

Description

• Add KEY_ZENKAKUHANKAKU mapping for touchpad toggle

Pressing the touchpad toggle key on some notebooks produces the key sequence Control + Super + KEY_ZENKAKUHANKAKU. Actual Hankaku/Zenkakus keys however do not use this scancode/keycode, but the tilde ones instead.

This patch binds the, until now on evdev unbound, KEY_ZENKAKUHANKAKU to touchpad toggle so the desktop environments can act accordingly.

Signed-off-by: Werner Sembach wse@tuxedocomputers.com

Rationale for the inclusion in this project

After this !794 (closed) I went to the LKML where is was directed back to XKB and the DEs https://lore.kernel.org/all/1bee0a62-058b-482a-8eec-d45b8aca1614@redhat.com/

This new patch now only maps KEY_ZENKAKUHANKAKU from kernel to XF86TouchpadToggle. The duty of ignoring the pressed meta keys is offloaded to the DEs. According to Hans, GNOME already does that and KDE was also fast in accepting the change:

• https://invent.kde.org/plasma/kwin/-/merge_requests/7278
• https://invent.kde.org/plasma/kwin/-/merge_requests/7281
• https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2873

Checklist

• I read the contribution instructions.
• I justified the inclusion of this feature by providing evidences that it is popular enough. Please note that it is in your interest to provide neutral and accessible sources, if possible in English.
• I ensured that the formatting follows the same conventions of the rest of the file.
• I added a changelog entry following these instructions.
• The commits messages are self-sufficient.
• I ensure that the CI pipeline passes.

added 1 commit

• 3a447887 - Add KEY_ZENKAKUHANKAKU mapping for touchpad toggle

Compare with previous version

marked the checklist item I added a changelog entry following these instructions. as completed

marked the checklist item I ensure that the CI pipeline passes. as completed

changed the description

added 1 commit

• 25820bc9 - Add KEY_ZENKAKUHANKAKU mapping for touchpad toggle

Compare with previous version

added 1 commit

• 60156e2c - Add KEY_ZENKAKUHANKAKU mapping for touchpad toggle

Compare with previous version

LGTM. I left some comments.

In your previous MR !794 (closed), you mentioned specific models using this mapping. Could you add it to the commit message, so we can track what motivated this addition in the first place.

I will do.

Since i send this MR I gained some new insights: https://lore.kernel.org/all/83ea44f6-c0ad-4cb0-a16e-dd4fa17b63c7@tuxedocomputers.com/ *

tl:dr; according to this https://download.microsoft.com/download/1/6/1/161ba512-40e2-4cc9-843a-923143f3456c/translate.pdf zenkaku/hankaku and f24 share their scancodes. I suspect the firmware vendor actually did intent to send ctrl+super+f24, the kernel just missmaps it for some historic reason.

Now I wonder if I should also include this in the commit log somehow to have it documented for the future?

.* If that patch gets accepted I will add another MR here to also map <fk24> to XF86TouchpadToggle. I'm aware that this adds more bloat, but it's in the sake of a smooth transition.

After doing the other changes I forgot to add the devices list to the commit message so I will just do it here:

• TUXEDO devices with board_vendor NB02
• TongFang/Uniwill barebones
• T-Bao https://lore.kernel.org/all/1bee0a62-058b-482a-8eec-d45b8aca1614@redhat.com/

requested changes

added 1 commit

• 271d03d7 - Apply suggestions by Wismill

Compare with previous version

added 1 commit

• c0f56028 - Added KEY_ZENKAKUHANKAKU mapping for touchpad toggle.

Compare with previous version

resolved all threads

added 1 commit

• 9b77b62e - Added KEY_ZENKAKUHANKAKU mapping for touchpad toggle.

Compare with previous version

added 1 commit

• 86b7609e - Added KEY_ZENKAKUHANKAKU mapping for touchpad toggle.

Compare with previous version