desktop-shell: Always activate the top-level surface
Status | Pipeline | Created by | Stages | Actions |
---|---|---|---|---|
Passed 00:03:44
| Stage: container_prep Stage: build Stage: pages |
Download artifacts
No artifacts found |
Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.
gitlab.freedesktop.org will be unavailable for up to a week starting March 16th, due to our ongoing infrastructure move. You can follow our planning tracker at https://gitlab.freedesktop.org/freedesktop/freedesktop/-/issues/2076
In case the device has only touchscreen input device and no keyboard or mouse, the top level surface is never activated. The behavior differs from a device which has a keyboard (or gpio-keys, or even uinput-emulated keyboard), where callchain activate()->weston_view_activate()->weston_seat_set_keyboard_focus()-> weston_keyboard_set_focus()->wl_signal_emit(&keyboard->focus_signal, keyboard)-> handle_keyboard_focus()->weston_desktop_surface_set_activated(..., true); sets the top level surface as activated. On device with touchscreen, the above is never called, hence the top level surface is never activated. Add explicit weston_desktop_surface_set_activated(shsurf->desktop_surface, true); into activate() to always active the top level surface.
This fixes at least two known issues on such devices:
Superseded by !570 (merged)
Status | Pipeline | Created by | Stages | Actions |
---|---|---|---|---|
Passed 00:03:44
| Stage: container_prep Stage: build Stage: pages |
Download artifacts
No artifacts found |