kiosk-shell: Separate (keyboard) input focus from xdg-shell toplevel window activation
This is small follow-up from !568 (closed) in which input focus was tied to window activation.
Note that these series has been split kiosk-shell (current MR) and desktop-shell (which have been migrated to !711 (closed))
This removes the window activation code from the keyboard focus handlers an embeds it straight into the shell's activation parts, such that devices with no keyboard can still use their other input devices (touch) to activate the window.
Merge request reports
Activity
mentioned in merge request !568 (closed)
- Resolved by Marius Vlad
This is more like a mental note, one thing it seems I forgot to add here is that when removing the
desktop_surface
we need to deactivate the focused one, and activate the previous surface, or the current top most surface, which does not happen at the moment by the looks of it. I've only checked with kiosk-shell, have to check-up with desktop-shell as well.
added 34 commits
-
703fd9fb...97d421a7 - 29 commits from branch
wayland:master
- 7f1df7de - desktop-shell: Remove no-op de-activation of the xdg top-level surface
- 91bf31c6 - desktop-shell: Rename gain/lose keyboard focus to activate/de-activate
- 8e1bb8e8 - desktop-shell: Embed keyboard focus handle code when activating
- 5e8dcaf3 - kiosk-shell: Embed keyboard focus activation code
- 7646eb48 - libweston: Rename weston_view_activate() to weston_view_activate_input()
Toggle commit list-
703fd9fb...97d421a7 - 29 commits from branch
- Resolved by Marius Vlad
- Resolved by Marius Vlad
- Resolved by Marius Vlad
This looks quite reasonable to me. I think activation and keyboard focus have been artificially tied together for too long.
Really just one nit - I'd like to know why we're registering the set_focus listeners, because it looks like we no longer need them.
added 158 commits
-
7646eb48...2f2e5da4 - 151 commits from branch
wayland:main
- 367eb2c3 - desktop-shell: Remove no-op de-activation of the xdg top-level surface
- b134342a - desktop-shell: Rename gain/lose keyboard focus to activate/de-activate
- dbb9d215 - desktop-shell: Embed keyboard focus handle code when activating
- 77d882d7 - desktop-shell: Remove keyboard_focus_listener
- f7b9c926 - kiosk-shell: Embed keyboard focus activation code
- 0c72b35f - kiosk-shell: Remove keyboard_focus and seat_caps listeners
- ea07b41a - libweston: Rename weston_view_activate() to weston_view_activate_input()
Toggle commit list-
7646eb48...2f2e5da4 - 151 commits from branch
- Resolved by Marius Vlad
- Resolved by Marius Vlad
- Resolved by Marius Vlad
- Resolved by Marius Vlad
added Desktop shell xdg_shell and wl_shell labels
added kiosk-shell label
added 59 commits
-
ea07b41a...ec1ce9fc - 52 commits from branch
wayland:main
- dd01d3aa - desktop-shell: Remove no-op de-activation of the xdg top-level surface
- b2866003 - desktop-shell: Rename gain/lose keyboard focus to activate/de-activate
- 19430f55 - desktop-shell: Embed keyboard focus handle code when activating
- 84b87ee2 - desktop-shell: Remove keyboard_focus_listener
- ead23be1 - kiosk-shell: Embed keyboard focus activation code
- 89370506 - kiosk-shell: Remove keyboard_focus and seat_caps listeners
- bec3ecda - libweston: Rename weston_view_activate() to weston_view_activate_input()
Toggle commit list-
ea07b41a...ec1ce9fc - 52 commits from branch
mentioned in merge request !683 (merged)