Skip to content
Snippets Groups Projects

kiosk-shell: Separate (keyboard) input focus from xdg-shell toplevel window activation

Merged Marius Vlad requested to merge mvlad/weston:fix-desktop-shell-top-level-activation into main

This is small follow-up from !568 (closed) in which input focus was tied to window activation.

Note that these series has been split kiosk-shell (current MR) and desktop-shell (which have been migrated to !711 (closed))

This removes the window activation code from the keyboard focus handlers an embeds it straight into the shell's activation parts, such that devices with no keyboard can still use their other input devices (touch) to activate the window.

Edited by Marius Vlad

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Derek Foreman
    • Resolved by Marius Vlad

      This looks quite reasonable to me. I think activation and keyboard focus have been artificially tied together for too long.

      Really just one nit - I'd like to know why we're registering the set_focus listeners, because it looks like we no longer need them.

  • Marius Vlad added 158 commits

    added 158 commits

    • 7646eb48...2f2e5da4 - 151 commits from branch wayland:main
    • 367eb2c3 - desktop-shell: Remove no-op de-activation of the xdg top-level surface
    • b134342a - desktop-shell: Rename gain/lose keyboard focus to activate/de-activate
    • dbb9d215 - desktop-shell: Embed keyboard focus handle code when activating
    • 77d882d7 - desktop-shell: Remove keyboard_focus_listener
    • f7b9c926 - kiosk-shell: Embed keyboard focus activation code
    • 0c72b35f - kiosk-shell: Remove keyboard_focus and seat_caps listeners
    • ea07b41a - libweston: Rename weston_view_activate() to weston_view_activate_input()

    Compare with previous version

  • Derek Foreman approved this merge request

    approved this merge request

  • Daniel Stone changed title from Separate (keyboard) input focus from xdg-sell toplevel window activation to Separate (keyboard) input focus from xdg-shell toplevel window activation

    changed title from Separate (keyboard) input focus from xdg-sell toplevel window activation to Separate (keyboard) input focus from xdg-shell toplevel window activation

  • Daniel Stone
  • Daniel Stone
  • Daniel Stone
  • Daniel Stone
  • Marius Vlad added 59 commits

    added 59 commits

    • ea07b41a...ec1ce9fc - 52 commits from branch wayland:main
    • dd01d3aa - desktop-shell: Remove no-op de-activation of the xdg top-level surface
    • b2866003 - desktop-shell: Rename gain/lose keyboard focus to activate/de-activate
    • 19430f55 - desktop-shell: Embed keyboard focus handle code when activating
    • 84b87ee2 - desktop-shell: Remove keyboard_focus_listener
    • ead23be1 - kiosk-shell: Embed keyboard focus activation code
    • 89370506 - kiosk-shell: Remove keyboard_focus and seat_caps listeners
    • bec3ecda - libweston: Rename weston_view_activate() to weston_view_activate_input()

    Compare with previous version

  • Marius Vlad resolved all threads

    resolved all threads

  • Marius Vlad mentioned in merge request !683 (merged)

    mentioned in merge request !683 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading