Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • V virglrenderer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 40
    • Merge requests 40
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • virgl
  • virglrenderer
  • Merge requests
  • !53

vrend: Use pixel pack buffers as buffers and unbind after use

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Gert Wollny requested to merge gerddie/virglrenderer:fix-buffers into master Oct 12, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

On one hand it is simpler on GLES, because it allows direct readback, and on the other hand it fixes failures when EXT_texture_buffer is not available.

Also unbind the buffers after use because otherwise glReadPixel would interpret the pixel pointer argument as offset into the pixel buffer and would fail.

Closes: #45 (closed)

Signed-off-by: Gert Wollny gert.wollny@collabora.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-buffers