Unknow option value: too-many-positional-arguments make pylint-integration-tests fails.

Hi, I was running ninja -C _build tests and found an issue:

119/119 pylint-integration-tests                                                                   FAIL           16.22s   exit status 4
>>> UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 MALLOC_PERTURB_=0 ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 /usr/bin/pylint-3 -d W0511 -d C0302 -d C0116 -d C0114 -d W0707 -d W0706 /home/rcardoso-fedora36/power-profiles-daemon/_build/../tests/integration_test.py
―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― ✀  ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
************* Module integration_test
/home/rcardoso-fedora36/power-profiles-daemon/tests/integration_test.py:452:0: W0012: Unknown option value for 'disable', expected a valid pylint message and got 'too-many-positional-arguments' (unknown-option-value)

------------------------------------------------------------------
Your code has been rated at 9.99/10 (previous run: 9.99/10, +0.00)

too-many-positional-arguments is only available on pylint > 3.3.0:

pylint --version
pylint 3.0.4
astroid 3.0.3
Python 3.12.2 (main, Feb 21 2024, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)]

Looks like this pylint argument was introduced by this commit last week 4a367430

Should not be better use too-many-function-args instead if you have function calls that pass too many positional arguments to functions or require pylint > 3.3.0 on meson setup if need to use 'too-many-positional-arguments'?

changed the description

changed the description

So does too-many-function-args work for both older and newer pylint then?

Yes, it works, but seem to me that is not what the "lint disable" intends. The main difference between too-many-function-args and too-many-positional-arguments is that the first one is used when a function call passes too many positional arguments and the second is used when a function defined has too many positional arguments (more than 5).

Looks like the lint error for too-many-positional-arguments is only triggered for pylint 3.3.0 or higher which supports this.

This patch fix this issues for lint < 3.3.0 and ignores too-many-positional-arguments issues on lint > 3.3.0 for this function:

diff --git a/tests/integration_test.py b/tests/integration_test.py
index 98f12b0..c110b08 100644
--- a/tests/integration_test.py
+++ b/tests/integration_test.py
@@ -449,7 +449,7 @@ class Tests(dbusmock.DBusTestCase):
             + f"but '{self.read_file_contents(path)}'",
         )
 
-    # pylint: disable=too-many-arguments,too-many-positional-arguments
+    # pylint: disable=too-many-arguments,unknown-option-value,too-many-positional-arguments
     def assert_sysfs_attr_eventually_is(
         self, device, attribute, contents, timeout=800, keep_checking=0
     ):

I can do an MR if you if this solution is acceptable

I think that's a good solution, but please add a comment explaining it as well.

@superm1 !221 (merged) but looks like pre-commit phase is failing due some docker policy issue on ci (if-not-present)

mentioned in commit rcardoso/power-profiles-daemon@34275b1f

mentioned in merge request !221 (merged)

closed with commit 34275b1f

closed with merge request !221 (merged)