PPD doesn't force the SoC to active mode or to load.

As the policy of whether amd-pstate is loaded is controlled by the
kernel having another policy whether power-profiles-daemon isn't
necessary.

Do only monitor the battery percentage changes if an action or a driver
needs it

We don't need to do it for each proxy since they're all monitoring
the same owner.

So basically make the first proxy to be setup to win, not connecting to
the signal if the other is already set

Mario Limonciello authored 6 months ago and Marco Trevisan committed 6 months ago

This should fix a possible stack trace of an unset error variable.

Mario Limonciello authored 6 months ago and Marco Trevisan committed 6 months ago

Due a firmware bug on some OEM systems the amd-pstate kernel driver
starts up in active mode but EPP writes don't work.

Admittedly this is a kernel bug that it still advertises support and
it could be handled better by the kernel, but PPD can also validate
writes with a no-op for each CPU at bootup.

Do this to ensure that the CPU driver is only setup if we know it works.

Mario Limonciello authored 7 months ago and Marco Trevisan committed 6 months ago

When in power-saver set DPM clocks explicitly down to "low".

Fixes: #158

Mario Limonciello authored 7 months ago and Marco Trevisan committed 6 months ago

This will allow more actions to use a CPU check

Storing this information will be required to later support potentially
hotplugging drivers and features.

More users use power saver as their default value than expected, and
so ABM is a more negative experience for some of them.

Instead of a table of values, use "progressive" values that change
based on battery life.

The selected values:
* Balanced + AC:
  ABM 0
* Balanced + battery:
  >= 30% battery
    ABM 0
  < 30% battery
    ABM 1
* Power Saver + AC:
  ABM 0
* Power Saver + battery:
  >= 50% battery
    ABM 0
  30-49% battery
    ABM 1
  20-30% battery
    ABM 2
  <20% battery
    ABM 3

This will allow actions and drivers to react to battery level changes.

Although the system will save more power at lower frequency, AMD SoCs
have a point when they can operate most efficiently called the lowest
non-linear frequency.

Program the minimum frequency to this value in balanced and performance
modes to improve responsiveness.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>

Mario Limonciello authored 10 months ago and Mario Limonciello committed 8 months ago

Apply core performance boost in balanced and performance and
disable it when in power saver.

According to kernel documentation this file is only exposed if
the value will be the same for all CPUs.

"This attribute is present only if the value exposed by it is the same for all of the CPUs in the system."
Link: https://www.kernel.org/doc/html/v6.9-rc1/admin-guide/pm/intel_pstate.html

Marco Trevisan authored 11 months ago and Marco Trevisan committed 11 months ago

Simplify our writing function by just using pure C open/write calls
since we don't really need to be able to create files.

In fact this made possible to spot a test issue where a file was not
present and in fact in some scenarios we had random valgrind errors in
CI.

Plus, since we just need to write the contents as it is, we can avoid
extra buffers.

We can just return directly most of the times

Using GList is sub-optimal and eventually needs just more allocations
and iterations, so use arrays instead which provide a nicer API.

This is not strictly needed because we don't have objects with multiple
references around, but it's still something nice to do, so disconnect
when we don't need an object anymore.

These will set the environment variables accordingly to block drivers
or actions from loading.

Set the default log level to MESSAGE.
If launched with -v, upgrade to INFO.
If launched with -vv, upgrade to DEBUG.

Fixes: #145
Fixes: #71

This was used just by one driver, but it's better to keep this in the
daemon and to be enabled only if a driver requires it

We don't really need a full dbus proxy here, but only to monitor a
signal change, so let's go cheap and use just a signal monitor.

The value returns a boolean, not PpdProbeResult