Skip to content
Snippets Groups Projects
  1. Apr 11, 2023
  2. Apr 10, 2023
  3. Apr 07, 2023
  4. Apr 06, 2023
  5. Apr 05, 2023
  6. Apr 04, 2023
  7. Apr 01, 2023
  8. Mar 31, 2023
  9. Mar 30, 2023
    • Ilie Halip's avatar
      typefindfunctions: Increase xml typefinder closing brace limit · 476a8aca
      Ilie Halip authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      If the first XML element in a DASH manifest has its closing brance
      beyond the first 512 bytes (because of, e.g. lots of attributes),
      the MPD typefinder fails. Try to read a larger block, and then
      smaller blocks until 512 bytes.
      
      Fixes gstreamer/gstreamer#2385
      
      Part-of: <gstreamer/gstreamer!4302>
      476a8aca
    • Bart Van Severen's avatar
      rtsp: gstrtspurl: gst_rtsp_url_get_request_uri: use rtsps scheme for tls transport methods · d2678a1f
      Bart Van Severen authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      gst_rtsp_url_get_request_uri returns rtsp://... url when requested url is rtsps://, this is not
      in accordance with https://www.rfc-editor.org/rfc/rfc7826.html#section-19.2.
      This also impedes setting up a rtsps session with a live555 rtsp server.
      
      Don't expose other than rtsp and rtsps internal gstreamer rtsp url schemes
      to avoid regression:
      gstreamer/gstreamer#2412
      
      Part-of: <gstreamer/gstreamer!4298>
      d2678a1f
    • Bart Van Severen's avatar
      Revert "rtsp: gstrtspurl: gst_rtsp_url_get_request_uri: fix incorrect scheme... · e8d7f326
      Bart Van Severen authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      Revert "rtsp: gstrtspurl: gst_rtsp_url_get_request_uri: fix incorrect scheme for tls transport methods"
      
      This reverts commit 024ef765 because it causes a regression:
      gstreamer/gstreamer#2412
      
      Part-of: <gstreamer/gstreamer!4298>
      e8d7f326
    • Colin Kinloch's avatar
    • Víctor Manuel Jáquez Leal's avatar
      vkmemory: flush whole size · 2b1dbefc
      Víctor Manuel Jáquez Leal authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Running element_vkcolorconver test with Vulkan validation layer this error is
      raised:
      
      Code 0 : Validation Error: [ VUID-VkMappedMemoryRange-size-01390 ] Object 0:
      handle = 0x100000000010, type = VK_OBJECT_TYPE_DEVICE_MEMORY;
      | MessageID = 0xdd4e6d8b
      | vkFlushMappedMemoryRanges: Size in pMemRanges[0] is 0x4, which is not a
      multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x40) and offset +
      size (0x0 + 0x4 = 0x4) not equal to the memory size (0xb). The Vulkan spec
      states: If size is not equal to VK_WHOLE_SIZE, size must either be a multiple of
      VkPhysicalDeviceLimits::nonCoherentAtomSize, or offset plus size must equal the
      size of memory
      
      The reason of is that the image size used in the test doesn't comply hardware
      restrictions. In order to avoid juggling with image size and hardware
      restrictions, this patch proposes to use VK_WHOLE_SIZE macro.
      
      Part-of: <gstreamer/gstreamer!4311>
      2b1dbefc
    • Víctor Manuel Jáquez Leal's avatar
      tests: vkimage: add VK_IMAGE_USAGE_SAMPLED_BIT usage bit · 1461c1d5
      Víctor Manuel Jáquez Leal authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Running tests with Vulkan Validation enabled show an error on vkimage tests:
      
      Code 0 : Validation Error: [ VUID-VkImageViewCreateInfo-image-04441 ]
      Object 0: VK_NULL_HANDLE, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle
      = 0x50000000005, type = VK_OBJECT_TYPE_IMAGE;
      | MessageID = 0xb75da543
      | Invalid usage flag for VkImage 0x50000000005[] used by vkCreateImageView(). In
      this case, VkImage should have VK_IMAGE_USAGE_SAMPLED_BIT |
      VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT |
      VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT |
      VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT |
      VK_IMAGE_USAGE_FRAGMENT_SHADING_RATE_ATTACHMENT_BIT_KHR |
      VK_IMAGE_USAGE_FRAGMENT_DENSITY_MAP_BIT_EXT |
      VK_IMAGE_USAGE_VIDEO_DECODE_DST_BIT_KHR |
      VK_IMAGE_USAGE_VIDEO_DECODE_DPB_BIT_KHR |
      VK_IMAGE_USAGE_VIDEO_ENCODE_SRC_BIT_KHR |
      VK_IMAGE_USAGE_VIDEO_ENCODE_DPB_BIT_KHR | VK_IMAGE_USAGE_SAMPLE_WEIGHT_BIT_QCOM
      | VK_IMAGE_USAGE_SAMPLE_BLOCK_MATCH_BIT_QCOM set during creation.
      The Vulkan spec states: image must have been created with a usage value
      containing at least one of the usages defined in the valid image usage list for
      image views
      
      This patch adds VK_IMAGE_USAGE_SAMPLED_BIT to the usage bits in test.
      
      Part-of: <gstreamer/gstreamer!4311>
      1461c1d5
    • Víctor Manuel Jáquez Leal's avatar
      vkfullscreenquad: set enable_clear as TRUE by default · 11824d62
      Víctor Manuel Jáquez Leal authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      While using the validation layer with this pipeline:
      
      gst-launch-1.0 videotestsrc num-buffers=10 ! vulkanupload ! vulkancolorconvert ! vulkansink
      
      The validation layer throws this message:
      
      Code 0 : Validation Error: [ VUID-VkAttachmentDescription-format-06699 ]
      Object 0: handle = 0x5555562e9610, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x52b3229e |
      vkCreateRenderPass: pCreateInfo->pAttachments[0] format is
      VK_FORMAT_B8G8R8A8_UNORM and loadOp is VK_ATTACHMENT_LOAD_OP_LOAD, but
      initialLayout is VK_IMAGE_LAYOUT_UNDEFINED.
      The Vulkan spec states: If format includes a color or depth aspect and loadOp is
      VK_ATTACHMENT_LOAD_OP_LOAD, then initialLayout must not be VK_IMAGE_LAYOUT_UNDEFINED
      
      When creating the render pass the loadOp can be either
      `VK_ATTACHMENT_LOAD_OP_CLEAR` or `VK_ATTACHMENT_LOAD_OP_LOAD` depending on
      `enable_clear`. While `enable_clear` is FALSE by default (which means
      `VK_ATTACHMENT_LOAD_OP_LOAD`). Nonetheless, its value is explicitly changed by
      `vkoverlaycompositor` to FALSE too!
      
      This behavior was introduced in merge request #2470 where
      `VK_ATTACHMENT_LOAD_OP_CLEAR` was a fixed value for loadOp. Thus, the bug
      consists in a missing initialization of `enable_clear` to TRUE from that merge
      request.
      
      Part-of: <gstreamer/gstreamer!4311>
      11824d62
  10. Mar 28, 2023
  11. Mar 27, 2023
  12. Mar 25, 2023
  13. Mar 24, 2023
  14. Mar 22, 2023
    • Piotr Brzeziński's avatar
      qtdemux: Fix seek adjustment with SNAP_AFTER flag · 6dad5345
      Piotr Brzeziński authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      With GST_SEEK_FLAG_SNAP_AFTER present, the previous version would
      adjust seek time based on the keyframe farthest away from desired_time.
      This was incorrect, because we always want the *earliest* suitable keyframe
      to seek to, not the last one.
      With this fix, in case of the SNAP_AFTER, we now look for the closest keyframe
      that can be found after desired_time. Behaviour for SNAP_BEFORE should remain
      unchanged.
      
      Part-of: <gstreamer/gstreamer!4251>
      6dad5345
Loading