- Jul 20, 2021
-
-
Wim Taymans authored
-
Wim Taymans authored
We should actually emit the graphorder callback whenever something changed, also when a client or port was added/removed. Also emit the graphorder callback right after a client is activated to make jackdbus work.
-
Wim Taymans authored
Refuse to move a node to a new target when they belong to the same link-group to avoid loops. Fixes #1376
-
- Jul 19, 2021
-
-
Wim Taymans authored
Fixes #1423
-
Wim Taymans authored
When nothing else is specified, add a default node.link-group property so that all the nodes from this echo-canceler are tagged as being linked together in some way. This allows the session manager to follow the relations between the different streams and avoids linking those related nodes together, which avoids playing or recording from itself in a loop. Fixes #1376
-
Wim Taymans authored
The mempools list keeps track of all allocated mempools but is otherwise not used. Because it is not protected with a lock, concurrent contexts or thread loops can step on eachother and crash. Remove this for now until we actually need it and implement it with some sort of lock. Fixes #1416
-
Wim Taymans authored
Try harder to get the transport frame_rate from the position. If we can't find an activation structure, use the configured frame_rate instead of 0. Fixes #1432
-
Wim Taymans authored
First calculate the size of the aligned payload and then check if we can fit this aligned payload in the remaining space in the ringbuffer. Otherwise we might be able to fit the item + payload in the remaining space but then place the alignment bytes at the begginning, which would break alignment of the next invoke_item struct.
-
Wim Taymans authored
Also check if there is enough space to write the payload bytes. We check if there is enough space for the invoke_item structure first. Then we calculate how much bytes we need to use for the payload but we fail to check if we can actually write that much data, risking overwriting existing data from the ringbuffer and causing a crash later when we try to jump to invalid memory. Add some more comments.
-
- Jul 14, 2021
-
-
We know these are up-to-date and they are based off a minimal base system.
-
Peter Hutterer authored
And set up a CI job to check for that.
-
- Jul 13, 2021
-
-
Otherwise the udev device leaks when restarting the monitor
-
-
- Jul 12, 2021
-
-
Den Ivanov authored
-
Arun Raghavan authored
Fixes: pipewire/pipewire#1407
-
- Jul 11, 2021
-
-
The kernel-provided SCO write MTU is currently never the correct packet size for writing, so don't try to use it. Some adapter firmware (eg. BCM20702A0 0b05:17cb) appears in practice sensitive to the alignment of the msbc frames, and writes with wrong packet size break things but only on certain headsets. For other adapters, this doesn't appear to matter.
-
According to the A2DP spec, the payload type should be set to a number between 96 and 127. This is fixed for AAC codec, but not the rest. Original PulseAudio issue: pulseaudio/pulseaudio#591
-
- Jul 08, 2021
-
-
Julian Bouzas authored
-
- Jul 07, 2021
-
-
Wim Taymans authored
Ignore changes to the object. Otherwise, we would remove and publish the device again for each volume change. Fixes #1406
-
Wim Taymans authored
Don't reuse the visited variable for checking feedback loops because the scheduler expects it to be false on entry. Use a different variable instead.
-
Wim Taymans authored
Only check the current active profile when some routes changed that are part of the profile. If some other route changed, just ignore it. Fixes #1403
-
-
This test currently prevents us from running the test suite in valgrind but it's not a straightforward fix. So in the meantime, skip this test when running under valgrind.
-
-
Fixes bba9edab
-
Works around the valgrind complaints when we call spa_debug_mem() on the buffer with various sizes.
-
Running under valgrind enforces --no-fork so any signal will cause valgrind to error out, failing the test abnormally. This prevents us from running our test suite through valgrind, we'd have to mark every test specifically whether it should run under valgrind or not. Easier is just to automatically skip tests expecting signals.
-
Wim Taymans authored
Mark peer nodes as visited and only visit them once. Reduces the complexity a lot. Limit the number of hops we check to 32 to avoid excessive work.
-
- Jul 06, 2021
-
-
Jonas Holmberg authored
Make sure the string isn't overwritten while another thread is reading it. Fixes #1402
-
Wim Taymans authored
-
Wim Taymans authored
-
Wim Taymans authored
-
Wim Taymans authored
-
Wim Taymans authored
Keep the result of the follower in res2, fail if we could not set the properties on both the follower and the converter.
-
Wim Taymans authored
-
Wim Taymans authored
Fixes #1374
-
Wim Taymans authored
It can be more generally useful eventually.
-
Wim Taymans authored
s24_32 needs to be sign extended before converting to float because the upper bits are undefined and might be anything. Fixes #1393
-
Wim Taymans authored
When a link is added and removed, emit the graph callback.
-
Wim Taymans authored
The thread loop is already taken when calling port_update_latency. Improve some debug, add some comments.
-