Christophe Fergeau authored 6 years ago and Frediano Ziglio committed 6 years ago

log_draw() is used to debug drawing commands by dumping drawing
information to the JS console. This commit adds dumping of missing data
for uncompressed bitmaps. The 'stride' parameter is important, as
spice-html5 currently does not deal properly with such bitmaps.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Acked-by: Jeremy White <jwhite@codeweavers.com>

This allows show or hide debug console under spice screen.

Tomáš Bohdálek authored 7 years ago and Jeremy White committed 7 years ago

Make sure to show both screen and console.

Vincent Desprez authored 8 years ago and Jeremy White committed 8 years ago

Signed-off-by: Vincent Desprez <vincent.desprez@apwise.com>

This fixes a bug introduced by my commit 42134d3e, which would
lead to an infinite recursion of onload statements.

This helps us avoid stalled video streams.

This helps Firefox in situations where the incoming traffic
is preventing the audio element from processing data quickly enough.

It's a fair amount of noise, and not useful at level 1.

They are low frequency, useful messages and should be seen
more readily.

They are fairly noisy, and more appropriate to the
more detailed level.

Otherwise, we end up discarding stream data messages, and our decode
can become corrupted, notably on Chrome.

This way, we should not lose any messages while we are waiting for
source buffer creation.

This allows audio processing to be more robust in Firefox.

Browsers now reliably autoplay, and issuing play prematurely
can generate an error in both Firefox and Chrome.

Hence we can simply remove this call and audio seems to work fine.

Around version 45, Firefox started being very particular about the
time stamps put into the Opus stream.  The time stamps from the Spice server are
somewhat irregular.  They mostly arrive every 10 ms, but sometimes it is 11, or sometimes
with two time stamps the same in a row.  The previous logic resulted in fuzzy and/or
distorted audio streams in Firefox in a row.

Thus, we end up with an inelegant hack.  Essentially, we force every packet to have
a 10ms time delta, unless there is an obvious gap in time stream, in which case we
will resync.

This replaces logic that mitigated only the duplicated time packets.

The long term solution would appear to be 'sequence' mode, but I cannot get
Firefox to use that mode (and MDN suggests that for codecs such as VP8 with time
stamps in line, that Firefox will not accept it).

We previously had a fairly crude 'gap detection', but browsers
are largely supporting the modern buffer semantics, and we can
now rely on them to detect under runs for us.

This improves audio in Chrome while playing large videos.

Debugger is not an object or command. It is a reserved word and
"DEBUG > 0 &&" syntax does not work with it

Allow to work with more channels of one type

Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=97575



Acked-by: Victor Toso <victortoso@redhat.com>

Oliver Gutierrez authored 8 years ago and Christophe Fergeau committed 8 years ago

The playback code first tries to access this.source_buffer and then
would check whether it's defined.

This was causing unwanted exception to be thrown in the cockpit
spice-html5 plugin.

Previously, we sent them strictly upon receipt.  However, receiving
is fast; by adding in some of the processing time (i.e. queueing and
so on), we encourage the adaptive rate control to slow down.

Martin Hradil authored 8 years ago and Christophe Fergeau committed 8 years ago

Right now, `spice_auto.html` reads the path from query string .. and
never actually does anything with it. This should make
`spice_auth.html` respect a path parametr when given.

Pavel Grunt authored 8 years ago and Jeremy White committed 8 years ago

Spotted by coverity