Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

It's from Oct 2020, and widely available on various distro or backports.

Fix related meson warnings.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

meson wraps python scripts already on win32:

"C:/msys64/mingw64/bin/meson" "--internal" "exe" "--capture" "src/vncdisplaykeymap_xorgevdev2xtkbd.h" "--" "C:/msys64/mingw64/bin/python.exe" "python" "C:/msys64/home/marca/src/spice-gtk/subprojects/keycodemapdb/tools/keymap-gen" "code-m
ap" "--lang" "glib2" "--varname" "keymap_xorgevdev2xtkbd" "../subprojects/keycodemapdb/data/keymaps.csv" "xorgevdev" "xtkbd"
--- stderr ---
C:/msys64/mingw64/bin/python.exe: can't open file 'C:\\msys64\\home\\marca\\src\\spice-gtk\\build\\python': [Errno 2] No such file or directory

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

WARNING: find_library('libws2_32') starting in "lib" only works by accident and is not portable
Library libws2_32 found: YES
WARNING: find_library('libgdi32') starting in "lib" only works by accident and is not portable
Library libgdi32 found: YES
WARNING: find_library('libcomctl32') starting in "lib" only works by accident and is not portable
Library libcomctl32 found: YES

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

WARNING: extract_all_objects called without setting recursive

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

../src/spice-widget-egl.c:204:17: error: unused variable 'gdk_dpy' [-Werror=unused-variable]
  204 |     GdkDisplay *gdk_dpy = gdk_display_get_default();

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

When EGL is enabled (thanks to epoxy/angle), spice-gtk fails to link
against epoxy. Link with it when EGL is enabled.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Adjust `#ifdef` statements to use the single define.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Win32 has #define for those.

Change variable names `near` and `far` to `_near` and `_far`.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

msizanoen1 authored Dec 10, 2022 and Marc-André Lureau committed Jan 09, 2023

Same as a945a3c2 but for Wayland.

Fixes breakage caused by GTK behavior change in
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/5159.

Frediano Ziglio authored Oct 11, 2022 and Marc-André Lureau committed Dec 13, 2022

Otherwise they are not showed when rendered.

Hardware support for Apple iOS is not available, check correctly
and not try to use it.

Signed-off-by: osy <osy@turing.llc>
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Tested-by: osy <osy@turing.llc>

Fabio Estevam authored Oct 11, 2022 and Frediano Ziglio committed Oct 11, 2022

Currently, it is not possible to build spice-gtk on a Wayland-only
environment due to the x11 dependency in meson.

Since commit a7381b08

 ("Allow to build without X11 gdk backend)
it is possible to build spice-gtk without X11 GDK backend, so make
the x11 dependency in meson optional.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Frediano Ziglio <freddy77@gmail.com>

This patch fixes bad filtering of USB devices.

The logic was introduced for windows clients in commit b8389376 but was
moved in 2e19014e and executed also by non windows clients, resulting
in this bug.

Fixes: 2e19014e "usb-redir: isolate usage of libusb and usbredirhost"
Fixes: #157


Signed-off-by: Victor Toso <victortoso@redhat.com>

NorwayFun authored Sep 07, 2022 and Frediano Ziglio committed Sep 08, 2022

Signed-off-by: NorwayFun <temuri.doghonadze@gmail.com>
Acked-by: Frediano Ziglio <freddy77@gmail.com>

This simple change adds keyboard shortcuts for manual synchronization of
copy/paste buffers. These come in handy when automatic clipboard sharing
is disabled, which may be desirable to prevent a semi-trusted server
from reading sensitive data populated by password managers and similar.

Shift+F5/F6 ain't the most comfortable shortcuts, but it sticks with the
current theme.

Marc-André Lureau authored Jul 04, 2022 and Marc-André Lureau committed Jul 04, 2022

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Install whole wine instead of just core.
Set language to avoid warning in GLib.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Fix compilation warnings when building against openssl 3.0

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Prefer libsoup 3.0 over 2.0, when available.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Frediano Ziglio (1):
      Replace EVP_PKEY_cmp with EVP_PKEY_eq

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

The keycodemapdb Meson subproject provides a program and a source input.
Since it is a subproject, Meson wants to sandbox that and requires it to
be explicitly exported. But this never happened -- instead, we manually
poked at files using the actual string path "subprojects/......"

This was always a Meson sandbox violation, but Meson 0.63.0 started
noticing it and erroring out.

Instead, do the right thing. Update the subproject to a version that has
a meson.build with actually meaningful contents -- namely, a files
variable and a found program. Then use these in order to run the needed
custom_target.

In the process, it is also necessary to correct the argument ordering
when running keymap-gen.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

osy authored Mar 04, 2022 and Frediano Ziglio committed Mar 06, 2022

Cairo is only used in SpiceDisplay which is part of the GTK client. If
we are building the GLib only client, it should be optional.

libucontext is a lightweight implementation of ucontext for platforms
that do not have a built-in implementation. This allows us to use the
same code to support libucontext as ucontext.

Signed-off-by: Victor Toso <victortoso@redhat.com>

iordan iordanov authored Dec 23, 2021 and Frediano Ziglio committed Jan 28, 2022

by passing an open file descriptor in order to support the modern
Android USB device permissioning scheme.

During the process, a handle obtained by a call to
libusb_wrap_sys_device() is stored in the SpiceUsbDevice instance.

A call to libusb_open() is skipped if there is already a handle
present in the SpiceUsbDevice instance.

Finally, on Android, the option LIBUSB_OPTION_NO_DEVICE_DISCOVERY
must be set prior to the call to libusb_init() as per libusb
documentation.

Acked-by: Frediano Ziglio <freddy77@gmail.com>

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (2):
      build: Correctly check for Python modules
      ci: Set WINEPATH during Windows build

This fixes #152

.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

Kevin Pouget authored May 14, 2020 and Joan Bruguera committed Jan 18, 2022

Adds support for capturing and forwarding the side mouse buttons some mouses
have, typically used in web browsers for previous/next website in history.
(Those are presented by GDK as buttons 8 and 9.)

spice-vdagent requires a corresponding patch to handle the buttons.

At the spice and protocol level, the required changes were previously merged:
* spice#45
* spice!140
* spice-protocol!22

This commit is a rebased and revised version of the patch by Kevin Pouget:
https://www.spinics.net/lists/spice-devel/msg42582.html


(I have confirmed with him that it's OK that I submit the updated patches.)

Co-Authored-By: Kevin Pouget <kpouget@redhat.com>
Co-Authored-By: Joan Bruguera <joanbrugueram@gmail.com>

This will pass hostname.
This fixes #137.

You can easily verify the change with a network capture program running
something like

    remote-viewer spice+tls://www.spice-space.org:443



you will see the hostname in the initial exchange.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Use proper ioctls for MacOS.
Import new spice-common to solve an issue detecting Python3.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Resolve some portability issue, like MacOS.
Macros from <endian.h> were used but not all systems have
this header.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Victor Toso <victortoso@redhat.com>

See also: https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719



Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

gdk_monitor_get_geometry() may return 0-size, and leads to crash:
https://bugzilla.redhat.com/show_bug.cgi?id=1941627



Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Bastien Orivel authored Apr 16, 2021 and Frediano Ziglio committed Apr 17, 2021

This fixes a regression from 032ca202


where a check on whether the usbids file contained anything but the
wrong variable was checked. This is visible on windows when trying to
share a USB device as devices won't get named based on the usbids file.
Same thing on linux if we can't read the name from the sysfs.

`usbids_vendor_info` is only initialized to something not NULL after it
was checked to be different from NULL which is obviously wrong. The
patch wanted to check that the `usbids_vendor_count` was different from
0 instead.

Acked-by: Frediano Ziglio <freddy77@gmail.com>

Note: that unusual function seems problematic for GI in general, we may want a simple pointer instead..
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>