GitLab

If we read 0 bytes from the phodav server,
the client connection was closed by the server.

In that case, remove the client immediately,
instead of waiting for the data to be written to the mux channel.

Fixes: https://lists.freedesktop.org/archives/spice-devel/2020-July/051765.html

I believe that the underlying issue, that is causing the described problems,
is that libsoup closes the connection after each request
although the webdav client wanted it to be persistant (keep-alive).

Filed an issue for libsoup:
https://gitlab.gnome.org/GNOME/libsoup/-/issues/195

Additionally, spice-webdavd does not close the connection
when it receives 0-size message for a given webdav client.

As a result, single webdav client can send multiple request using one
connection to spice-webdavd, but in spice-gtk for each request
a new client with the same id must be created.

This leads to basically a race condition when there's still the
client with the given id in the hash table, but the connection
was already closed by libsoup/phodav server. So a new client should
be started but the old closed one is used. The write op then
naturally fails with the following error and the request is lost:

    ../spice-gtk-0.38/src/channel-webdav.c:325 webdav-11:0: write failed: Stream is already closed

So check whether the output stream is closed before demuxing.

Also add some debug messages.
Signed-off-by: Jakub Janků <jjanku@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This is a follow-up to 228caca2 (!52)

85ed2684 left some residues
in spice-session-priv.h, remove them.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

When `build-aux/git-version-gen` is not able to find the project
version (no git tags and no `.tarball-version`), it returns 'UNKNOWN'
or 'UNKNOWN-dirty' (instead of the project version like
`0.38.28-d79b`).

This `UNKNOWN` value fails `meson build` command:

    src/meson.build:9:0: ERROR: Index 1 out of bounds of array of size 1.

With this patch, we set a default major/minor/micro value when the
actual version is unknown. This is the same as the `autoconf`
historical behavior.

See spice#41.
Signed-off-by: Kevin Pouget <kpouget@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

spice_session_get_webdav_magic() was removed by 85ed2684,
but the declaration in spice-session-priv.h wasn't.
Signed-off-by: Jakub Janků <jjanku@redhat.com>

Detect presence of detail on VD_AGENT_FILE_XFER_STATUS_ERROR and
if the error is supported give more detailed information, otherwise
fallback to the old generic error.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

We can now properly manage mouse pointer lock by using the wayland protocols.
Includes fix from Frediano Ziglio to manage switching from mouse in
server mode to client mode without releasing the pointer
(see fziglio/spice-gtk@c14b047e)
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This will be used later to couple it with relative mouse movement under
Wayland: we just get the mouse movement from the Wayland protocols
callback.
Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

add utilities to lock the pointer to a window and to get relative mouse
movement in Wayland. This is made possible thanks to the wayland
protocols introduced in the previous commit.

Code freely taken and adapted from Christophe Fergeau branch:
https://gitlab.freedesktop.org/teuf/spice-gtk/-/tree/waylandSigned-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Generate wayland protocols: these will be used later for locking the
mouse pointer and getting relative mouse movements when using the mouse
in server mode in Wayland.
The meson build steps have been freely taken and adapted from Weston
source code:
https://gitlab.freedesktop.org/wayland/weston/-/blob/master/protocol/meson.buildSigned-off-by: Francesco Giudici <fgiudici@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

When SASL is in use, its buffer may contain remaining data from previously
received messages. The spice_channel_iterate_read should use it, even if c->in
socket is not readable.

Fixes: #126Acked-by: Frediano Ziglio <fziglio@redhat.com>

The executable is not intended to be called by users.
Many distributions already relocate the executable to another
directory.
This fixes Gitlab issue #123.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Avoid one ternary operator inside another ternary operator.
Also remove no-C syntax.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

Fixes: #124Acked-by: Frediano Ziglio <fziglio@redhat.com>

This allows SPICE common to request the right version.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (3):
      helper-fuzzer-demarshallers: Add an helper for fuzzy testing demarshallers code
      Add helper code for agent messages
      agent: Fix incompatibility with Visual Studio compiler
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

This brings in the following changes:

Frediano Ziglio (1):
      build: Allows to request a greater SPICE protocol version
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>

usbredir only supports little endian, using on big endian machine
won't work causing crashes.
Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Acked-by: Francesco Giudici <fgiudici@redhat.com>

On file systems without capabilities attributes, drop capabilities at
runtime from the start.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

A privileged executable should operate with the least amount of
privileges possible. For spice-client-glib-usb-acl-helper, this is
CAP_FOWNER for acl_set_file() to succeed.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

It was released on 2011-03-03, and is available in old debian stable
and all distros we care about.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

emacs mode got removed with:
git ls-tree HEAD -r --name-only | xargs sed -i '/Mode: C/d'
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

After commit 47e149705a5bb1d4a615facfd9bd0190d9b0647c
(cfr "proto: Generate correct constants for smartcard support")
msgc_smartcard_header was renamed to a more proper
msgc_smartcard_data.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

This brings in the following changes:

Frediano Ziglio (7):
      ci: Fix build of spice-protocol
      lz_common: Remove unused commented out define
      test-logging: Do not use G_PASTE to join level
      ci: Use spice-protocol master for make-win job
      build: Allow to build disabling code generation
      proto: Allows to specify @deprecated option for flags and enums
      messages: Remove obsolete structure definition

Kevin Pouget (1):
      spice.proto: add quality_indicator messages

Victor Toso (1):
      sound: remove celt support
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

VDAgentFileXferStatusMessage message can or cannot contain detailed
information attached to it.
Detect this correctly checking capabilities and flags.
This fixes a small buffer overflow reading in case the details are
off the payload.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Some mistake in recent patch, thanks to Marc-André's eagle eyes.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

In big endian system GUINT32_TO_LE macro uses the parameter
multiple time causing serial to be incremented multiple times
instead of one.
Avoid side effects using a temporary variable.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Not used anymore
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

GStreamer is a hard requirement since ac0e50f5 or v0.36 wich is the
same release that PulseAudio backend was deprecated:

    9a4b3bcb "build-sys: deprecate the pulseaudio backend" in 2019-01-14
Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Follow up of spice-protocol's deprecation of celt mode.
See: spice-protocol!15Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Generated with `ninja spice-gtk-update-po`

Fixes: #119Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

So we can have the v0.38 release with a few more tests plus the
removal of warning in meson build.

Frediano Ziglio (8):
      test-quic: Avoid namespace conflict with Gdk API
      test-quic: Cache gdk_pixbuf_get_byte_length value
      test-quic: Reduce height of test image
      test-quic: Run 1 random quic test per color mode
      m4: Make easier to integrate in other projects
      Add missing dependency in Autoconf integration
      test-utils: Add a test for some utils.h functions
      build: Use warning_level option for Meson

Kevin Pouget (1):
      utils: add set_bitmap/test_bitmap functions
Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Thanks to @Illumaria
Fixes: #96

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

The protocol uses a u8 for the selection value. Make sure the given
argument value fits there, or throw a critical.

The other places seem to use u8 variables already.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Delay the release events for 0.5 sec. If no further grab comes in,
then release the grab. Otherwise, let's skip the release. This avoids
some races with clipboard managers.

Related to:
#82Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>