Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pulseaudio pulseaudio
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 895
    • Issues 895
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • PulseAudioPulseAudio
  • pulseaudiopulseaudio
  • Merge requests
  • !763

client-conf: Check XDG_SESSION_TYPE

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Peter Harris requested to merge peterh/pulseaudio:envtype into master Dec 29, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

If systemd is in use, the XDG_SESSION_TYPE will probably be set (usually to "wayland", "x11", or "tty"). If XDG_SESSION_TYPE is set to something other than "wayland", connect to the X11 server to request properties.

Commit 79a8efb4 stopped connecting to the X server unless SSH_CONNECTION is set in the environment, to avoid launching a useless xwayland process. However, there are many more circumstances in which a remote X server may be in use. For example, XDMCP or VNC.

This does not completely fix #1412, but it does improve the situation.

This is an alternative to !760

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: envtype