Regression: PULSE_SERVER x11 property is not respected

Summary

Since commit 79a8efb4, the X11 PULSE_SERVER property is not respected unless the connection is SSH.

This breaks multiple-tenant scenarios (imagine a VNC server with multiple different users connected, each with their own pulseaudio daemon configured to forward audio over the network to the end-user). Since the connections are via VNC (or other remote access software), there is no SSH_CONNECTION environment variable set. This is especially true when using XDMCP to run the session, which definitely isn't SSH.

Steps to reproduce

Run multiple pulseaudio daemons (each with a different sink) and multiple X11 servers, and set the PULSE_SERVER property in each X11 server to point to a different pulseaudio daemon.

What is the current bug behavior?

The PULSE_SERVER property on $DISPLAY is ignored (unless the SSH_CONNECTION environment variable is set) and (eg) paplay does not connect to the correct pulseaudio daemon (audio does not come out of the expected sink).

What is the expected correct behavior?

paplay (and other Pulse clients) should respect the PULSE_SERVER property set on $DISPLAY, regardless of the remote connection type used.

Reverting 79a8efb4 would resolve this issue.