This allows pavucontrol to be specifically addressed when creating GTK
themes.

Christoph Haag authored 5 years ago and Arun Raghavan committed 5 years ago

Fixes a warning with the 'Valve VR Radio & HMD Mic' device.

This looks better, requires less code and probably fixes
#63

The updating flag is used to determine whether a change in some UI
control state is due to a user action or an update from the server. The
flag was set to false too early when processing sink and source updates
from the server. This caused at least unnecessary "set port" commands,
because each update refreshes the port list, which generates change
events in the port list combo box, causing the portChanged callbacks to
be called.

The unnecessary "set port" commands could even confuse the automatic
port selection policies in the server. If the current port wasn't
originally explicitly chosen by the user, then the "set port" command
from pavucontrol will make the server think that the user explicitly
chose that port.

If load_icon() fails, we treat the icon name as a file path and try to
load an image from the path. In case that works, we need to ensure that
the has correct size. Previously that wasn't done, which led to too
large icons.

scale_simple() doesn't do anything if the image is already the correct
size, so we can call it unconditionally.

The exception handling was a bit weird in that the exception types
didn't match the documentation of IconTheme::load_icon() and
Image::set(). I updated the exception types (Image::set() doesn't need
exception handling any more, because now it's called with a Pixbuf
rather than a file name).

Fixes: #60

Andreas Rönnquist authored 6 years ago and Tanu Kaskinen committed 6 years ago

Disable closing using Esc, to avoid closing the window by mistake.

When opening pavucontrol.glade with Glade 3.22.1, this message was
shown:

    pavucontrol.glade targets Gtk+ 2.16

    But this version of Glade is for GTK+ 3 only.
    Make sure you can run this project with Glade 3.8 with no deprecated
    widgets first.

I think it's best to just drop the gtk2 support.

Colin Leroy authored 7 years ago and Tanu Kaskinen committed 7 years ago

This introduces a new file for clarity. Options
handling changes so that --tab changes the tab
if the window is already opened. Other options
are only used at start time.

Felipe Sateler authored 8 years ago and Tanu Kaskinen committed 8 years ago

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=86398

Lukas K. authored 10 years ago and Tanu Kaskinen committed 8 years ago

Add a checkbutton for disabling volume meters because of high CPU
utilisation when updating them

Steven Dwy authored 10 years ago and Peter Meerwald-Stadler committed 10 years ago

stores the type of devices that are shown for Playback,
Recording, Output Devices, Input Devices, resp.

Martin Steghöfer authored 10 years ago and David Henningsson committed 10 years ago

Due to another bug the MIME type guessing of PNG files was broken on my
Ubuntu system. This made pavucontrol crash on startup (while loading the
necessary icons) without a helpful error message (requiring a lot of
debugging effort). Although this is not originally pavucontrol's fault,
I think that pavucontrol could be more robust about such a problem,
especially because:

A) In a complex database like the one to guess MIME types (that is populated
from hundres of different packages) this can happen from time to time and
B) pavucontrol already has some fallback options in place - they are just not
active in this specific case.

BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=88813

If gtk cannot load the file, it may throw a Gio::Error. In that case
fall back to setting the name.

BugLink: https://bugs.debian.org/765725

pa_stream_peek can return NULL if either the buffer is empty or if it
has a hole. In either case we need to avoid derefencing the data
pointer. Additionally, if there is a hole, we need to call pa_stream_drop,
if the buffer is empty we should not call it.

BugLink: https://bugs.debian.org/735898

Widgets (unlike Windows and Dialogs) returned by Gtk::Builder::get_widget*
start owned by the GtkBuilder object, the idea being that they will get
added to a container before the scope of the GtkBuilder object ends, and it
thus automatically gets destroyed.

But in the various ::create methods in pavucontrol, a pointer to the widget
gets returned, so that it can be added to a cointainer by the caller.
However as soon as the ::create method exits the GtkBuilder object owning
the widget, and thus also the widget gets destroyed, and we end up returning
free-ed memory.

This commit fixes this by making all ::create methods take a reference on
the widget before returning it, and having all the callers unreference the
widget after adding it to a container.

https://bugs.freedesktop.org/show_bug.cgi?id=83144
https://bugzilla.redhat.com/show_bug.cgi?id=1133339



Signed-off-by: Hans de Goede <hdegoede@redhat.com>

ellipsize labels to make the window resizable even with long label text
and add tooltips to provide a way to read the full text

Originally from Sebastian Wick <sebastian@sebastianwick.net>

poljar (Damir Jelić) authored 12 years ago and Tanu Kaskinen committed 12 years ago

If we know if a certain port is available/unavailable, we can print
that out, as a help to the user (and as debugging for ourselves).
A profile is also available/unavailable if all ports which have that
profile are available/unavailable.

Credit goes to David Henningson for the original idea and some of the code.

The prepareMenu() call can change the active profile selection, which
in turn will cause a "set card profile" command to be sent to the
server if the "updating" flag is not set, so the "updating" flag needs
to be set when calling prepareMenu() from updateCard().

This caused a problem with disconnecting bluetooth headsets: as part
of the disconnection procedure, module-bluetooth-device sets the card
profile to "off". At that point module-card-restore doesn't do
anything, because the change is marked as "don't save". But the
profile change event is then sent to pavucontrol, which updates its
view, and pavucontrol sends the new profile ("off") back to
pulseaudio, and this time the profile change iss marked as "please
save", so module-card-restore restores the "off" profile when the
device is connected again, even though the user never requested the
"off" profile to be chosen.

poljar (Damir Jelić) authored 12 years ago and Tanu Kaskinen committed 12 years ago

This change adds the ability to change the latency offset of a port with
pavucontrol.

poljar (Damir Jelić) authored 12 years ago and Tanu Kaskinen committed 12 years ago

The cardwidget should cache all the relevant data for the ports.

This change introduces a new port class which holds the port info for
the card.

This makes sure we inhibit autosuspend only for network sources (which
was the main purpose of adding autosuspend, since constantly monitoring
those is network heavy).

The server now signals when a sink supports setting formats, so we don't
have to rely on the profile name.

The setting of the channel map triggers the display of the actual volume sliders
so it is essential that we do not set it when we don't want to.

 * Use ctrl+w or ctrl+q or esc to quit.
 * Uset ctrl+1-5 to change tabs.

As pavucontrol is often used for debugging PA, it should
be quite robust and not popup messages etc. under 'normal'
testing conditions. This adds quite a verbose message under
some specific conditions that do crop up from time to time.

Pass --disable-gtk3 to configure to build against gtk2

The number of volume steps doesn't really affect our scale, so there
is little value in setting it.

source-outputs: Fix a bug where the 'no streams' label is sometimes shown along with the actual widget.