Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • P plymouth
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • plymouth
  • plymouth
  • Merge requests
  • !131

Fix BGRT fallback rendering

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adrian Vovk requested to merge AdrianVovk/plymouth:fix-bgrt-fallback into master Mar 02, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Replaces !130 (closed)

Fixes #142 (closed)

I split up background_bgrt_image and background_bgrt_fallback_image so that the two images can be handled differently. view_set_bgrt_background does a lot of work to manipulate the image to deal with buggy firmwares, but in the fallback case we're just loading a regular image so none of that is needed. Moreover, the manipulations done to fix the real BGRT image end up breaking scaling when using a fallback image (see this comment). So, when view_set_bgrt_background fails to draw the BGRT image, I fall through to view_set_bgrt_fallback_background which draws the fallback image with the proper scale.

This code has been tested in GNOME Boxes (lodpi, with & without BGRT enabled) and on a MacBook (hidpi, without BGRT in firmware)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-bgrt-fallback