Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • P plymouth
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 85
    • Issues 85
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • plymouth
  • plymouth
  • Merge requests
  • !131

Merged
Created Mar 02, 2021 by Adrian Vovk@AdrianVovk

Fix BGRT fallback rendering

  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

Replaces !130 (closed)

Fixes #142 (closed)

I split up background_bgrt_image and background_bgrt_fallback_image so that the two images can be handled differently. view_set_bgrt_background does a lot of work to manipulate the image to deal with buggy firmwares, but in the fallback case we're just loading a regular image so none of that is needed. Moreover, the manipulations done to fix the real BGRT image end up breaking scaling when using a fallback image (see this comment). So, when view_set_bgrt_background fails to draw the BGRT image, I fall through to view_set_bgrt_fallback_background which draws the fallback image with the proper scale.

This code has been tested in GNOME Boxes (lodpi, with & without BGRT enabled) and on a MacBook (hidpi, without BGRT in firmware)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-bgrt-fallback