- Jun 02, 2021
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
On Wayland, if the wl_drm interface is not available, for example if the compositor is using the proprietary NVIDIA driver along with their egl-wayland library, the device_select layer will fail to initialize. However, the failure path will unconditionally call wl_drm_destroy even though info.wl_drm would be NULL in that case. This can cause a segfault in libwayland-client.so. To fix this, check if info.wl_drm is NULL before calling wl_drm_destroy. This way, initialization will fail gracefully even if that interface is not present. Signed-off-by:
Erik Kurzinger <ekurzinger@nvidia.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!10598> (cherry picked from commit f4eb13dc)
-
- May 31, 2021
-
-
DXVK 1.8.1 marks position as always invariant but the DX12 version of the game has the same issue and it's not yet fixed on the vkd3d-proton side. Fixes some Z-fighting on GFX10.3. Cc: 21.1 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!11029> (cherry picked from commit 816be7d4)
-
When drawing using util_translate_prim_restart_ib, zink explicitly ignores pipe_draw_start_count_bias::start, because util_translate_prim_restart_ib used to create a new index-buffer without padding at the start. This makes a lot of sense, because creating a padded index buffer is just wasteful. So let's walk back on the choice of starting to pad the output buffer. Fixes: 1272c2e0 ("util/prim_restart: fix util_translate_prim_restart_ib") Closes: mesa/mesa#4851 Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!11059> (cherry picked from commit 05bb4496)
-
It is valid to not have a sampler view declaration for the corresponding sampler in a TGSI shader, and hence we should not rely on the sampler view declaration to determine if we need to adjust the unnormalized coordinates for texture rectangle sampling. This patch is to prep for tgsi shaders that are translated from nir which in many cases do not issue sampler view declarations. Fixes: 584b1070 ("st/mesa: Drop the TGSI paths for drawpixels and use nir-to-tgsi") Reviewed-by:
Neha Bhende <bhenden@vmware.com> Part-of: <mesa/mesa!11011> (cherry picked from commit fda4eaf5)
-
Sometimes, TGSI shader doesn't have SVIEW declaration if it is not utilize in shader. In such cases, declare those resources with the help of information stored in shader key. Fixes: 584b1070 ("st/mesa: Drop the TGSI paths for drawpixels and use nir-to-tgsi") Tested with piglit, gleretrace Reviewed-by:
Charmaine Lee <charmainel@vmware.com> Part-of: <mesa/mesa!11011> (cherry picked from commit fd986490)
-
Fixes: 584b1070 ("st/mesa: Drop the TGSI paths for drawpixels and use nir-to-tgsi") Reviewed-by:
Charmaine Lee <charmainel@vmware.com> Part-of: <mesa/mesa!11011> (cherry picked from commit 4b958ac7)
-
Eric Engestrom authored
-
When we emit constants, we don't know what type they'll be used as, so we just emit them as uint, and then bitcast them to whatever we need. But this isn't a good idea for ConstOffset, which needs to actually be a const value, and not a const value bitcasted. So we sadly have to open-code the const emitting here to avoid the problem. Fixes: e963d35e ("zink: use ConstOffset for nir_tex_src_offset") Closes: mesa/mesa#4831 Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!11032> (cherry picked from commit 76138372)
-
Eric Engestrom authored
-
Fence destroy hw_res not dec reference.Lead leak. Call virgl_drm_resource_reference() to release hw_res instead of calling virgl_hw_res_destroy() directly. Fixes: c54fb6ef ("virgl: Don't destroy resource while it's in use.") Signed-off-by:
cheyang <cheyang@bytedance.com> Reviewed-by:
Chia-I Wu <olvaffe@gmail.com> Reviewed-by:
Lepton Wu <lepton@chromium.org> Part-of: <mesa/mesa!11008> (cherry picked from commit 4a3c715b)
-
Cc: mesa-stable Signed-off-by:
Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10984> (cherry picked from commit 6bb66b78)
-
this breaks texturing in non-fragment stages and is unnecessary due to using nir_lower_tex Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!11007> (cherry picked from commit a9d3b005)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Closes: mesa/mesa#4677 Cc: mesa-stable Part-of: <mesa/mesa!10980> (cherry picked from commit 4e4dd4f8)
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Cc: mesa-stable Part-of: <mesa/mesa!10980> (cherry picked from commit 665f11e8)
-
For fragment shaders that only contain a discard, the exec mask has to be zero'd and everything discarded. It seems unnecessary to emit an export here because if the FS has no exports, the compiler already emits a null export at the end. Fixes incorrect hair rendering in Detroit: Become Human. fossil-db (Sienna Cichlid): Totals from 3 (0.00% of 149839) affected shaders: CodeSize: 2896 -> 2872 (-0.83%) Instrs: 556 -> 553 (-0.54%) Latency: 29266 -> 29214 (-0.18%) InvThroughput: 3374 -> 3372 (-0.06%) Cc: 21.1 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!10955> (cherry picked from commit 729ebe4b)
-
Note that CCS isn't ambiguated during a HiZ ambiguate. Dumping the CCS surface after a HiZ ambiguate shows that the CCS is unchanged. Fixes: 98dc7f56 ("intel/isl: Add a separate ISL_AUX_USAGE_HIZ_CCS_WT") Reviewed-by:
Sagar Ghuge <sagar.ghuge@intel.com> Part-of: <mesa/mesa!9112> (cherry picked from commit 19a8bd4c)
-
Commit cd401104 added stalls before register writes that occur when drivers emit depth stencil packets. However, it only did so for non-BLORP draw calls. Since those packets are sometimes emitted during BLORP calls, add stalls there too. Closes: mesa/mesa#4574 Cc: mesa-stable Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!10939> (cherry picked from commit 34dbbfdd)
-
Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!10813> (cherry picked from commit 56a450e9)
-
Fixes: 8845a236 - amd: add NAVI10 PCI IDs Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!10813> (cherry picked from commit 64b75cc1)
-
Acked-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Cc: mesa-stable@lists.freedesktop.org Part-of: <mesa/mesa!10813> (cherry picked from commit 38d3c425)
-
We previously allocated only 16MB, but this isn't always enough. Now that we have growable (heap) on recent kernels, there's not much reason to try to shrink this allocation. Fixes OUT_OF_MEMORY fault on furmark trace. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!10938> (cherry picked from commit ac1ee2be)
-
Eric Engestrom authored
-
Signed-off-by:
Italo Nicola <italonicola@collabora.com> Fixes: ff3eada7 ("panfrost: Use the generic preload and FB helpers in the gallium driver") Part-of: <mesa/mesa!10962> (cherry picked from commit c746747c)
-
As noted in f5c29342 ("panfrost: Correct polygon size computations"), "We do have to be careful to add the header size to total comptued BO size." Fixes: ff3eada7 ("panfrost: Use the generic preload and FB helpers in the gallium driver") Closes: mesa/mesa#4660 Closes: mesa/mesa#4737 Part-of: <mesa/mesa!10943> (cherry picked from commit fe9d37b0)
-
Fallback to a slow clear, this could be improved by splitting the clear into two parts (one fast and one slow) but that's complicated. Cc: 21.1 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!10516> (cherry picked from commit e98c61e9)
-
need to dump the arg, not just the array Fixes: 8926c4a3 ("aux/trace: add a set_inlinable_constants hook") Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!10899> (cherry picked from commit dce827f6)
-
Check both source and destination offsets are aligned to 4. This patch fixes dEQP-GLES{2|3}.functional.buffer.write.random.* tests failures on guest side while trying to copy small (<16b) buffers via glBufferSubData() with offset which isn't aligned to 4. Fixes: 9b1b9714 ("iris: Use MI_COPY_MEM_MEM for tiny resource_copy_region calls.") Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Marcin Ślusarz <marcin.slusarz@intel.com> Part-of: <mesa/mesa!10910> (cherry picked from commit a04d0a30)
-
if this mask is 0, there is nothing to do here Fixes: e73bf3b8 ("gallium: add start_slot parameter to set_vertex_buffers") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!10929> (cherry picked from commit 43abed91)
-
This fixes a (rather false) error about accessing an array that it is uninitialized. Fixes: 7bc39c84 ("vc4: Add a dump-the-surface-contents routine.") Closes: mesa/mesa#4816 Cc: mesa-stable Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!10918> (cherry picked from commit 7e767ffe)
-
This patch will avoid reallocation,if surface is already protected. Fixing the comparision logic of boolean value(true \ flase) with PIPE_BIND_PROTECTED. Fixes: 81be8b3c ("va/picture: make sure destination buffer is protected if needed") Signed-off-by:
SureshGuttula <suresh.guttula@amd.corp-partner.google.com> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!10916> (cherry picked from commit 0236b8a5)
-
this was broken for the indirect case if the indirect draw count or firstIndex was nonzero and also would rewrite the index buffer onto the wrong offset of the dst buffer Fixes: 0c85d6c5 ("gallium/util: factor out primitive-restart rewriting logic") Fixes: 330d0607 ("gallium: remove pipe_index_buffer and set_index_buffer") Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!10909> (cherry picked from commit 1272c2e0)
-
According to isl_gfx7.c:264, the display engine does not support Y tiled buffers prior to Skylake. But we exposed I915_FORMAT_MOD_Y_TILED even when querying for a list of modifiers with PIPE_BIND_SCANOUT set, which we can't support. That led to crashes later when we tried to create such an image, and isl rightly denied it. Fixes crashes in wflinfo since c03e79d7, but the bug exists before that and it's probably worth a stable backport even without that patch. Closes: mesa/mesa#4815 Fixes: c03e79d7 ("loader/dri: hook up createImageWithModifiers2") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <mesa/mesa!10907> (cherry picked from commit dd508b2b)
-
According to isl_gfx7.c:264, the display engine does not support Y tiled buffers prior to Skylake. But we exposed I915_FORMAT_MOD_Y_TILED even when querying for a list of modifiers with __DRI_IMAGE_USE_SCANOUT set, which we can't support. That led to crashes later when we tried to create such an image, and isl rightly denied it. This duplicates a bit of code from ISL, but the isl_gfx6_filter_tiling function that we ought to use to filter things relies on surf_info, which we don't have at this stage. This is probably good enough. Fixes crashes in wflinfo since c03e79d7, but the bug exists before that and it's probably worth a stable backport even without that patch. Closes: mesa/mesa#4815 Fixes: c03e79d7 ("loader/dri: hook up createImageWithModifiers2") Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Part-of: <mesa/mesa!10907> (cherry picked from commit e9e953ff)
-
This hardware can't do any form of indirect addressing. The couple of new Crashes are the backend falling over when faced with loops/ifs. Fixes: 8a22064d ("i915g: Implement vertex textures.") Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!10874> (cherry picked from commit 8b0901c7)
-
We don't have a way to ask TGSI to not have .Absolute, so lower it in the backend. Cc: mesa-stable Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!10874> (cherry picked from commit 15f60858)
-
The 3D-pipeline fast clears try to emit FS constants before an FS is necessarily bound, causing segfaults in dEQP. Plus it flushes the whole batchbuffer so it'll probably be slower anyway. Fixes: 6358e637 ("i915g: implement hw clear") Reviewed-by:
Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!10874> (cherry picked from commit 8509aceb)
-
Reviewed-by:
Joshua Ashton <joshua@froggi.es> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Fixes: 6c83e3ea ("radv: Add format modifier format queries.") Part-of: <!10891> (cherry picked from commit 36d0ff46)
-
ds_swizzle_b32 requires a VGPR and DPP can't encode SGPR sources. Fixes dEQP-VK.graphicsfuzz.cov-derivative-uniform-vector-global-loop-count. Cc: 21.1 mesa-stable Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!10840> (cherry picked from commit fe2a5716)
-