Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
mesa
mesa
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,356
    • Issues 2,356
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 666
    • Merge Requests 666
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mesa
  • mesamesa
  • Merge Requests
  • !8588

Merged
Opened Jan 20, 2021 by Erik Faye-Lund @kusmaDeveloper

zink: fix vertex-stride wrangling

  • Overview 4
  • Commits 1
  • Pipelines 6
  • Changes 2

Because Gallium and Vulkan disagree on what kind of state strides is, we need to wrangle this state a bit, and up until now, we've been simply fixing this up while binding the vertex-buffers.

But this isn't robust, because the vertex element state might be bound after the vertex-buffer state was bound. We also need to take binding-map into account, which we're currently missing as well.

Instead, w need to deal with this at a place where we know what's being used for both of these. So let's do this during draw instead.

Ideally, we'd also do some dirty-tracking to know if this is needed or not, but I believe Mike has some patches in this areas lined up, so it might be easier to wait for those.

Fixes: 8d46e35d ("zink: introduce opengl over vulkan") Closes: #3661 (closed) Closes: #4125 (closed)

Edited Jan 21, 2021 by Erik Faye-Lund
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: mesa/mesa!8588
Source branch: zink-fix-vertex-stride