Skip to content

etnaviv: MSAA fixes

Lucas Stach requested to merge lynxeye/mesa:etnaviv-msaa-layout into main

The changes here are complementary to !19013 (merged). They should likely go in first, as the resource layout changes and RS alignment fixes prevent lots of GPU hangs or black renders when MSAA is enabled on render targets that aren't a natural multiple of the required tile or RS window sizes.

With those fixes I have not been able to break MSAA on GC2000 anymore.

GC3000 (aka SMALL_MSAA) is still not working in all configurations, it only works with 4x MSAA mode and supertiled rendertargets. May well be a limitation of the SMALL_MSAA mode, but we might as well still misprogram the GPU. Needs more investigation.

I haven't looked at GC7000 with BLT, yet. Likely BLT needs a similar fix as done to the RS in this patchset, to use the exact format when downsampling MSAA resources.

Edited by Lucas Stach

Merge request reports