Skip to content

radv: remove some error checking in submission

Yusuf Khan requested to merge YusufKhan-gamedev/mesa:radv_error_is_not_uwu into main

Some error checking can be removed for radv_queue_submit in radv_sparse_buffer_bind_memory and radv_sparse_image_opaque_bind_memory as they derive their return values from buffer_virtual_bind which is already called and checked by radv_sparse_image_bind_memory and checked their, so retain the error check for radv_sparse_image_bind_memory and remove it otherwise.

Also some error checking could be done after for loops in buffer submission.

This partially fixes #6288

Needlesss to say this introduces false positives

Signed-off-by Yusuf Khan

someone please test this

If someone has the Steam Deck(or any PC) and Forza Horizon 4 please check if this mitigates the stuttering. I have tested this in Crysis 2 Remastered on a Lenovo Ideapad 720s-13arr and I got a ~1% performance increase but as the issue mentions Forza Horizon 4 and I do not have it someone will have to test it.

Merge request reports