Commits on Source (100)
-
Dave Airlie authored
GL 4.6 changed error code for when the effective target of the texture is illegal. Since it's not an illegal enum they modified it to be an illegal operation. However the CTS test for this is missing support for two cases, I'm chasing that up, but I expect this will cause a CTS regression for anyone who runs this test. I'm leaning on the side of being compliant rather than passing the test until the test is fixed. Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Part-of: <!5896>
854dbea5 -
Dave Airlie authored
Part-of: <!5896>
5714cd34 -
Marek Olšák authored
arb_tessellation_shader-tes-gs-max-output -small -scan 1 50 -auto -fbo doesn't pass, but at least all shaders are compiled successfully. Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <!5700>
081691b5 -
Neil Roberts authored
When generating the VPM write instruction for geometry shader outputs, emit_store_output_gs ends up adding the base and offset arguments together with an ADD instruction. The addition was done at the VIR level after scheduling so it always ends up right next to the corresponding stvpm instruction. Most of the time the offset is constant but nothing does any constant folding at the VIR level. This patch makes it instead fold the addition into the offset at the NIR level in v3d_nir_lower_io so that the NIR-level constant folding can get rid of the addition most of the time. v2: Use nir_iadd_imm to simplify the code. (Eric Anholt) Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Part-of: <!5825>
97f8ec32 -
Samuel Pitoiset authored
To remove the mix of alloca() and malloc(). Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5899>
40bea60d -
Samuel Pitoiset authored
The legacy path requires one more ioctl to create the buffer list and this is more costly for the CPU. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5899>
485ea7d7 -
Erik Faye-Lund authored
We already have another way of initializing these, so it's just a matter of avoiding _MTX_INITIALIZER_NP here. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5902>
b8c01961 -
Yevhenii Kharchenko authored
Some of existing texture levels can be corruted, after calling 'glTexImage' with param 'level' higher than max expected value 'floor(log2(max(width, height, depth)))'. To fix we prevent overwriting image buffer pointer in 'st_texture_object', if it was already allocated for multiple mip-levels storage. Fixes piglit test: 'arb_copy_image add-illegal-levels' Signed-off-by:
Yevhenii Kharchenko <yevhenii.kharchenko@globallogic.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!5785>
a0f84396 -
Erik Faye-Lund authored
There's no good reason for using a mutex here, as we have a simpler primitive; atomic integers. So let's use that instead, to simplify things a bit. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <!5901>
3af0711c -
Indrajit Kumar Das authored
Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <!5836>
f611af35 -
Alyssa Rosenzweig authored
v2: Be more explicit about sampler types. Prefer the term "load" to "resolve" to match VK convention. Generate shaders for MRT 8x. Blit shader generation adds about 6ms to startup cost. We could cache thes. shaders to disk if we needed to (or indeed, ship binaries). v3: Fallback on u_blitter on Bifrost so Bifrost continues to work. KHR_partial_update support is mostly no-oped on Bifrost now, but that's okay for now - compositors are still functional. v4: Specialize on multisample state as well to enable reloads of MSAA textures. This requires 2x the shader variants, so I assume we're up to 12ms startup cost for generation. Annoying. Also fix interactions with depth- or stencil-only clears of combined depth-stencil surfaces. v5: Cache to the device (screen) instead of the context, reducing duplicated work in apps that create many contexts (e.g. Chromium) v6: Squash in KHR_partial_update cleanup to fix intermediate regressions on a few tests. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5824>
293f2518 -
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5805>
5a941f4d -
Rhys Perry authored
I don't think this is much of an optimization in the typical case, but for very complex shaders this should work much better. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5805>
47d7e1e6 -
Rhys Perry authored
Seems to be faster. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5805>
2c7554fe -
Rhys Perry authored
This won't add interferences between spill ids of different types and will exit early if there's already an interference. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5805>
b85ef043 -
Thong Thai authored
Signed-off-by:
Thong Thai <thong.thai@amd.com> Reviewed-by:
Leo Liu <leoliu@amd.com> Part-of: <!5848>
045711dc -
Dave Airlie authored
Currently the test crashes with LLVM errors Stored value type does not match pointer operand type! store <8 x i32> %s_dst, <8 x i8>* %261 Change the stored type for 8-bit stencil formats. Fixes: GTF-GL45.gtf44.GL31Tests.texture_stencil8.texture_stencil8_gl44 Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <!5926>
87e27543 -
Dave Airlie authored
pos offset only applies to the gl_FragPos input, when I refactored I messed that up, only use pos_offset for the position inputs and use 0.5 otherwise. This fixes: GTF-GL45.gtf30.GL3Tests.fragment_coord_conventions.fragment_coord_conventions_multisample Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Part-of: <!5926>
e16f59c3 -
Alyssa Rosenzweig authored
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
3d13870e -
Alyssa Rosenzweig authored
Based on the colour buffers in use, we need to select a tile size allowing either 128-bits of storage per pixel or 512-bits. Based on the size chosen, we scale the offsets into the tilebuffer. Likewise, we need to calculate offsets based on bpp (with special cases) rather than picking an average case. Fixes regressions that otherwise would be caused by the next commit. v2: Fix colour clears (Icecream95). Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
a0003c32 -
Alyssa Rosenzweig authored
Missed that this is needed, fixes fbo.completeness.* Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
721b5c6e -
Alyssa Rosenzweig authored
It should be sRGB transformed first, which the generic path handles but the RGBA8 special path does not. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
6ffebfbf -
Alyssa Rosenzweig authored
Requires the ability to texture the stencil-only portion, and then u_blitter kicks in for the rest. v2: Fix dEQP-GLES31.functional.stencil_texturing.* Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
cce3d925 -
Alyssa Rosenzweig authored
Instead of silently failing. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
77bb19ee -
Alyssa Rosenzweig authored
If rt_count = 0, this underflows to MAX_MRT. The hw doesn't seem to care but it's semantically incorrect and confuses pandecode. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
9addb821 -
Alyssa Rosenzweig authored
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
6c6a8b2f -
Alyssa Rosenzweig authored
Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
afa4b320 -
Alyssa Rosenzweig authored
We're overreporting on some chips and underreporting on others. Let's be more honest. This exposes OpenGL ES 3.0 on Mali T760 through T860. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
96fa8d70 -
Alyssa Rosenzweig authored
With the latest batch of fixes, Chromium works (including WebGL support, although performance is still WIP). Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5858>
19da8121 -
Alyssa Rosenzweig authored
This reverts commit 4fee7b30, which was intended to be a temporary workaround for a leak introduced in a65e29cc ("gallium: simplify throttle implementation"). However, that leak was then fixed in 023282a4 and we forgot to revert this hack. Closes: #2108 Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Cc: mesa-stable Part-of: <!5858>
40b99bb7 -
Connor Abbott authored
Found by guessing. Part-of: <!5936>
981608ad -
Connor Abbott authored
Part-of: <mesa/mesa!5936>
aeca92ed -
Connor Abbott authored
This passes the grand total of 3 CTS tests (2 actually enabled due to missing D32_SFLOAT_S8_UINT support) under dEQP-VK.pipeline.shader_stencil_export.* Part-of: <!5936>
b5a48a94 -
Samuel Pitoiset authored
It's invalid and the temporary syncobj was never actually destroyed. Cc: 20.1 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!5921>
8aa9d0ac -
Samuel Pitoiset authored
VK_ERROR_INVALID_EXTERNAL_HANDLE is not a valid Vulkan error code for these functions and it's likely that too many objects are created instead. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5921>
dd795ee1 -
Samuel Pitoiset authored
It can only be an OOM error. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5921>
3b7cd734 -
Samuel Pitoiset authored
This creates a syncobj and sets it as signaled with one ioctl instead of two. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5921>
56395a8b -
Samuel Pitoiset authored
To be consistent with semaphores and for clean up. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5921>
4e8d7ad8 -
Tomeu Vizoso authored
We have enough capacity now and Panfrost should be very near to GLES3 compliance. v2: Update fails list (Alyssa) Signed-off-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5932>
4dcbad47 -
Icecream95 authored
Opening the dump file in pandecode_jc instead of doing it in pandecode_next_frame avoids creating zero sized files when applications exit. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5931>
01d60d3d -
Rob Clark authored
I think this is the one user facing use of blacklist/whitelist. But we like all of our users, so lets be more inclusive. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <!5938>
81124d84 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
179e442f -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
43e2d808 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
b501ece6 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
7d5a13eb -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
1ba5075a -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
2d5f12ae -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
90000b02 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
c5fb1fbc -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
2e3eb0c9 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
bc38fe84 -
Eric Engestrom authored
Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
4dc322c4 -
Eric Engestrom authored
Suggested-by:
Frank Binns <frank.binns@imgtec.com> Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Frank Binns <frank.binns@imgtec.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Part-of: <!5861>
e0ef5a5c -
Alyssa Rosenzweig authored
It's right there in GLES. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5943>
91234584 -
Rhys Kidd authored
Present in both cl502d and cl902d. Based on envytools commit 0b9d3e717828a06be6937395464c34dfc870a6dc Signed-off-by:
Rhys Kidd <rhyskidd@gmail.com> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <!5922>
bc69e734 -
Rhys Kidd authored
Present in both cl502d and cl902d. Based on envytools commit 889f8fb4445863c19336c31dd13ecbdd3b19a196 Signed-off-by:
Rhys Kidd <rhyskidd@gmail.com> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Part-of: <!5922>
e7fd1ce9 -
Karol Herbst authored
Fixes: f611af35 ("st/mesa: use fragment shader to copy stencil buffer") Signed-off-by:
Karol Herbst <kherbst@redhat.com> Reviewed-by:
Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <!5940>
c36aac54 -
Erik Faye-Lund authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
6ffa0e92 -
Erik Faye-Lund authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
30f4ccff -
Elie Tournier authored
For virgl, we don't lower advanced equation to fbfetch So we need to pass the blend equation info in the TGSI to the host Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
b3a3f7cc -
Elie Tournier authored
In virgl, when fbfetch extention is not available but blend_equation_advanced is, we didn't call lower_blend_equation_advanced. So we need to pass the blend value to the host in order to recreate the shader correctly. Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
4f8fc0f0 -
Elie Tournier authored
This cap is used by virglrenderer but not by Mesa. Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
57174c91 -
Elie Tournier authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
377731ec -
Elie Tournier authored
With virgl, we want to expose KHR_blend_equation_advanced even if EXT_shader_framebuffer_fetch is not available. Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
d0df56cc -
Elie Tournier authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
0ee1a67f -
Elie Tournier authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
a026364b -
Elie Tournier authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
a0f42b89 -
Elie Tournier authored
Signed-off-by:
Elie Tournier <elie.tournier@collabora.com> Reviewed-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <!5516>
575ab303 -
Michel Dänzer authored
Follow-up to !5898 . Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Acked-by:
Daniel Stone <daniels@collabora.com> Part-of: <!5918>
3f865640 -
There are a lot of them and they are mostly uninteresting, so don't disassemble them or print shader-db results. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5948>
4a8ad1e0 -
Icecream95 authored
The bool will be used for deciding whether to do a per-sample load. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5930>
25747cea -
Icecream95 authored
EXT_shader_framebuffer_fetch requires the fetched value to be per-sample, so we need to load the sample id when in a fragment shader. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5930>
c20d166b -
Icecream95 authored
Fixes dEQP-GLES31.functional.blend_equation_advanced.msaa.* Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5930>
2a6db94b -
Icecream95 authored
This is needed for handling drivers that use an input for loading the face, for example Panfrost with Midgard GPUs. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Rob Clark <robdclark@chromium.org> Tested-by:
Urja Rannikko <urjaman@gmail.com> Part-of: <!5915>
314ba5e1 -
Icecream95 authored
Fixes the two-sided-lighting and vertex-program-two-side piglit tests on Panfrost. v2: Use an existing variable for gl_FrontFacing if present. Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Rob Clark <robdclark@chromium.org> Tested-by:
Urja Rannikko <urjaman@gmail.com> Part-of: <!5915>
4e986568 -
Icecream95 authored
OpenGL 3.3 is now reported again when PAN_MESA_DEBUG=gl3 is set. Fixes: 96fa8d70 ("panfrost: Report CAPs more honestly") Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5947>
01147481 -
Samuel Pitoiset authored
Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5876>
93047f68 -
Samuel Pitoiset authored
While we are at it, do not duplicate the error messages for the three different submission paths. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5876>
1829bdd0 -
Samuel Pitoiset authored
The driver shouldn't abort when a CS submission fails. Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <!5876>
2b796c76 -
Icecream95 authored
Fixes square circles in the KiCad 3D viewer. v2: Cleanup a bit, add a comment, and handle the fs->writes_stencil case to be pedantic (Alyssa). Reported-by:
Urja Rannikko <urjaman@gmail.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5946>
ca44c009 -
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!5773>
305cffa2 -
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!5773>
d14f4faa -
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!5773>
b36950ad -
Rhys Perry authored
Otherwise, we might have both VS and TCS code in the same block but float controls are set per-block. We also rely on VS code not dominating TCS code for the optimizer to work correctly. Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!5773>
23631ddd -
Rhys Perry authored
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!5773>
56d9bcdd -
Erik Faye-Lund authored
Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!5954>
12b324b3 -
Erik Faye-Lund authored
Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!5954>
35beb938 -
Erik Faye-Lund authored
Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!5954>
810bf7d3 -
Erik Faye-Lund authored
Reviewed-By:
Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <!5954>
086f7609 -
Emma Anholt authored
In one side of the ifdef it's only used in an assert. Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!5829>
afe07c7f -
Emma Anholt authored
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!5829>
d4e56930 -
Emma Anholt authored
And now that they're static tables, we don't need to ralloc a copy in non-shared memory. Saves ~210k in the built intel drivers. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1048434 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!5829>
d735f075 -
Icecream95 authored
The alignment can just be copied from the source intrinsic. Fixes the assertion nir_intrinsic_align_offset(instr) < nir_intrinsic_align_mul(instr) Reviewed-by:
Karol Herbst <kherbst@redhat.com> Reviewed-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5949>
2aa507f8 -
Tomeu Vizoso authored
I mistakenly removed what I thought were remnants of when Freedreno used LAVA for their DUTs. lava_arm.sh is used for baremetal, so re-add that code. Fixes: dcd171f5 ("gitlab-ci: More stable URL for kernel and ramdisk artifacts, for LAVA") Signed-off-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Reviewed-by:
Eric Anholt <eric@anholt.net> Part-of: <!5839>
cf55abe7 -
Emma Anholt authored
warning: converting a packed ‘instr_cf_t’ {aka ‘union <anonymous>’} pointer (alignment 1) to a ‘uint16_t’ {aka ‘short unsigned int’} pointer (alignment 2) may result in an unaligned pointer value [-Waddress-of-packed-member] We may know that we'll only ever have aligned instr_cf_ts, but gcc doesn't. Part-of: <!5955>
4080f8bf -
Rob Clark authored
I haven't noticed tftp boot issues in last few days, not sure if they where just a fluke on Mon or if it is somehow related to # of jobs we run (ie. having more of the c630 runners powered up and running more of the time). Let's turn them back on and see what happens. Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <!5952>
e5169b1c -
Alyssa Rosenzweig authored
I see no reason to hide this. The small hit in cycle count is offset in practice by the increase in thread count. So let's ship it and get some testing. If this regresses a workload: 1. Open an issue on the tracker and attach an apitrace. 2. In the meantime set PAN_MESA_DEBUG=nofp16 to override. Signed-off-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5960>
610af7e1 -
Emma Anholt authored
Normally, the linker will pull in any compilation unit (aka .c file) from a static lib (such as our shared util code) that is depended on by the code linking against it. Since that code is already compiled, the .text section is allowed to jump anywhere in .text, and the compiler can't garbage collect unused functions inside of a compile unit. Teasing callgraphs apart so that normal compilation-unit-level GCing can reduce driver size hurts the logical organization of the code and is difficult. As an example, once I'd split the format pack/unpack tables, I had to split out util_format_read/write() from util_format.c to avoid pulling in pack/unpack. But even then it didn't help, because it turns out turnip's pack calls pull in util_format_bptc.c for bptc packing, but that file also includes the unpack impls, and those internally call util_format_unpack, and thus we pulled in all of unpack. Splitting all of this to separate files makes code harder to find and maintain, and is a waste of dev time. By setting these compiler flags, the compiler puts each function and data symbol in a separate ELF section and the linker can then safely GC unused text and data sections from a compile unit that gets pulled in. There's a bit of a space cost due to having those separate sections, but it ends up being a huge win in disk space on my personal release driver builds: - i965_dri.so -213k - x86 gallium dri.so -430k - libvulkan_intel.so -272k - aarch64 gallium dri.so -330k - libvulkan_freedreno.so -783k No difference on iris drawoverhead -compat -test 1 on my skylake (n=60) Effect on debugoptimized build times (n=5) touch nir_lower_io.c build time (bfd) +15.999% +/- 3.80377% touch freedreno fd6_gmem.c build time (bfd) +13.5294% +/- 4.86363% touch nir_lower_io.c build time (lld) no change touch freedreno fd6_gmem.c build time (lld) +2.45375% +/- 2.2383% Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Acked-by:
Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!5739>
33f33bb7 -
Rhys Perry authored
fossil-db (Navi): Totals from 555 (0.41% of 135946) affected shaders: CodeSize: 1005716 -> 1003400 (-0.23%) Instrs: 195326 -> 194744 (-0.30%) Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5923>
bcf94bb9 -
Rhys Perry authored
Apparently this is potentially faster than v_nop: https://reviews.llvm.org/D83872 Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <!5923>
f302ef38
Showing
- .gitlab-ci.yml 9 additions, 13 deletions.gitlab-ci.yml
- .gitlab-ci/build-piglit.sh 1 addition, 1 deletion.gitlab-ci/build-piglit.sh
- .gitlab-ci/container/lava_arm.sh 59 additions, 11 deletions.gitlab-ci/container/lava_arm.sh
- .gitlab-ci/create-rootfs.sh 8 additions, 1 deletion.gitlab-ci/create-rootfs.sh
- .gitlab-ci/deqp-panfrost-t720-fails.txt 0 additions, 3 deletions.gitlab-ci/deqp-panfrost-t720-fails.txt
- .gitlab-ci/deqp-panfrost-t720-skips.txt 3 additions, 0 deletions.gitlab-ci/deqp-panfrost-t720-skips.txt
- .gitlab-ci/deqp-panfrost-t760-fails.txt 0 additions, 31 deletions.gitlab-ci/deqp-panfrost-t760-fails.txt
- .gitlab-ci/deqp-panfrost-t820-fails.txt 0 additions, 31 deletions.gitlab-ci/deqp-panfrost-t820-fails.txt
- .gitlab-ci/deqp-panfrost-t860-fails.txt 3 additions, 210 deletions.gitlab-ci/deqp-panfrost-t860-fails.txt
- .gitlab-ci/deqp-panfrost-t860-skips.txt 0 additions, 3 deletions.gitlab-ci/deqp-panfrost-t860-skips.txt
- .gitlab-ci/lava-gitlab-ci.yml 5 additions, 4 deletions.gitlab-ci/lava-gitlab-ci.yml
- .gitlab-ci/piglit/glslparser.txt 2 additions, 2 deletions.gitlab-ci/piglit/glslparser.txt
- .gitlab-ci/piglit/quick_gl.txt 2 additions, 2 deletions.gitlab-ci/piglit/quick_gl.txt
- .gitlab-ci/piglit/quick_shader.txt 3 additions, 3 deletions.gitlab-ci/piglit/quick_shader.txt
- docs/features.txt 1 addition, 1 deletiondocs/features.txt
- docs/gallium/screen.rst 1 addition, 0 deletionsdocs/gallium/screen.rst
- meson.build 13 additions, 0 deletionsmeson.build
- src/amd/compiler/aco_insert_NOPs.cpp 18 additions, 9 deletionssrc/amd/compiler/aco_insert_NOPs.cpp
- src/amd/compiler/aco_instruction_selection.cpp 11 additions, 1 deletionsrc/amd/compiler/aco_instruction_selection.cpp
- src/amd/compiler/aco_instruction_selection_setup.cpp 9 additions, 4 deletionssrc/amd/compiler/aco_instruction_selection_setup.cpp