-
- Downloads
drm/amdgpu/mst: Stop ignoring error codes and deadlocking
It appears that amdgpu makes the mistake of completely ignoring the return values from the DP MST helpers, and instead just returns a simple true/false. This is bad because error codes are important. In this case, it seems to have come back to bite us because as a result of simply returning false from compute_mst_dsc_configs_for_state(), amdgpu had no way of telling when a deadlock happened from these helpers. This results in the latest kernel splat with TB hotplugging on amdgpu. Signed-off-by:Lyude Paul <lyude@redhat.com> Fixes: 8c20a1ed ("drm/amd/display: MST DSC compute fair share") Cc: Harry Wentland <harry.wentland@amd.com> Cc: <stable@vger.kernel.org> # v5.6+
Showing
- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 10 additions, 8 deletionsdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c 57 additions, 50 deletionsdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h 6 additions, 6 deletionsdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h
Loading
-
mentioned in issue drm/amd#2171 (closed)
-
mentioned in issue drm/amd#2163
Please register or sign in to comment