Skip to content
Snippets Groups Projects
Forked from drm / msm
Source project has a limited visibility.
  • Joel Granados's avatar
    78eb4ea2
    sysctl: treewide: constify the ctl_table argument of proc_handlers · 78eb4ea2
    Joel Granados authored
    
    const qualify the struct ctl_table argument in the proc_handler function
    signatures. This is a prerequisite to moving the static ctl_table
    structs into .rodata data which will ensure that proc_handler function
    pointers cannot be modified.
    
    This patch has been generated by the following coccinelle script:
    
    ```
      virtual patch
    
      @r1@
      identifier ctl, write, buffer, lenp, ppos;
      identifier func !~ "appldata_(timer|interval)_handler|sched_(rt|rr)_handler|rds_tcp_skbuf_handler|proc_sctp_do_(hmac_alg|rto_min|rto_max|udp_port|alpha_beta|auth|probe_interval)";
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int write, void *buffer, size_t *lenp, loff_t *ppos);
    
      @r2@
      identifier func, ctl, write, buffer, lenp, ppos;
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int write, void *buffer, size_t *lenp, loff_t *ppos)
      { ... }
    
      @r3@
      identifier func;
      @@
    
      int func(
      - struct ctl_table *
      + const struct ctl_table *
        ,int , void *, size_t *, loff_t *);
    
      @r4@
      identifier func, ctl;
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int , void *, size_t *, loff_t *);
    
      @r5@
      identifier func, write, buffer, lenp, ppos;
      @@
    
      int func(
      - struct ctl_table *
      + const struct ctl_table *
        ,int write, void *buffer, size_t *lenp, loff_t *ppos);
    
    ```
    
    * Code formatting was adjusted in xfs_sysctl.c to comply with code
      conventions. The xfs_stats_clear_proc_handler,
      xfs_panic_mask_proc_handler and xfs_deprecated_dointvec_minmax where
      adjusted.
    
    * The ctl_table argument in proc_watchdog_common was const qualified.
      This is called from a proc_handler itself and is calling back into
      another proc_handler, making it necessary to change it as part of the
      proc_handler migration.
    
    Co-developed-by: default avatarThomas Weißschuh <linux@weissschuh.net>
    Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
    Co-developed-by: default avatarJoel Granados <j.granados@samsung.com>
    Signed-off-by: default avatarJoel Granados <j.granados@samsung.com>
    78eb4ea2
    History
    sysctl: treewide: constify the ctl_table argument of proc_handlers
    Joel Granados authored
    
    const qualify the struct ctl_table argument in the proc_handler function
    signatures. This is a prerequisite to moving the static ctl_table
    structs into .rodata data which will ensure that proc_handler function
    pointers cannot be modified.
    
    This patch has been generated by the following coccinelle script:
    
    ```
      virtual patch
    
      @r1@
      identifier ctl, write, buffer, lenp, ppos;
      identifier func !~ "appldata_(timer|interval)_handler|sched_(rt|rr)_handler|rds_tcp_skbuf_handler|proc_sctp_do_(hmac_alg|rto_min|rto_max|udp_port|alpha_beta|auth|probe_interval)";
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int write, void *buffer, size_t *lenp, loff_t *ppos);
    
      @r2@
      identifier func, ctl, write, buffer, lenp, ppos;
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int write, void *buffer, size_t *lenp, loff_t *ppos)
      { ... }
    
      @r3@
      identifier func;
      @@
    
      int func(
      - struct ctl_table *
      + const struct ctl_table *
        ,int , void *, size_t *, loff_t *);
    
      @r4@
      identifier func, ctl;
      @@
    
      int func(
      - struct ctl_table *ctl
      + const struct ctl_table *ctl
        ,int , void *, size_t *, loff_t *);
    
      @r5@
      identifier func, write, buffer, lenp, ppos;
      @@
    
      int func(
      - struct ctl_table *
      + const struct ctl_table *
        ,int write, void *buffer, size_t *lenp, loff_t *ppos);
    
    ```
    
    * Code formatting was adjusted in xfs_sysctl.c to comply with code
      conventions. The xfs_stats_clear_proc_handler,
      xfs_panic_mask_proc_handler and xfs_deprecated_dointvec_minmax where
      adjusted.
    
    * The ctl_table argument in proc_watchdog_common was const qualified.
      This is called from a proc_handler itself and is calling back into
      another proc_handler, making it necessary to change it as part of the
      proc_handler migration.
    
    Co-developed-by: default avatarThomas Weißschuh <linux@weissschuh.net>
    Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
    Co-developed-by: default avatarJoel Granados <j.granados@samsung.com>
    Signed-off-by: default avatarJoel Granados <j.granados@samsung.com>