Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libinput
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 161
    • Issues 161
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • libinput
  • libinput
  • Merge requests
  • !726

touchpad: revert the clickpad detection mechanism

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged José Expósito requested to merge JoseExposito/libinput:back-to-input-prop-buttonpad into main Nov 20, 2021
  • Overview 9
  • Commits 1
  • Pipelines 3
  • Changes 2

Use the previous heuristics to detect clickpads where a touchpad was handled as a clickpad when:

  • The property INPUT_PROP_BUTTONPAD is set
  • The property INPUT_PROP_BUTTONPAD is NOT set but the touchpad only has BTN_LEFT

Revert a37d6dcc:
"touchpad: if we have a right button, let's assume it's not a clickpad"
MR: !614 (merged)
BUG: #595 (closed)

In addition, revert the quirks that are no longer needed:

  • StarLabs:

    Revert 89cd0f99:
    "quirks: Add quirk for StarLabs clickpads with two phyisical buttons"
    MR: !701 (merged)

    And f2d110df:
    "quirks: Update dmi for StarBook Mk V"
    MR: !704 (merged)

  • Synaptics:

    Revert d1f274c7:
    "quirks: add a more generic match for the 5288 Synaptics clickpad"
    MR: !716 (merged)
    BUG: #674 (closed)
    BUG: #689 (closed)
    BUG: #629 (closed)

  • Framework:

    Revert eb2ed186:
    "quirks: add Framework Touchpad Quirk"
    MR: !665 (merged)
    BUG: #644 (closed)

  • Chuwi:

    Revert 8ee85374:
    "Update quirks/50-system-chuwi.quirks"
    MR: !662 (merged)

    Revert 1773973d:
    "quirks: Chuwi AeroBook Plus has a clickpad falsely claiming to have BTN_RIGHT"
    MR: !670 (merged)

  • GPD:

    Revert 74fac6d0:
    "quirks: add quirk for GPD Win Max"
    MR: !709 (merged)

  • Huawei:

    Revert 17783c24:
    "quirks: add a quirk for the Huawei Matebook 2020 touchpad"
    MR: !647 (merged)
    BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1972370

Fix #704 (closed)

Signed-off-by: José Expósito jose.exposito89@gmail.com

Edited Nov 21, 2021 by José Expósito
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: back-to-input-prop-buttonpad