Skip to content
Snippets Groups Projects
  1. Jun 19, 2019
  2. Jun 18, 2019
  3. Jan 22, 2019
    • Andrey Smirnov's avatar
      tools/firmware/ihex2fw: Replace explicit alignment with ALIGN · 925f8d4a
      Andrey Smirnov authored
      
      (X + 3) & ~3 is the same as ALIGN(X, 4), so replace all of the
      instances of the formwer in the code with the latter. While at it,
      introduce a helper variable 'record_size' to avoid duplicating length
      calculatin code. No functional change intended.
      
      Cc: Chris Healy <cphealy@gmail.com>
      Cc: Kyle McMartin <kyle@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: linux-kernel <linux-kernel@vger.kernel.org>
      Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      925f8d4a
    • Andrey Smirnov's avatar
      tools/firmware/ihex2fw: Simplify next record offset calculation · 2ef8179b
      Andrey Smirnov authored
      
      We can convert original expression for 'writelen" to use ALIGN as
      follows:
      
          (p->len + 9) & ~3 => (p->len + 6 + 3) & ~3 => ALIGN(p->len + 6, 4)
      
      Now, subsituting "p->len + 6" with "p->len + sizeof(p->addr) +
      sizeof(p->len)" we end up with the same expression as used by kernel
      couterpart in linux/ihex.h:
      
          ALIGN(p->len + sizeof(p->addr) + sizeof(p->len), 4)
      
      That is a full size of the record, aligned to 4 bytes. No functional
      change intended.
      
      Cc: Chris Healy <cphealy@gmail.com>
      Cc: Kyle McMartin <kyle@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: linux-kernel <linux-kernel@vger.kernel.org>
      Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
      2ef8179b
  4. Nov 11, 2018
Loading