Skip to content
Snippets Groups Projects
  1. Apr 19, 2022
  2. Jan 03, 2022
  3. Dec 31, 2021
  4. Dec 30, 2021
  5. Dec 27, 2021
  6. Dec 22, 2021
  7. Dec 21, 2021
  8. Dec 20, 2021
  9. Dec 16, 2021
  10. Dec 15, 2021
  11. Dec 14, 2021
  12. Dec 13, 2021
  13. Dec 10, 2021
  14. Dec 06, 2021
  15. Dec 03, 2021
    • Rob Herring's avatar
      dt-bindings: media: nxp,imx7-mipi-csi2: Drop bad if/then schema · b54472a0
      Rob Herring authored
      
      The if/then schema for 'data-lanes' doesn't work as 'compatible' is at a
      different level than 'data-lanes'. To make it work, the if/then schema
      would have to be moved to the top level and then whole hierarchy of
      nodes down to 'data-lanes' created. I don't think it is worth the
      complexity to do that, so let's just drop it.
      
      The error in this schema is masked by a fixup in the tools causing the
      'allOf' to get overwritten. Removing the fixup as part of moving to
      json-schema draft 2019-09 revealed the issue:
      
      Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.example.dt.yaml: mipi-csi@30750000: ports:port@0:endpoint:data-lanes:0: [1] is too short
      	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
      Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.example.dt.yaml: mipi-csi@32e30000: ports:port@0:endpoint:data-lanes:0: [1, 2, 3, 4] is too long
      	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
      
      The if condition was always true because 'compatible' did not exist in
      'endpoint' node and a non-existent property is true for json-schema.
      
      Fixes: 85b62ff2 ("media: dt-bindings: media: nxp,imx7-mipi-csi2: Add i.MX8MM support")
      Cc: Rui Miguel Silva <rmfrfs@gmail.com>
      Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
      Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: Sascha Hauer <s.hauer@pengutronix.de>
      Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
      Cc: Fabio Estevam <festevam@gmail.com>
      Cc: NXP Linux Team <linux-imx@nxp.com>
      Cc: linux-media@vger.kernel.org
      Cc: linux-arm-kernel@lists.infradead.org
      Signed-off-by: default avatarRob Herring <robh@kernel.org>
      Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Acked-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
      Link: https://lore.kernel.org/r/20211203164828.187642-1-robh@kernel.org
      b54472a0
  16. Dec 02, 2021
  17. Dec 01, 2021
  18. Nov 30, 2021
Loading