Skip to content
Snippets Groups Projects

livesync: Fix #452

Merged Jan Alexander Steffens requested to merge heftig/gst-plugins-rs:livesync-452 into main
  • livesync: Split fallback_duration into in_ and out_duration
    Make it independent of the latency; this was inconsistent anyway, where the default latency of zero got you a fallback duration of 100 ms and something else got you half the latency.

    Maintain a separate duration for the in and the out side so we change the duration of repeat buffers after a caps change, not just before.

  • livesync: Keep existing buffer duration in some cases
    Resize a repeat buffer only if caps gave us a duration to use, or we consider its current duration unreasonable.

    In particular, for audio streams we should prefer reusing the buffer size upstream gave us, as we did before 6633cc40.

  • livesync: Remove the stop from outgoing segments
    Our buffer duplication can extend a segment indefinitely.

    Fixes: #452 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastian Dröge mentioned in merge request !1371 (closed)

    mentioned in merge request !1371 (closed)

  • Sebastian Dröge
  • Sebastian Dröge approved this merge request

    approved this merge request

  • Looks good to me otherwise. Please assign marge once you're happy with the results :)

  • added 2 commits

    • a701d55c - livesync: Keep existing buffer duration in some cases
    • 9a9d3dcb - livesync: Remove the stop from outgoing segments

    Compare with previous version

  • added 2 commits

    • 0a27009d - livesync: Keep existing buffer duration in some cases
    • c705cc44 - livesync: Remove the stop from outgoing segments

    Compare with previous version

  • mentioned in issue #452 (closed)

  • Guillaume Desmottes resolved all threads

    resolved all threads

  • added 3 commits

    • 59beade0 - livesync: Split fallback_duration into in_ and out_duration
    • f1ba498b - livesync: Keep existing buffer duration in some cases
    • e3e58ac0 - livesync: Remove the stop from outgoing segments

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading