Part-of: <gstreamer/gst-plugins-rs!1622>

cea608-types requires that now because it updated the env_logger
dependency. As a result, we can also update it here now.

Part-of: <gstreamer/gst-plugins-rs!1622>

Part-of: <!1622>

This reverts commit b4b56eb2.
The tests are still failing.

Part-of: <!1624>

Part-of: <!1624>

The "first packet of a coded video sequence" means that this should be
the first packet of a keyframe that comes together with a sequence
header, not the first packet of a new frame.

Fixes #558

Part-of: <!1624>

The reader is already after the header at this point so only the OBU
content has to be skipped.

Part-of: <!1624>

Part-of: <!1624>

These seem to have stopped working due to bad/rotated creds. Should work
fine now.

Part-of: <!1623>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1612>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1612>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Otherwise they would pile up until a discontinuity or until we can
actually output something.

Part-of: <!1612>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

They're not recommended by the spec to include in the RTP packets but it
is valid to include them. Pion is including them.

When parsing the size fields also make sure to only take that much of a
payload unit and to skip any trailing data (which should not exist in
the first place).

Pion is also currently storing multiple OBUs in a single payload unit,
which is not allowed by the spec but can be easily handled with this
code now.

Fixes #560

Part-of: <!1612>

Part-of: <gstreamer/gst-plugins-rs!1620>

Part-of: <!1581>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Currently we incorrectly require gtk4 to build the fallbackswitch, livesync,
togglerecord plugins when the examples option is allowed.

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

This broke in 8b5a3981.

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

dmabuf feature needs the wayland feature too.

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

We were silently skipping plugins that didn't find a required feature,
even if the plugin option was enabled.

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1604>

Nirbheek Chauhan authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Minimal systems like docker containers may not have GL

Part-of: <!1604>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.

To solve this remember if cancellation should happen and reset this
later.

Part-of: <!1602>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.

To solve this remember if unlock() was called and reset this in
unlock_stop().

Also implement actual unlocking in s3hlssink.

Part-of: <!1602>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.

To solve this remember if unlock() was called and reset this in
unlock_stop().

Also actually implement unlock() / unlock_stop() for the sink, and don't
cancel in stop() as unlock() / unlock_stop() would've been called before
that already.

Part-of: <!1602>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

It would be possible that there is no cancellable yet when unlock() is
called, then the setup task is started and it would simply run and being
waited on instead of not being run at all.

To solve this, remember if unlock() was called and reset this in
unlock_stop().

Also make sure to not keep the abort handle locked while waiting,
otherwise cancellation would never actually work.

Part-of: <!1602>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

It would be possible that there is no cancellable yet when unlock() is
called, then a new future is executed and it wouldn't have any
information that it is not supposed to run at all.

To solve this remember if unlock() was called and reset this in
unlock_stop().

Part-of: <!1602>

Part-of: <!1610>

Part-of: <!1610>

Jordan Petridіs authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1608>

Mathieu Duponchelle authored 9 months ago and GStreamer Marge Bot committed 9 months ago

When the pad isn't parented yet we should still record user choices,
either in our settings or in our state.

Part-of: <!1593>

Mathieu Duponchelle authored 10 months ago and GStreamer Marge Bot committed 9 months ago

By making sure to expose uniquely named pads on the inner transcription
bins.

Fixes: #552
Part-of: <!1593>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

The library name and environment variable name have changed but the ABI
is completely compatible.

Part-of: <!1607>

Matthew Waters authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Produces backtraces which would allow some initial debugging on hard to
find issues.

Part-of: <gstreamer/gst-plugins-rs!1606>

Angelo Verlain Shema authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1600>

Matthew Waters authored 9 months ago and GStreamer Marge Bot committed 9 months ago

If jitter is really bad, then this calculation may overflow.  Protect
against that.

Part-of: <!1605>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1603>

Sebastian Dröge authored 9 months ago and GStreamer Marge Bot committed 9 months ago

Part-of: <!1603>

Part-of: <!1601>