rtspsrc: Fix segfault with illegal free (!669) · Merge requests · GStreamer / gst-plugins-good · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.

Merged Ognyan Tonchev requested to merge redstar/gst-plugins-good:segfault_fix into master 4 years ago

All threads resolved!

set_get_param_q is not a pointer so it is illegal to call g_queue_free_full(). It is enough to clear the queue with g_queue_clear_full() to free all the allocated data.

Activity

Nicolas Dufresne @ndufresne started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Nicolas Dufresne
Last reply by Nicolas Dufresne 4 years ago

Ognyan Tonchev added 1 commit 4 years ago

added 1 commit

2e125877 - rtspsrc: Fix segfault with illegal free

Compare with previous version

Ognyan Tonchev resolved all threads 4 years ago

resolved all threads

Ognyan Tonchev resolved all threads 4 years ago

resolved all threads

Nicolas Dufresne @ndufresne started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Ognyan Tonchev

Ognyan Tonchev added 1 commit 4 years ago

added 1 commit

22eb4f0b - rtspsrc: Fix segfault with illegal free

Compare with previous version

Tim-Philipp Müller changed milestone to 4 years ago

changed milestone to %1.17.90

Nicolas Dufresne assigned to @gstreamer-merge-bot 4 years ago

assigned to @gstreamer-merge-bot

Nicolas Dufresne @ndufresne · 4 years ago

Maintainer

Note, CI failure is expected, I added a new pixel formats, I'll just use the result to make yet another MR ;-P

Edited 4 years ago by Nicolas Dufresne

Ognyan Tonchev mentioned in commit 4 years ago

mentioned in commit redstar/gst-plugins-good@adb044c9

GStreamer Marge Bot added 5 commits 4 years ago

added 5 commits

22eb4f0b...b471f75e - 4 commits from branch gstreamer:master
adb044c9 - rtspsrc: Fix segfault with illegal free

Compare with previous version

Nicolas Dufresne resolved all threads 4 years ago

resolved all threads

GStreamer Marge Bot merged 4 years ago

merged

Nicolas Dufresne @ndufresne · 4 years ago

Maintainer

Ok, well, good thing, @tpm must have fixed the doc already ;-P

Nicolas Dufresne @ndufresne · 4 years ago

Maintainer

Thanks for this fix!

Ognyan Tonchev mentioned in commit 4 years ago

mentioned in commit StefanBruens/gst-plugins-good@8f124f7f

Please register or sign in to reply