Skip to content
Snippets Groups Projects
  1. Jun 12, 2024
  2. Jun 04, 2024
    • Frediano Ziglio's avatar
      Send real time to client · 7e56fc9f
      Frediano Ziglio authored and Frediano Ziglio's avatar Frediano Ziglio committed
      
      Do not offset the time attempting to fix client latency.
      Client should handle it by itself.
      
      This remove entirely the delay introduced by the server.
      This avoids surely possible time drifts in the client.
      The server just sends it's concept of time without trying to force any
      delay. Only one end should handle this delay in an attempt to
      synchronize audio and video instead that doing it in both ends.
      
      Signed-off-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      7e56fc9f
  3. May 28, 2024
  4. May 27, 2024
    • Frediano Ziglio's avatar
      tests: Remove warning compiling · b92149f2
      Frediano Ziglio authored
      
      Remove:
      
          test-display-streaming.c: In function 'get_commands':
          test-display-streaming.c:218:42: error: 'calloc' sizes specified with 'sizeof' in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
            218 |     *commands = (Command*) calloc(sizeof(Command), *num_commands);
                |                                          ^~~~~~~
          test-display-streaming.c:218:42: note: earlier argument should specify number of elements, later size of each element
      
      Signed-off-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      b92149f2
  5. May 26, 2024
  6. Nov 22, 2023
    • Frediano Ziglio's avatar
      test-listen: Use OpenSSL BIO instead of GIO library · fe1c25f5
      Frediano Ziglio authored and Frediano Ziglio's avatar Frediano Ziglio committed
      
      test-listen using GIO had issues running under CI for a while.
      GIO is reading some desktop configuration so it's not very CI
      friendly.
      So instead of using GIO use OpenSSL BIO. The code does not
      get much bigger or complicated.
      We are already using OpenSSL so we are not adding dependencies.
      
      This fixes CI for Fedora 39 (just released and available on docker).
      
      This allowed to remove an old workaround for GIO in .gitlab-ci.yml
      (cfr commit 89edf808
      "ci: Workaround an issue with GLib on Fedora 30")
      
      Signed-off-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      fe1c25f5
  7. Nov 15, 2023
    • Frediano Ziglio's avatar
      red-stream: Fix typo in comment · 7cfebdf6
      Frediano Ziglio authored
      
      renogotiation -> renegotiation
      
      Signed-off-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      7cfebdf6
    • Vivek Kasireddy's avatar
      gstreamer-encoder: Use an env var to override converter format · 3208be45
      Vivek Kasireddy authored and Frediano Ziglio's avatar Frediano Ziglio committed
      
      If we use the x264enc encoder to encode a stream, then videoconvert
      would convert the BGRx data into Y444, which is the preferred format
      for x264enc. However, some decoders particularly the ones that are
      h/w based cannot work with Y444 if it was the format used by the
      encoder. Therefore, to address these situations, we need a way to
      override the format used during the encoding stage which can be
      accomplished by using the environment variable introduced in this
      patch: SPICE_CONVERTER_PREFERRED_FORMAT.
      
      For example, using NV12 as the output format for the videoconvert
      element would allow us to pair a s/w based encoder (such as x264enc)
      with a h/w based decoder (such as msdkh264dec) for decoding the
      stream as most h/w based decoders only work with NV12 format given
      its popularity.
      
      Note that choosing an encoder format such as NV12 over Y444 would
      probably result in decreased video quality although it would be
      compatible with more decoders. Ideally, the client and server need
      to negotiate a suitable format dynamically but the current
      capabilities do not allow for such exchange.
      
      Cc: Frediano Ziglio <freddy77@gmail.com>
      Cc: Dongwon Kim <dongwon.kim@intel.com>
      Based-on-patch-by: default avatarHazwan Arif Mazlan <hazwan.arif.mazlan@intel.com>
      Signed-off-by: default avatarJin Chung Teng <jin.chung.teng@intel.com>
      Signed-off-by: default avatarVivek Kasireddy <vivek.kasireddy@intel.com>
      Acked-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      3208be45
  8. Sep 17, 2023
  9. May 30, 2023
  10. May 26, 2023
    • orbea's avatar
      server: add SSL_OP_NO_RENEGOTIATION fallback path · 5e580eef
      orbea authored and Frediano Ziglio's avatar Frediano Ziglio committed
      
      With LibreSSL SSL_OP_NO_CLIENT_RENEGOTIATION is opaque which is not
      compatible with the OpenSSL 1.0.2 and earlier code path in
      red-stream.cpp while SSL_OP_NO_RENEGOTIATION is not yet defined for the
      newer OpenSSL code path in reds.cpp.
      
      So with OpenSSL 1.1.0 and later if SSL_OP_NO_RENEGOTIATION is undefined
      and SSL_OP_NO_CLIENT_RENEGOTIATION is defined then define the former as
      the latter. This will allow the build to succeed with LibreSSL 3.7.2 and
      in the future when newer LibreSSL versions add SSL_OP_NO_RENEGOTIATION
      that code path will then be used automatically.
      
      Signed-off-by: default avatarorbea <orbea@riseup.net>
      Acked-by: default avatarFrediano Ziglio <freddy77@gmail.com>
      5e580eef
  11. May 11, 2023
  12. May 10, 2023
  13. Oct 22, 2022
  14. Sep 13, 2022
  15. Aug 03, 2022
Loading