Skip to content
Snippets Groups Projects
Commit 7c5f3d5e authored by osy's avatar osy Committed by Frediano Ziglio
Browse files

red-qxl: remove cookie assertion on scanout


The original check ensures we do not have an outstanding GL_DRAW. However,
in QEMU, there is no guarantee that a scanout cannot happen while the async
GL_DRAW has not returned a result yet. This introduces a race where if a
scanout is called while there is an outstanding GL_DRAW, QEMU will crash.

Signed-off-by: default avatarosy <osy@turing.llc>
Acked-by: default avatarFrediano Ziglio <freddy77@gmail.com>
parent fe1c25f5
No related branches found
No related tags found
No related merge requests found
...@@ -432,7 +432,6 @@ void spice_qxl_gl_scanout(QXLInstance *qxl, ...@@ -432,7 +432,6 @@ void spice_qxl_gl_scanout(QXLInstance *qxl,
spice_return_if_fail(qxl != nullptr); spice_return_if_fail(qxl != nullptr);
QXLState *qxl_state = qxl->st; QXLState *qxl_state = qxl->st;
spice_return_if_fail(qxl_state->gl_draw_cookie == GL_DRAW_COOKIE_INVALID);
pthread_mutex_lock(&qxl_state->scanout_mutex); pthread_mutex_lock(&qxl_state->scanout_mutex);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment