Skip to content
Snippets Groups Projects
New look: Off

[drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22)

    • Closed Issue created by Leonard Lausen @leezu

    Hi @jesszhan @abhinavk,

    following up on #25 (comment 2156044), I'm opening a new bug to track remaining / new issues. On Linux 6.9.2, suspending and resuming a lazor sc7180 while external display is connected over USB-C DP yields [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22) (similar to the -107 error discussed at #25 (closed)). The system recovers relatively quickly from the error and the external display turns up normally (the issue is mainly perceptible by looking at the kernel logs or by noticing the slight delay in recovery).

    dmesg snippet:

    % grep drm dmesg-6.9.2
[    0.342052] [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0
[    3.914356] aux_bridge.aux_bridge aux_bridge.aux_bridge.0: error -ENODEV: failed to acquire drm_bridge
[    4.248733] [drm:dpu_kms_hw_init:1053] dpu hardware revision:0x60020000
[    4.257815] [drm] Initialized msm 1.12.0 20130625 for ae01000.display-controller on minor 1
[    4.267800] msm_dpu ae01000.display-controller: [drm:adreno_request_fw] loaded qcom/a630_sqe.fw from new location
[    4.278415] msm_dpu ae01000.display-controller: [drm:adreno_request_fw] loaded qcom/a630_gmu.bin from new location
[    4.468890] msm_dpu ae01000.display-controller: [drm] fb0: msmdrmfb frame buffer device
[   73.514009] systemd[1]: Starting modprobe@drm.service - Load Kernel Module drm...
[   73.921409] systemd[1]: modprobe@drm.service: Deactivated successfully.
[   73.937414] systemd[1]: Finished modprobe@drm.service - Load Kernel Module drm.
[   79.697997] [drm:dp_aux_isr] *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy
[   90.966379] [drm:_dpu_rm_check_lm_and_get_connected_blks] [dpu error]failed to get dspp on lm 0
[   90.975354] [drm:_dpu_rm_make_reservation] [dpu error]unable to find appropriate mixers
[   90.983592] [drm:dpu_rm_reserve] [dpu error]failed to reserve hw resources: -119
[ 1185.831984] [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22)
[ 1190.140545] [drm:dp_aux_isr] *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy
    [ 1185.831970] [dpu error]connector not connected 3                                                                                                             
[ 1185.831984] [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22)                                                                               
[ 1186.025863] OOM killer enabled.                                              
[ 1186.029095] Restarting tasks ... done.                                       
[ 1186.042834] random: crng reseeded on system resumption                                                                                                       
[ 1186.048738] PM: suspend exit                                                                                                                                 
[ 1187.633591] ath10k_snoc 18800000.wifi: chan info: invalid frequency 0 (idx 41 out of bounds)                                                                 
[ 1188.194232] systemd-journald[682]: Under memory pressure, flushing caches.                                                                                   
[ 1190.140545] [drm:dp_aux_isr] *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy

    Full dmesg log attached: dmesg-6.9.2

    Edited

    Designs ...

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Leonard Lausen mentioned in issue #25 (closed)

      mentioned in issue #25 (closed)

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @abhinavk, you had mentioned "Regarding, "ERROR Unexpected DP AUX IRQ 0x01000000 when not busy", this shall be fixed with https://patchwork.freedesktop.org/patch/551847/, which has been merged to msm-fixes 0c1a2e69." at #25 (comment 2156044)

      It seems that didn't work or regressed, as *ERROR* Unexpected DP AUX IRQ 0x01000000 when not busy persists on 6.9.2.

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @abhinavk, since a few stable releases, I notice sc7180 lazor randomly hard resets (ie. reboots suddenly). I suspect it's related to drm/msm, as it only happens with graphical user interface enabled. I need to try running a few older kernel versions for a longer period of time to establish which kernel first introduced the issue. If any of the other drm errors mentioned in the snippet above look related to you, please let me know.

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      cc @jesszhan @abhinavk regarding this regression. gitlab.freedesktop.org was unavailable for the past week (?) and I'm thus not sure the notification was delivered when opening the issue

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @lumag I did a brief bisect and find 71174f36 of your series https://patchwork.freedesktop.org/patch/577524/ https://lore.kernel.org/r/20240208-fd_remove_phys_ops_atomic_mode_set-v4-4-caf5dcd125c0@linaro.org is the first to trigger [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22)

    • Dmitry Baryshkov
      Dmitry Baryshkov @lumag ·
      Developer

      @leezu this looks pretty strange as it touches only the WB path.

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @lumag there could be a confounder, in that starting 41c177cf (which includes merge of 6.8.0-rc3), suspend is not working as expected on the msm-next branch. Specifically, the EC detects a sleep transition timeout and "wakes" the device back up/brings screens back up after a few seconds. But I validated that 41c177cf does not exhibit the error, that d13f638c doesn't either, but then starting 71174f36 [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22) is printed. Please let me know if you have suggestions how to better narrow down the issue.

    • Dmitry Baryshkov
      Dmitry Baryshkov @lumag ·
      Developer

      @leezu could you please set drm.debug=0x16 and capture the log during suspend? Also could you please post /sys/kernel/debug/dri/0/state before suspending?

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @lumag please see attached the drm.debug=0x16 log with

      git checkout 71174f362d6750c789a3137cb7ea6d695dc5b659
git merge v6.8-rc4
git cherry-pick 0d7dfc79fb9b4b81f642f84796111f2bae8427e2

      drm_debug-err-22.txt

      I also validated that by merging v6.8-rc4 the "EC detects a sleep transition timeout" issue mentioned a potential confounder above is resolved. Ie. suspend works correctly. Even with merging v6.8-rc4, no [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22) on d13f638c but it is printed on 71174f36.

      /sys/kernel/debug/dri/0/state does not exist on my system. Do I need a kernel configuration to make it available?

      Edited by Leonard Lausen
    • Abhinav Kumar
      Abhinav Kumar @abhinavk ·
      Developer

      @leezu , sorry for the late response. I was indeed not getting some of the messages from this bug and I was OOO last week. I will go through the logs and update.

      Thanks

      Abhinav

    • Dmitry Baryshkov
      Dmitry Baryshkov @lumag ·
      Developer

      @leezu yes, you need to enable debugfs and to mount it to /sys/kernel/debug for that file to be available

    • Dmitry Baryshkov
      Dmitry Baryshkov @lumag ·
      Developer

      @leezu could you please check your issue with these two patches applied? If they don't help, I'd kindly ask for a new debug log (some of the DPU messages were being directed to other facility, the second patch fixes that) and a state from debugfs.

      0001-drm-msm-dpu1-don-t-choke-on-disabling-the-writeback-.patch

      0002-drm-msm-dpu-don-t-play-tricks-with-debug-macros.patch

    • Leonard Lausen changed the description

      changed the description

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @lumag thank you. 0001-drm-msm-dpu1-don-t-choke-on-disabling-the-writeback-.patch works and avoids [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-22). drm.debug=0x16 log: drm_debug-err-22-fixed.txt But is it the right fix? As in, are there valid situations where state->crtc will be null but this function is called? Or do any such situations indicate a bug, where crtc state is not properly preserved? For example, should this case only apply if the system was suspended without external display connected, and then resumed with the display connected?

      A few more observations:

      1. CRTC state isn't being restored correctly after resume (and this was true for at least kernel 6.8 as well). After resume, Color Transform Matrix (CTM) property appears lost. If internal panel/screen used CTM for Night Light, it no longer is active after resume. Toggling Night Light on and off after resume, leads to a number of the following errors:
      [drm:_dpu_rm_check_lm_and_get_connected_blks] [dpu error]failed to get dspp on lm 0
[drm:_dpu_rm_make_reservation] [dpu error]unable to find appropriate mixers
[drm:dpu_rm_reserve] [dpu error]failed to reserve hw resources: -119

      dmesg-6.9.8+drm-msm-dpu1-don-t-choke-on-disabling-the-writeback_ctm-resume-issues.txt

      1. If device is suspended and no external display connected, then pressing any key on the keyboard will wake up the device AND that key will passed along as input to the screen-lock (ie. as the first character for entering users password). If external display is connected, then pressing any key will will wake up the device, but the key will not be passed on to the screen-lock. (In principle, it's possible this is an issue with the screen-lock and not the kernel)

      @leezu yes, you need to enable debugfs and to mount it to /sys/kernel/debug for that file to be available

      Can you share more details? I do see clients, gem_names and name at /sys/kernel/debug/dri/0/. Just not state

      Edited by Leonard Lausen
    • Dmitry Baryshkov
      Dmitry Baryshkov @lumag ·
      Developer

      For 1, please start a separate issue. Please don't reuse existing tickets for unrelated problems. Please use linux-next + two patches I have posted earlier to capture the log.

      For 2, this doesn't look like a kernel issue unless proven otherwise. I'd guess it might be related to how your display manager handles seats and/or input devices.

      Regarding debugfs/dri/0/state. What is the contents of /sys/kernel/debug/dri/0/name? Do you have any other dirs under /sys/kernel/debug/dri? The msm driver is an atomic KMS driver so it should create dri/N/state, dri/N/framebuffer, dri/N/internal_clients and several other files.

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      For 1, please start a separate issue. Please don't reuse existing tickets for unrelated problems. Please use linux-next + two patches I have posted earlier to capture the log.

      After additional testing, it seems it is not an unrelated issue but triggered by your patch. The issue does not occur on Linux 6.9.6, but does occur on 6.9.8+dpu1-don-t-choke-on-disabling-the-writeback_ctm-resume patch. I think for my "and this was true for at least kernel 6.8 as well" I was referring to the kernel built from 71174f36 with 6.8.0-rc4 merged and your patch applied.

      Let me build linux-next with your patches as well and attach the debug logs.

      Regarding debugfs/dri/0/state. What is the contents of /sys/kernel/debug/dri/0/name? Do you have any other dirs under /sys/kernel/debug/dri? The msm driver is an atomic KMS driver so it should create dri/N/state, dri/N/framebuffer, dri/N/internal_clients and several other files.

      cat /sys/kernel/debug/dri/0/name 
vgem dev=vgem unique=vgem

      /sys/kernel/debug/dri/0/ or ae01000.display-controller contains the state information

      state on 6.9.6 prior to suspend: 
      plane[42]: plane-0
        crtc=crtc-0
        fb=70
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=1920x1080
                layers:
                        size[0]=1920x1080
                        pitch[0]=7680
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=001027f3
                                size=10485760
                                imported=no
        crtc-pos=1920x1080+0+0
        src-pos=1920.000000x1080.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_0
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=1920x1080+0+0
        dst[0]=1920x1080+0+0
plane[48]: plane-1
        crtc=crtc-1
        fb=76
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=2560x1440
                layers:
                        size[0]=2560x1440
                        pitch[0]=10240
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=00103bf3
                                size=16777216
                                imported=no
        crtc-pos=2560x1440+0+0
        src-pos=2560.000000x1440.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_8
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=2560x1440+0+0
        dst[0]=2560x1440+0+0
plane[54]: plane-2
        crtc=(null)
        fb=0
        crtc-pos=512x512+0+0
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=1
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=2
        sspp[0]=sspp_9
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=22x378+0+0
        dst[0]=22x378+1898+702
plane[60]: plane-3
        crtc=(null)
        fb=0
        crtc-pos=512x512+1742+1157
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=1
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=2
        sspp[0]=sspp_10
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=512x283+0+0
        dst[0]=512x283+1742+1157
crtc[66]: crtc-0
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=1
        connector_mask=1
        encoder_mask=1
        mode: "1920x1080": 60 147840 1920 1968 2000 2200 1080 1083 1089 1120 0x48 0x9
        lm[0]=0
        ctl[0]=0
        dspp[0]=0
crtc[67]: crtc-1
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=2
        connector_mask=2
        encoder_mask=2
        mode: "2560x1440": 60 241500 2560 2608 2640 2720 1440 1443 1448 1481 0x48 0x9
        lm[0]=1
        ctl[0]=1
connector[32]: eDP-1
        crtc=crtc-0
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[34]: DP-1
        crtc=crtc-1
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[41]: Writeback-1
        crtc=(null)
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
      state on 6.9.6 prior to following resume 
      plane[42]: plane-0
        crtc=crtc-0
        fb=78
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=1920x1080
                layers:
                        size[0]=1920x1080
                        pitch[0]=7680
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=0010a491
                                size=10485760
                                imported=no
        crtc-pos=1920x1080+0+0
        src-pos=1920.000000x1080.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_0
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=1920x1080+0+0
        dst[0]=1920x1080+0+0
plane[48]: plane-1
        crtc=crtc-1
        fb=70
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=2560x1440
                layers:
                        size[0]=2560x1440
                        pitch[0]=10240
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=00103bf3
                                size=16777216
                                imported=no
        crtc-pos=2560x1440+0+0
        src-pos=2560.000000x1440.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_8
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=2560x1440+0+0
        dst[0]=2560x1440+0+0
plane[54]: plane-2
        crtc=(null)
        fb=0
        crtc-pos=512x512+0+0
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=0
        sspp[0]=sspp_9
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=0x0+0+0
        dst[0]=0x0+0+0
plane[60]: plane-3
        crtc=(null)
        fb=0
        crtc-pos=512x512+1883+359
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=1
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=2
        sspp[0]=sspp_10
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=512x512+0+0
        dst[0]=512x512+1883+359
crtc[66]: crtc-0
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=1
        connector_mask=1
        encoder_mask=1
        mode: "1920x1080": 60 147840 1920 1968 2000 2200 1080 1083 1089 1120 0x48 0x9
        lm[0]=0
        ctl[0]=0
        dspp[0]=0
crtc[67]: crtc-1
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=2
        connector_mask=2
        encoder_mask=2
        mode: "2560x1440": 60 241500 2560 2608 2640 2720 1440 1443 1448 1481 0x48 0x9
        lm[0]=1
        ctl[0]=1
connector[32]: eDP-1
        crtc=crtc-0
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[34]: DP-1
        crtc=crtc-1
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[41]: Writeback-1
        crtc=(null)
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
      state on 6.9.8+patch prior to suspend 
      plane[42]: plane-0
        crtc=crtc-0
        fb=78
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=1920x1080
                layers:
                        size[0]=1920x1080
                        pitch[0]=7680
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=001129fc
                                size=10485760
                                imported=no
        crtc-pos=1920x1080+0+0
        src-pos=1920.000000x1080.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_0
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=1920x1080+0+0
        dst[0]=1920x1080+0+0
plane[48]: plane-1
        crtc=crtc-1
        fb=70
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=2560x1440
                layers:
                        size[0]=2560x1440
                        pitch[0]=10240
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=001133fc
                                size=16777216
                                imported=no
        crtc-pos=2560x1440+0+0
        src-pos=2560.000000x1440.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_8
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=2560x1440+0+0
        dst[0]=2560x1440+0+0
plane[54]: plane-2
        crtc=(null)
        fb=0
        crtc-pos=512x512+0+0
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=0
        sspp[0]=sspp_9
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=0x0+0+0
        dst[0]=0x0+0+0
plane[60]: plane-3
        crtc=crtc-1
        fb=71
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x0
                size=512x512
                layers:
                        size[0]=512x512
                        pitch[0]=2048
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=00115944
                                size=1048576
                                imported=no
        crtc-pos=512x512+1083+852
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=1
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=2
        sspp[0]=sspp_10
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=512x512+0+0
        dst[0]=512x512+1083+852
crtc[66]: crtc-0
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=1
        connector_mask=1
        encoder_mask=1
        mode: "1920x1080": 60 147840 1920 1968 2000 2200 1080 1083 1089 1120 0x48 0x9
        lm[0]=0
        ctl[0]=0
        dspp[0]=0
crtc[67]: crtc-1
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=a
        connector_mask=2
        encoder_mask=2
        mode: "2560x1440": 60 241500 2560 2608 2640 2720 1440 1443 1448 1481 0x48 0x9
        lm[0]=1
        ctl[0]=1
connector[32]: eDP-1
        crtc=crtc-0
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[34]: DP-1
        crtc=crtc-1
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[41]: Writeback-1
        crtc=(null)
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
      state on 6.9.8+patch following resume 
      plane[42]: plane-0
        crtc=crtc-0
        fb=76
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=1920x1080
                layers:
                        size[0]=1920x1080
                        pitch[0]=7680
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=001129fc
                                size=10485760
                                imported=no
        crtc-pos=1920x1080+0+0
        src-pos=1920.000000x1080.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_0
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=1920x1080+0+0
        dst[0]=1920x1080+0+0
plane[48]: plane-1
        crtc=crtc-1
        fb=78
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x500000000000001
                size=2560x1440
                layers:
                        size[0]=2560x1440
                        pitch[0]=10240
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=001070f3
                                size=16777216
                                imported=no
        crtc-pos=2560x1440+0+0
        src-pos=2560.000000x1440.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=1
        sspp[0]=sspp_8
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=2560x1440+0+0
        dst[0]=2560x1440+0+0
plane[54]: plane-2
        crtc=(null)
        fb=0
        crtc-pos=512x512+0+0
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=0
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=0
        sspp[0]=sspp_9
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=0x0+0+0
        dst[0]=0x0+0+0
plane[60]: plane-3
        crtc=crtc-1
        fb=71
                allocated by = kwin_wayland
                refcount=2
                format=AR30 little-endian (0x30335241)
                modifier=0x0
                size=512x512
                layers:
                        size[0]=512x512
                        pitch[0]=2048
                        offset[0]=0
                        obj[0]:
                                name=0
                                refcount=2
                                start=00115844
                                size=1048576
                                imported=no
        crtc-pos=512x512+1113+1041
        src-pos=512.000000x512.000000+0.000000+0.000000
        rotation=1
        normalized-zpos=1
        color-encoding=ITU-R BT.601 YCbCr
        color-range=YCbCr limited range
        color_mgmt_changed=0
        stage=2
        sspp[0]=sspp_10
        multirect_mode[0]=none
        multirect_index[0]=solo
        src[0]=512x399+0+0
        dst[0]=512x399+1113+1041
crtc[66]: crtc-0
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=1
        connector_mask=1
        encoder_mask=1
        mode: "1920x1080": 60 147840 1920 1968 2000 2200 1080 1083 1089 1120 0x48 0x9
        lm[0]=0
        ctl[0]=0
crtc[67]: crtc-1
        enable=1
        active=1
        self_refresh_active=0
        planes_changed=1
        mode_changed=0
        active_changed=0
        connectors_changed=0
        color_mgmt_changed=0
        plane_mask=a
        connector_mask=2
        encoder_mask=2
        mode: "2560x1440": 60 241500 2560 2608 2640 2720 1440 1443 1448 1481 0x48 0x9
        lm[0]=1
        ctl[0]=1
connector[32]: eDP-1
        crtc=crtc-0
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[34]: DP-1
        crtc=crtc-1
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
connector[41]: Writeback-1
        crtc=(null)
        self_refresh_aware=0
        max_requested_bpc=0
        colorspace=Default
    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      @lumag, please see attached the dmesg debug logs with linux-next next-20240709. Once with your patches, once without. The CTM issue only occurs with your patch. For each file, I start recording with Night Light enabled, then 1/ suspend and resume the system 2/ toggle "Night Light" (CTM use) off and on again. With your patch, step 2 does not result in visible behavior. I also notice slight screen flickering on the internal display when moving the mouse on the internal display with your patch.

      dmesg-linux-next-suspend.txt

      dmesg-linux-next-patched-suspend.txt

      Or perhaps more useful as a baseline: next-20240709 with 0002-drm-msm-dpu-don-t-play-tricks-with-debug-macros.patch but without 0001-drm-msm-dpu1-don-t-choke-on-disabling-the-writeback-.patch: dmesg-linux-next-suspend-debug-patch.txt

      Edited by Leonard Lausen
    • Leonard Lausen mentioned in issue #58 (closed)

      mentioned in issue #58 (closed)

    • Leonard Lausen
      Leonard Lausen @leezu ·
      Author

      Opened a new issue #58 (closed) to discuss the CTM issues with 0001-drm-msm-dpu1-don-t-choke-on-disabling-the-writeback-.patch

    • Dmitry Baryshkov mentioned in commit lumag/msm@d638d0b2

      mentioned in commit lumag/msm@d638d0b2

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply