Skip to content
  • Francesco Dolcini's avatar
    treewide, serdev: change receive_buf() return type to size_t · fed99212
    Francesco Dolcini authored
    receive_buf() is called from ttyport_receive_buf() that expects values
    ">= 0" from serdev_controller_receive_buf(), change its return type from
    ssize_t to size_t.
    
    The need for this clean-up was noticed while fixing a warning, see
    commit 94d05394
    
     ("Bluetooth: btnxpuart: fix recv_buf() return value").
    Changing the callback prototype to return an unsigned seems the best way
    to document the API and ensure that is properly used.
    
    GNSS drivers implementation of serdev receive_buf() callback return
    directly the return value of gnss_insert_raw(). gnss_insert_raw()
    returns a signed int, however this is not an issue since the value
    returned is always positive, because of the kfifo_in() implementation.
    gnss_insert_raw() could be changed to return also an unsigned, however
    this is not implemented here as request by the GNSS maintainer Johan
    Hovold.
    
    Suggested-by: default avatarJiri Slaby <jirislaby@kernel.org>
    Link: https://lore.kernel.org/all/087be419-ec6b-47ad-851...
    fed99212