Skip to content
Snippets Groups Projects
Commit 57b97a66 authored by Rodrigo Vivi's avatar Rodrigo Vivi Committed by Lucas De Marchi
Browse files

dim: Introduce an option for maintainers to bypass missed link


In some rare situations it is better to bypass this requirement on purpose
then to rebase the whole branch. So, let's add a helper instead of
temporarily editing dim every time we need to do this.

Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 0daf0be5
No related branches found
No related tags found
1 merge request!52dim: Introduce an option for maintainers to bypass missed link
Pipeline #1174425 passed
...@@ -1032,7 +1032,7 @@ function checkpatch_commit_push ...@@ -1032,7 +1032,7 @@ function checkpatch_commit_push
fi fi
# check for Link tag # check for Link tag
if [[ "$managed_branch" = "1" ]] && ! git show -s $sha1 | grep -qi 'Link:' ; then if [[ $LINK_MISSING_I_KNOW -ne 1 ]] && [[ "$managed_branch" = "1" ]] && ! git show -s $sha1 | grep -qi 'Link:' ; then
echoerr "$cite: Link tag missing." echoerr "$cite: Link tag missing."
rv=1 rv=1
fi fi
...@@ -2806,9 +2806,10 @@ DRY_RUN= ...@@ -2806,9 +2806,10 @@ DRY_RUN=
INTERACTIVE= INTERACTIVE=
DRY= DRY=
FORCE= FORCE=
LINK_MISSING_I_KNOW=
HELP= HELP=
while getopts hdfis opt; do while getopts hdfils opt; do
case "$opt" in case "$opt" in
d) d)
DRY_RUN=--dry-run DRY_RUN=--dry-run
...@@ -2824,6 +2825,11 @@ while getopts hdfis opt; do ...@@ -2824,6 +2825,11 @@ while getopts hdfis opt; do
h) h)
HELP=1 HELP=1
;; ;;
l)
if ask_user "This option to ignore missed links should only be used by maintainers on rare situations. Are you sure?"; then
LINK_MISSING_I_KNOW=1
fi
;;
s) s)
# FIXME: transitional, do unconditionally at the top # FIXME: transitional, do unconditionally at the top
# when there are no more errors about unbound variables # when there are no more errors about unbound variables
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment