Skip to content
Snippets Groups Projects

dim: Introduce an option for maintainers to bypass missed link

In some rare situations it is better to bypass this requirement on purpose then to rebase the whole branch. So, let's add a helper instead of temporarily editing dim every time we need to do this.

Signed-off-by: Rodrigo Vivi rodrigo.vivi@intel.com

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • can you give an example where this was needed?

  • commit 318e82583ca96fdb835d28e0c1ac8dc7cfbfb5bd Author: Jani Nikula jani.nikula@intel.com Date: Wed Apr 3 00:22:25 2024 +0300

    Revert "drm/i915/display: move dmc_firmware_path to display params"
    
    This reverts commit 0d82a0d6f5561af8dea7011d1b7cae510021723e.
    
    The commit failed to take into account that the parameter duplication
    and debugfs for char * parameters were subtly different between i915
    core and display, and caused the DMC and PM to be disabled. Moreover,
    the patch was pushed with failing CI results. Revert, and get back to
    the drawing board.
    
    Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Acked-by: Lucas De Marchi <lucas.demarchi@intel.com>
    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
  • In retrospect I think I should've sent the patch anyway, and applied that with Link: even if I had not waited for CI results.

    The option might be helpful regardless, idk.

  • this was just the example form this round. but I rembember having to change dim in the past (more than once) to bypass this check. Then if that follows up, I imagine that Sima and Dave also have to manually edit on their side... this is what I thought about having a way.

    Edited by Rodrigo Vivi
  • Lucas De Marchi approved this merge request

    approved this merge request

  • added 3 commits

    Compare with previous version

  • Sounds good, but I wonder if it should not be part of -f.

  • Lucas De Marchi mentioned in merge request !40

    mentioned in merge request !40

  • merged

Please register or sign in to reply
Loading