Skip to content
Snippets Groups Projects
Forked from drm / kernel
Source project has a limited visibility.
  • Luca Ceresoli's avatar
    2bff77c6
    scripts/decode_stacktrace.sh: fix decoding of lines with an additional info · 2bff77c6
    Luca Ceresoli authored
    Since commit bdf8eafb ("arm64: stacktrace: report source of unwind
    data") a stack trace line can contain an additional info field that was not
    present before, in the form of one or more letters in parentheses. E.g.:
    
      [  504.517915]  led_sysfs_enable+0x54/0x80 (P)
                                                 ^^^
    
    When this is present, decode_stacktrace decodes the line incorrectly:
    
      [  504.517915] led_sysfs_enable+0x54/0x80 P
    
    Extend parsing to decode it correctly:
    
      [  504.517915] led_sysfs_enable (drivers/leds/led-core.c:455 (discriminator 7)) (P)
    
    The regex to match such lines assumes the info can be extended in the
    future to other uppercase characters, and will need to be extended in case
    other characters will be used. Using a much more generic regex might incur
    in false positives, so this looked like a good tradeoff.
    
    Link: https://lkml.kernel.org/r/20241230-decode_stacktrace-fix-info-v1-1-984910659173@bootlin.com
    
    
    Fixes: bdf8eafb ("arm64: stacktrace: report source of unwind data")
    Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Miroslav Benes <mbenes@suse.cz>
    Cc: Puranjay Mohan <puranjay@kernel.org>
    Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    2bff77c6
    History
    scripts/decode_stacktrace.sh: fix decoding of lines with an additional info
    Luca Ceresoli authored
    Since commit bdf8eafb ("arm64: stacktrace: report source of unwind
    data") a stack trace line can contain an additional info field that was not
    present before, in the form of one or more letters in parentheses. E.g.:
    
      [  504.517915]  led_sysfs_enable+0x54/0x80 (P)
                                                 ^^^
    
    When this is present, decode_stacktrace decodes the line incorrectly:
    
      [  504.517915] led_sysfs_enable+0x54/0x80 P
    
    Extend parsing to decode it correctly:
    
      [  504.517915] led_sysfs_enable (drivers/leds/led-core.c:455 (discriminator 7)) (P)
    
    The regex to match such lines assumes the info can be extended in the
    future to other uppercase characters, and will need to be extended in case
    other characters will be used. Using a much more generic regex might incur
    in false positives, so this looked like a good tradeoff.
    
    Link: https://lkml.kernel.org/r/20241230-decode_stacktrace-fix-info-v1-1-984910659173@bootlin.com
    
    
    Fixes: bdf8eafb ("arm64: stacktrace: report source of unwind data")
    Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Miroslav Benes <mbenes@suse.cz>
    Cc: Puranjay Mohan <puranjay@kernel.org>
    Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>