- Sep 29, 2021
-
-
Dylan Baker authored
-
Dylan Baker authored
-
Neha Bhende authored
Few tessellation related piglit test are crashing. This patch fixes unhandled case Tested with piglit Reviewed-by:
Charmaine Lee <charmainel@vmware.com> (cherry picked from commit 0e1c962cc105a9330caf22266e1962b049c13454) (cherry picked from commit f2b08dec) Part-of: <mesa/mesa!12950>
-
Qiang Yu authored
This arg size should be 1 instead of 3. It does not affect functionality because we does not enable it in SPI_PS_INPUT_ADDR. But it does affect the VGPR number that LLVM produce when LLVM still count with all PS function arguments. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Signed-off-by:
Qiang Yu <yuq825@gmail.com> (cherry picked from commit 6f9f3506) Part-of: <mesa/mesa!13053>
-
Dylan Baker authored
-
- Sep 28, 2021
-
-
Cc: 21.1 21.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!13048> (cherry picked from commit b1cf504f)
-
Fixes: 0580d4c1 "radeonsi: enable HTILE with mipmapping on gfx9+" Closes: mesa/mesa#5398 Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!13048> (cherry picked from commit 4cb00871)
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: f6667cb0 ("nir: Add a memcpy optimization pass") Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!13079> (cherry picked from commit daa8a81d)
-
Fixes dEQP-VK.pipeline.cache.no_cache_control.readwrite_cache.pipeline_from_get_data.vertex_stage_geometry_stage_fragment_stage Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Fixes: 7e664a53 ("radv: Don't generate GS copy shader when the pipeline has NGG.") Part-of: <mesa/mesa!12741> (cherry picked from commit 59084f05)
-
Fixes following piglit fails: spec@ext_framebuffer_object@fbo-blending-formats spec@ext_framebuffer_object@fbo-blending-formats@GL_RGB10 Cc: mesa-stable Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Part-of: <mesa/mesa!13051> (cherry picked from commit e043b977)
-
Dylan Baker authored
-
- Sep 27, 2021
-
-
With NGG culling, the shaders are split into two parts: the top part that computes just the position output, and the bottom part which produces the other outputs. To reduce redundancy between the two, I added some code to reuse uniform variables between them. However, there is an edge case I didn't think about: because of vertex repacking, it is possible for the bottom part to process a different vertex. Therefore it can take a different divergent code path (though it must still take the same uniform code path). Due to this, when a uniform value comes from divergent control flow, this may be undefined in the bottom part. This commit stops reusing uniform variables from divergent control flow, to fix issues that arise from this. Fossil DB stats on Sienna Cichlid with NGGC on: Totals from 1723 (1.34% of 128647) affected shaders: VGPRs: 89312 -> 89184 (-0.14%); split: -0.15%, +0.01% SpillSGPRs: 4575 -> 120 (-97.38%) CodeSize: 10846424 -> 10873836 (+0.25%); split: -0.68%, +0.93% MaxWaves: 34582 -> 34602 (+0.06%); split: +0.06%, -0.01% Instrs: 2124471 -> 2128835 (+0.21%); split: -0.51%, +0.72% Latency: 7274569 -> 7293899 (+0.27%); split: -0.22%, +0.48% InvThroughput: 1637130 -> 1635490 (-0.10%); split: -0.17%, +0.07% VClause: 25141 -> 25414 (+1.09%); split: -0.02%, +1.10% SClause: 56367 -> 59503 (+5.56%); split: -1.36%, +6.93% Copies: 230704 -> 219313 (-4.94%); split: -5.49%, +0.55% Branches: 72781 -> 72681 (-0.14%); split: -0.21%, +0.07% PreSGPRs: 118766 -> 100176 (-15.65%); split: -15.70%, +0.05% PreVGPRs: 76876 -> 76833 (-0.06%) Fixes: 0bb543bb Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!13001> (cherry picked from commit 09f89d15)
-
This makes the code more elegant and also fixes the mistake of skipping the blocks that come before loops. Fossil DB changes on Sienna Cichlid with NGGC on: Totals from 1026 (0.80% of 128647) affected shaders: SpillSGPRs: 3817 -> 4035 (+5.71%) CodeSize: 5582856 -> 5538732 (-0.79%); split: -0.89%, +0.10% Instrs: 1106907 -> 1100180 (-0.61%); split: -0.68%, +0.07% Latency: 10084948 -> 10052197 (-0.32%); split: -0.37%, +0.05% InvThroughput: 1567012 -> 1564949 (-0.13%); split: -0.16%, +0.03% SClause: 39789 -> 39075 (-1.79%); split: -2.33%, +0.54% Copies: 95184 -> 96456 (+1.34%); split: -0.19%, +1.53% Branches: 44087 -> 44093 (+0.01%); split: -0.01%, +0.02% PreSGPRs: 47584 -> 51009 (+7.20%); split: -0.61%, +7.80% Fixes: 0bb543bb Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> Part-of: <mesa/mesa!13001> (cherry picked from commit cb19ebe7)
-
Dylan Baker authored
-
- Sep 24, 2021
-
-
Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Timur Kristóf <timur.kristof@gmail.com> Fixes: 9bf30c4a ("aco/tests: add tests for form_hard_clauses()") Part-of: <mesa/mesa!12017> (cherry picked from commit 8cf37fc8)
-
Dylan Baker authored
-
All our GLES2-only divers were failing these KHR tests because we were missing new OES_required_internalformat internalformats for CopyTexImage. Cc: mesa-stable Reviewed-by:
Juan A. Suarez <jasuarez@igalia.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!12962> (cherry picked from commit e470d9fa)
-
Dylan Baker authored
-
- Sep 22, 2021
-
-
Ref: mesa/mesa!12908 Cc: mesa-stable Fixes: e435511b ("intel/dev: Add device info for ADL GT2") Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!12973> (cherry picked from commit c746bf4c) Conflicts: src/intel/dev/intel_device_info.c
-
Ref: mesa/mesa!12908 Cc: mesa-stable Fixes: e435511b ("intel/dev: Add device info for ADL GT2") Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!12973> (cherry picked from commit d4174f5f)
-
Use create_backed_surface_view helper function to create/reuse alternate surface view when the to-be-bound surface view was created in a different context. This fixes render target views leak running gazebo. Cc: mesa-stable Reviewed-by:
Neha Bhende <bhenden@vmware.com> Part-of: <mesa/mesa!12952> (cherry picked from commit e5dc9002)
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
- Sep 21, 2021
-
-
The ZS view can be NULL if a stencil-only buffer is attached to the FB. Fixes: 1de393fe ("panfrost: Fix ZS reloading on Bifrost v6") Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Tomeu Vizoso <tomeu.vizoso@collabora.com> Part-of: <mesa/mesa!12095> (cherry picked from commit 9f4dab0f)
-
These are I/O variables which are not going to be removed anyway. However, get_variable_io_mask handles their location incorrectly. Found using the GCC undefined behavior sanitizer. Fixes the following error: runtime error: shift exponent 4294967258 is too large for 64-bit type 'long unsigned int' Closes: #5319 Fixes: cf5f8f55 Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!12719> (cherry picked from commit 872d2182)
-
match_mask checks the intrinsic type and decides whether it's per-patch or not. VS don't have per-patch outputs, so this causes wrong behaviour there. Found using the GCC undefined behavior sanitizer. Fixes the following error: runtime error: shift exponent 18446744073709551584 is too large for 64-bit type 'long unsigned int' Closes: #5319 Fixes: bf966d1c Signed-off-by:
Timur Kristóf <timur.kristof@gmail.com> Reviewed-by:
Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!12719> (cherry picked from commit 13e467a1)
-
Commit 0245b825 switched from returning the error code VK_ERROR_OUT_OF_DATE_KHR to returning the success code VK_SUBOPTIMAL_KHR. Prior to that commit, the error code caused all code paths to fail immediately, but the success code does not. Currently the success code is not recorded in some scenarios, resulting in a result of VK_SUCCESS instead. This breaks applications that rely on the result (per the spec) to trigger resizes. This commit ensures that the proper VK_SUBOPTIMAL_KHR success code is set as a sticky status (as comments indicate was intended), ensuring that it is propagated to user code. Fixes #5331 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Daniel Stone <daniels@collabora.com> Cc: mesa-stable Part-of: <mesa/mesa!12782> (cherry picked from commit fc5ea6a0)
-
Do not dereference color buffer #0 in the SFBD code path if no color buffer is attached, as with depth-only attachments. Fixes a crash running glmark2 -b shadow on Mali T720. Signed-off-by:
Italo Nicola <italonicola@collabora.com> Fixes: c746747c ("panfrost: fix GL_EXT_multisampled_render_to_texture regression") Reviewed-by:
Boris Brezillon <boris.brezillon@collabora.com> Part-of: <mesa/mesa!12927> (cherry picked from commit 7682a5de)
-
Cc: mesa-stable Fixes: c6bdd976 ("panfrost: Split out v6/v7 format tables") Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Part-of: <mesa/mesa!12508> (cherry picked from commit 8805509f)
-
Cc: mesa-stable Fixes: c6bdd976 ("panfrost: Split out v6/v7 format tables") Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!12508> (cherry picked from commit bab84c62)
-
Extension implementation missed GL_TIMESTAMP_EXT for Get* functions, commit 5d58fea6 added GetInteger64vEXT support but obviously we need to support the enum as well ... Cc: mesa-stable Closes: mesa/mesa#5361 Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12890> (cherry picked from commit 1a6c01a6)
-
They can never be allocated from the cache, as fd_bo_state() would return FD_BO_STATE_UNKNOWN Fixes: 7dabd624 ("freedreno/drm: Userspace fences") Signed-off-by:
Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!11176> (cherry picked from commit 21fcb265)
-
The fd_fence_finish() may be passed a special timeout value PIPE_TIMEOUT_INFINITE. This gets propagated all the way to get_abs_timeout(), where it gets converted to a huge timeout value and passed down to the kernel. At least on iMX53, the kernel may complain about this value being too large and emit a backtrace. The relevant piece of information there is the following: schedule_timeout: wrong timeout value bf94984b Per suggestion by Rob Clark, fix this in get_abs_timeout() by picking the same rollover implementation present in etnaviv. This fixes one part of the problem where the tv_nsec becomes larger than NSEC_PER_SEC, which is invalid. However, the PIPE_TIMEOUT_INFINITE is sufficiently large to make tv_secs larger than KTIME_SEC_MAX, which makes kernel-side ktime_set() return KTIME_MAX and that in turn triggers the above "wrong timeout value N" message. Fix this by setting the timeout to large enough value in case of PIPE_TIMEOUT_INFINITE. While the timeout is not truly infinite, the timeout is long enough as anything longer than a few seconds means the GPU got hung. The "util/timespec.h" is added so we can use NSEC_PER_SEC instead of ad-hoc constant 1000000000 . The "pipe/p_defines.h" is needed for PIPE_TIMEOUT_INFINITE. This problem can be reliably triggered on iMX53 using Qt5 with EGLFS support, using the qtbase examples, as follows: /usr/share/examples/opengl/qopenglwidget/qopenglwidget -platform eglfs Fixes: f3cc0d27 ("freedreno: import libdrm_freedreno + redesign submit") Signed-off-by:
Marek Vasut <marex@denx.de> Part-of: <mesa/mesa!12886> (cherry picked from commit 6da27271)
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
-