Skip to content
Snippets Groups Projects
Commit e63f5e6e authored by Alyssa Rosenzweig's avatar Alyssa Rosenzweig Committed by Dylan Baker
Browse files

agx: Fix packing of samplers in texture instrs


Typo in the handwritten packing code, oof!

Fixes incorrectly repeated shadows in Neverball (among many other bugs,
I assume). Huge thanks to Lina for the idea that this was the
bug -- fixing it was a breeze from there :-)

Fixes: 9f555388 ("agx: Pack texture ops")
Signed-off-by: default avatarAlyssa Rosenzweig <alyssa@rosenzweig.io>
Suggested-by: default avatarAsahi Lina <lina@asahilina.net>
Part-of: <mesa/mesa!17198>
(cherry picked from commit 47a3f122)
parent 7dadb0a8
No related branches found
No related tags found
No related merge requests found
......@@ -1336,7 +1336,7 @@
"description": "agx: Fix packing of samplers in texture instrs",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "9f5553883428e0f393e40d6254c9b33bd64d19eb"
},
......@@ -597,7 +597,7 @@ agx_pack_instr(struct util_dynarray *emission, struct util_dynarray *fixups, agx
(((uint64_t) q3) << 43) |
(((uint64_t) I->mask) << 48) |
(((uint64_t) I->lod_mode) << 52) |
(((uint64_t) (S & BITFIELD_MASK(6))) << 32) |
(((uint64_t) (S & BITFIELD_MASK(6))) << 56) |
(((uint64_t) St) << 62) |
(((uint64_t) q5) << 63);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment