Skip to content
Snippets Groups Projects
  1. Oct 21, 2020
  2. Oct 20, 2020
  3. Sep 28, 2020
  4. Sep 27, 2020
  5. Sep 25, 2020
  6. Sep 24, 2020
  7. Jun 07, 2020
    • Jennifer Berringer's avatar
      flacparse: fix broken reordering of flac metadata · 07e0e8ff
      Jennifer Berringer authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Each FLAC metadata block starts with a flag denoting whether it is the
      last metadata block. The existing flacparse code moves any existing
      VORBISCOMMENT block to immediately follow the STREAMINFO block without
      changing any block's last-metadata-block flag. If no VORBISCOMMENT block
      exists, it created one with the last-metadata-block flag set to true.
      This results in gstflacdec sometimes giving bad headers to libflac when
      trying to play perfectly valid FLAC files depending on the file's
      metadata ordering. Depending on the contents of the other metadata
      blocks, current versions of libflac may or may not return
      FLAC__STREAM_DECODER_ERROR_STATUS_BAD_HEADER when given this broken
      metadata. This is most noticeable with files that have a large cover art
      image attached where VORBISCOMMENT is the very last metadata block with
      no PADDING afterwards.
      
      This patch changes that behavior so that:
      
      1. For FLAC files that already have a VORBISCOMMENT block, the metadata
         order is preserved.
      2. For FLAC files that do not have a VORBISCOMMENT block, the generated
         dummy VORBISCOMMENT is placed immediately after STREAMINFO and
         inherits the last-metadata-block flag from STREAMINFO.
      
      gstreamer/gst-plugins-good#484
      07e0e8ff
  8. Jun 06, 2020
    • Nicolas Pernas Maradei's avatar
      rtpsession: rename RTCP thread · c53fd4ea
      Nicolas Pernas Maradei authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      RTP session starts a new thread for RTCP and names it
      "rtpsession-rtcp-thread" which happens to be longer than the maximum 16B
      allowed by pthread_setname_np and causes the naming to fail.
      See docs for more details.
      
      This commit simply shortens the thread's name so it can actually be set.
      c53fd4ea
  9. Mar 13, 2020
  10. Feb 10, 2020
    • Alexander Lapajne's avatar
      rtspsrc: Fix for segmentation fault when handling set/get_parameter requests · d73cda4f
      Alexander Lapajne authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      gstrtspsrc uses a queue, set_get_param_q, to store set param and get
      param requests. The requests are put on the queue by calling
      get_parameters() and set_parameter(). A thread which executs in
      gst_rtspsrc_thread() then pops requests from the queue and processes
      them. The crash occured because the queue became empty and a NULL
      request object was then used. The reason that the queue became empty
      is that it was popped even when the thread was NOT processing a get
      parameter or set parameter command. The fix is to make sure that the
      queue is ONLY popped when the command being processed is a set
      parameter or get parameter command.
      d73cda4f
  11. Feb 08, 2020
  12. Feb 04, 2020
  13. Jan 14, 2020
  14. Jan 07, 2020
  15. Dec 06, 2019
  16. Dec 03, 2019
Loading