Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-good gst-plugins-good
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 648
    • Issues 648
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 82
    • Merge requests 82
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Issues
  • #717

Closed
Open
Created Apr 14, 2020 by Matt Staples@staples255

rtspsrc no longer posts an error message if it times out waiting for response

Prior to commit 81217528, gst_rtsp_try_send would call GST_ELEMENT_ERROR if gst_rtspsrc_connection_receive (which has since been replaced by gst_rtsp_src_receive_response) failed twice in a row. It currently posts a warning on each of the two failures, but then fails without informing the application layer. This was found via calls from gst_rtspsrc_retrieve_sdp, whose goto send_error handler has a comment saying "Don't post a message - the rtsp_send method will have taken care of it because we passed NULL for the response code." That comment is still true if there's an error on send, but it's no longer true if there's an error (e.g., timeout) on receive.

Assignee
Assign to
Time tracking