Skip to content
Snippets Groups Projects
  1. Sep 07, 2020
  2. Aug 31, 2020
    • Jan Alexander Steffens's avatar
      flvmux: Avoid crash when best pad gets flushed · 2d08d160
      Jan Alexander Steffens authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      The 'best' pad might receive a flush event between us picking it and us
      popping the buffer. In this case, the buffer will be missing.
      
      Part-of: <!711>
      2d08d160
    • Jan Alexander Steffens's avatar
      flvmux: Correct breaks in gst_flv_mux_find_best_pad · 01594d19
      Jan Alexander Steffens authored
      The code seems to use `continue` and `break` as if both refer to the
      surrounding `while` loop. But because `break` breaks out of the
      `switch`, they actually have the same effect.
      
      This may have caused the loop not to terminate when it should. E.g. when
      `skip_backwards_streams` drops a buffer we should abort the aggregation
      and wait for all pads to be filled again. Instead, we might have just
      selected a subsequent pad as our new "best".
      
      Replace `break` with `done = TRUE; break`, and `continue` with `break`.
      Then simplify the code a bit.
      
      Part-of: <!710>
      01594d19
  3. Aug 24, 2020
  4. Aug 20, 2020
  5. Aug 18, 2020
  6. Aug 13, 2020
  7. Aug 11, 2020
  8. Aug 10, 2020
  9. Aug 08, 2020
  10. Aug 07, 2020
  11. Aug 04, 2020
  12. Jul 31, 2020
  13. Jul 29, 2020
    • Jordan Petridіs's avatar
      auparse: fix compiler warnings · 516db3f1
      Jordan Petridіs authored
      GCC 10 was complaining like following. It really is complaining about default cases returning
      with potentially unitialized *desval, but those cases in the switch should never be hit.
      
      ```
       ../subprojects/gst-plugins-good/gst/auparse/gstauparse.c: In function 'gst_au_parse_chain':
      ../subprojects/gst-plugins-good/gst/auparse/gstauparse.c:481:37: error: 'timestamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
        481 |       GST_BUFFER_TIMESTAMP (outbuf) = timestamp;
      ../subprojects/gst-plugins-good/gst/auparse/gstauparse.c:482:36: error: 'duration' may be used uninitialized in this function [-Werror=maybe-uninitialized]
        482 |       GST_BUFFER_DURATION (outbuf) = duration;
      ../subprojects/gst-plugins-good/gst/auparse/gstauparse.c:480:34: error: 'offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
        480 |       GST_BUFFER_OFFSET (outbuf) = offset;
      cc1: all warnings being treated as errors
      ```
      
      Part-of: <gstreamer/gst-plugins-good!671>
      516db3f1
    • George Kiagiadakis's avatar
  14. Jul 28, 2020
  15. Jul 27, 2020
  16. Jul 24, 2020
  17. Jul 23, 2020
Loading