- Mar 12, 2023
-
-
After enabling the Wayland platform for x86_64, multiple new tests were triggered, some of which timed out. Also wayland-dEQP-EGL.functional.negative_api.create_pixmap_surface now pass. Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21786>
-
Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21786>
-
- Mar 11, 2023
-
-
Fixes regression with Dolphin's ubershaders. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <!21855>
-
this otherwise has some weird side effects Fixes: 48a04781 ("zink: add renderdoc handling") Part-of: <mesa/mesa!21816>
-
Currently, the generated tests consist of some boilerplate, generated test cases, and at the very end the actual test. This is bad for readability, because the actual code is all the way at the bottom. It's also bad for clang-format linting: even though the test cases are /* clang-format off */, they still take an exceptionally long time to parse when linting. I suspect this is a clang-format bug, but it's easy enough to workaround. To solve these issues, restructure so that the test cases are in separate files (containing the actual data), but the manually written test functions are consolidated into a new family of generated layout tests. This is probably cleaner. Parallel clang-format linting is now 10x faster on the M1, which means it's now practical to lint in my "publish branch" hook. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21854>
-
Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!21698>
-
Not using it yet, that will be done in the next patch. Xe only supports submission using VM. For i915 the backend functions are just a noop. Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!21698>
-
Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!21698>
-
Also using the vm_id to create gem buffers. Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!21698>
-
Signed-off-by:
José Roberto de Souza <jose.souza@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!21698>
-
While [1] added some boolean conversion lowering patterns, those were already dealt with on [2]. [1] - b86305bb ("nir/algebraic: collapse conversion opcodes (many patterns)") [2] - d7e0d47b ("nir/algebraic: nir: Add a bunch of b2[if] optimizations") Fixes: b86305bb ("nir/algebraic: collapse conversion opcodes (many patterns)") Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Signed-off-by:
Isabella Basso <isabellabdoamaral@usp.br> Part-of: <mesa/mesa!20965>
-
As noted on [1], lowering patterns of the form floatS -> floatB -> floatS ==> floatS cannot require precision since this may cause flush denorming. [1] 3f779013 ("nir: Add an algebraic optimization for float->double->float") Fixes: b86305bb ("nir/algebraic: collapse conversion opcodes (many patterns)") Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Signed-off-by:
Isabella Basso <isabellabdoamaral@usp.br> Part-of: <mesa/mesa!20965>
-
Conversions on smaller bit sizes should also be collapsed when composed. This also adds more patterns on the intS -> intB -> floatB ==> intS -> floatB lowering so as to deal with any int size C > B instead of a fixed intB. Closes: #7776 Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Signed-off-by:
Isabella Basso <isabellabdoamaral@usp.br> Part-of: <!20965>
-
Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Suggested-by:
Italo Nicola <italonicola@collabora.com> Signed-off-by:
Isabella Basso <isabellabdoamaral@usp.br> Part-of: <mesa/mesa!20965>
-
Some patterns were outside the list of optimizations. Fixes: b86305bb ("nir/algebraic: collapse conversion opcodes (many patterns)") Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Reviewed-by:
Georg Lehmann <dadschoorse@gmail.com> Signed-off-by:
Isabella Basso <isabellabdoamaral@usp.br> Part-of: <mesa/mesa!20965>
-
Sleepy code deletion mood. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by:
Faith Ekstrand <faith.ekstrand@collabora.com> Part-of: <mesa/mesa!21750>
-
Rather than ingesting separate control and memory barriers, ingest only the combined and optimized scoped_barrier intrinsic. For barriers originating from GLSL, this makes it easier to ensure correctness. For barriers originating from SPIR-V, this is required for translation at all, as spirv_to_nir knows only scoped barriers. So this gets us closer to Vulkan and OpenCL. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21752>
-
Very annoying when adding new job and not getting failure due to missing `DEQP_VER: ` Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21702>
-
Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21702>
-
Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21702>
-
New 10 devices - asus-CM1400CXA-dalboz hosted on Collabora farm. 1x Move VA-API tests to the dalboz (more resources). One timeout dropped. 9x Run VKCTS on dalboz. Signed-off-by:
David Heidelberg <david.heidelberg@collabora.com> Part-of: <mesa/mesa!21702>
-
Fixes: d8206f62 ("d3d12: Add video decode implementation of pipe_video_codec") Part-of: <mesa/mesa!21832>
-
Lowers away 64-bit loads, which we'll create in the sysval lowering for dynamically indexed UBOs/VBOs. The lowering generates pack_64_2x32 instructions, so lower those too. No shader-db changes. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21674>
-
Instead of lowering to bitwise ops. Yet another way of subdividing in NIR. Probably insignificant but makes it easy to check that the pass ordering from the previous pass is right. It does let us get much better codegen for unpacksnorm2x16, whatever that's worth. No shader-db changes. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21674>
-
As intended. We can't CSE with partial null destinations in the way, so we shouldn't eliminate dead destinations until after CSE has run. But we should still eliminate dead instructions to ensure CSE doesn't move things around needlessly, hurting register pressure. Noticed while debugging live range splitting. No GLES3.0 shader-db changes. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21674>
-
Our dead code elimination pass does two things: 1. delete instructions that are entirely unnecessary 2. delete unnecessary destinations of necessary instructions To deal with pass ordering issues, we sometimes want to do #1 without #2. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21674>
-
We should handle nir_op_unpack_32_2x16_split_* natively, since we can generate better code with agx_subdivide (coalescing the ops away) than the bitshift lowering. That said, we do need some extra instructions for the floating point conversions. No shader-db changes (which makes sense because we're targetting the GLES3.0 shader-db, which doesn't have the packing GLSL functions). The real motivation of this change isn't optimizing some GLSL pack functions, though, it's avoiding a code regression from using NIR's memory bit size lowering in a future MR. That lowering will turn things like "load i16vec4" into "load i32vec2 + unpack_32_2x16", so we need to be able to coalesce that unpack. Signed-off-by:
Alyssa Rosenzweig <alyssa@rosenzweig.io> Part-of: <mesa/mesa!21674>
-
Daniel Stone authored
Looks like a power or network issue. Part-of: <mesa/mesa!21851>
-
It seems to be experiencing networking issues Part-of: <mesa/mesa!21851>
-
Daniel Stone authored
At some point in a refactoring long ago, our 'Piglit' runs on arm64 started actually being dEQP-GLES2 runs. Oh dear. Surprisingly, there are a number of expectation changes; added every fail I saw from a long overnight stress test. Part-of: <mesa/mesa!21851>
-
This will soon be more confusing than helpful. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Now unused. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Big shrug on this one. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
This was a hack to avoid modelling the full data structure. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Rather than manipulating the raw pointers. This is cleaner. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
We shouldn't have to open-code these. They are real data structures, model them as such in the architecture XML files. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Minimum/maximum LOD and LOD bias are unsigned and signed fixed point formats respectively. They are not unsigned integers. Introduce fixed-point types into our GenXML and use them in the XML, rather than packing in sidebands. This makes the XML more correct and fixes pretty-printing of texture and sampler descriptors. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Strictly this is a signed fixed-point, anyway. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-
Connor Abbott wrote a nice explanation of how instance divisors work on Mali. Let's add it to the driver docs instead of letting it languish in a forgotten header file. This is mostly pasted from the existing header in tree, with a few local changes applied. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <!20445>
-
Nowadays, formats are defined with GenXML, not the old panfrost-job.h, so most of the format #defines in panfrost-job.h are unused. That said, a few are still in use as a backdoor for compressed format queries to avoid a GenXML dependency. That's not great but cleaning that up isn't the subject of this MR. Signed-off-by:
Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <mesa/mesa!20445>
-