Skip to content

ail: Restructure generated tests

Alyssa Rosenzweig requested to merge alyssa/mesa:ail/clang-format into main

Currently, the generated tests consist of some boilerplate, generated test cases, and at the very end the actual test. This is bad for readability, because the actual code is all the way at the bottom. It's also bad for clang-format linting: even though the test cases are /* clang-format off */, they still take an exceptionally long time to parse when linting. I suspect this is a clang-format bug, but it's easy enough to workaround.

To solve these issues, restructure so that the test cases are in separate files (containing the actual data), but the manually written test functions are consolidated into a new family of generated layout tests. This is probably cleaner.

Parallel clang-format linting is now 10x faster on the M1, which means it's now practical to lint in my "publish branch" hook.

Signed-off-by: Alyssa Rosenzweig

Merge request reports