Skip to content

Remove `round-join-bug-520*` CI exceptions for Quartz backend

Christian Rohlfs requested to merge chrohlfs/cairo:round-join into master
Description

This is a fix for !372 (merged).

In the !372 (merged) Quartz pipeline fails with the messages for the new tests:

TESTING round-join-bug-520-round
round-join-bug-520-round.quartz.argb32 [0x1]:	PASS
Test was expected to fail due to an environment variable, but did not!
Please update the corresponding CAIRO_TEST_IGNORE_* variable.
round-join-bug-520-round.quartz.rgb24 [0x1]:	PASS
Test was expected to fail due to an environment variable, but did not!
Please update the corresponding CAIRO_TEST_IGNORE_* variable.
round-join-bug-520-round: ERROR (quartz)
TESTING round-join-bug-520-bevel
round-join-bug-520-bevel.quartz.argb32 [0x1]:	round-join-bug-520-bevel.quartz.argb32 [0x1]:	FAIL
Turning FAIL into XFAIL due to env
round-join-bug-520-bevel.quartz.rgb24 [0x1]:	round-join-bug-520-bevel.quartz.rgb24 [0x1]:	FAIL
Turning FAIL into XFAIL due to env
round-join-bug-520-bevel: XFAIL
In this MR:
  1. Completely removed any mention of the round-join-bug-520* tests from the .gitlab-ci/ files
  2. Added round-join-bug-520-bevel.quartz.ref.png file for bevel test to pass (seems like Quartz is also not aware of the tolerance)
Pipeline

The pipeline 770462 passed. But before it passed there were crashes of the coverage-column-triangles test. Log messages looked like this:

TESTING coverage-column-triangles
coverage-column-triangles.quartz.argb32 [0x1]:	coverage-column-triangles.quartz.argb32 [0x1]:	!!!CRASHED!!!
coverage-column-triangles.quartz.rgb24 [0x1]:	coverage-column-triangles.quartz.rgb24 [0x1]:	!!!CRASHED!!!
coverage-column-triangles: CRASH! (quartz)
...
439 Passed, 132 Failed [1 crashed, 131 expected], 27 Skipped
137 expected failure due to special request via environment variables!
quartz (argb32): 1 crashed! - coverage-column-triangles
quartz (rgb24): 1 crashed! - coverage-column-triangles
...
ERROR: Job failed: Process exited with status 1

Not sure why the crashes happened. Unlikely any of my commits have an influence on this.

Sorry for the fix-MR.

Merge request reports