Skip to content
Snippets Groups Projects
Commit 062a7642 authored by José María Casanova Crespo's avatar José María Casanova Crespo Committed by Eric Engestrom
Browse files

broadcom/compiler: needs_quad_helper_invocation enable PER_QUAD TMU access


We take advantage of the needs_quad_helper_invocation information to
only enable the PER_QUAD TMU access on Fragment Shaders when it is needed.

PER_QUAD access is also disabled on stages different to fragment shader.
Being enabled was causing MMU errors when TMU was doing indexed by vertexid
reads on disabled lanes on vertex stage. This problem was exercised by some
shaders from the GTK new GSK_RENDERER=ngl that were accessing a constant buffer
offset[6], but having PER_QUAD enabled on the TMU access by VertexID was
doing hidden incorrect access to not existing vertex 6 and 7 as TMU was
accessing the full quad.

cc: mesa-stable

Reviewed-by: default avatarIago Toral Quiroga <itoral@igalia.com>
Part-of: <mesa/mesa!28740>
(cherry picked from commit 97f5721b)
parent 4c4b655c
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment