Skip to content

broadcom/compiler: needs_quad_helper_invocation enable PER_QUAD TMU access

José María Casanova Crespo requested to merge chema/mesa:fix-per_quad into main

What does this MR do and why?

broadcom/compiler: needs_quad_helper_invocation enable PER_QUAD TMU access

We take advantage of the needs_quad_helper_invocation information to only enable the PER_QUAD TMU access on Fragment Shaders when it is needed.

PER_QUAD access is also disabled on stages different to fragment shader. Being enabled was causing MMU errors when TMU was doing indexed by vertexid reads on disabled lanes on vertex stage. This problem was exercised by some shaders from the GTK new GSK_RENDERER=ngl that were accessing a constant buffer offset[6], but having PER_QUAD enabled on the TMU access by VertexID was doing hidden incorrect access to not existing vertex 6 and 7 as TMU was accessing the full quad.

cc: mesa-stable

Merge request reports