- Sep 21, 2021
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Sep 15, 2021
-
-
this isn't the max per type, it's the max that can be used for a type, which is the max used by a shader stage * the number of shader stages Cc: mesa-stable Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <mesa/mesa!12829> (cherry picked from commit a45c84f2)
-
As we don't know if we are going to have spilling or not, emit always a last thrsw at the end of the shader. If later we don't have spillings and we don't need that last thrsw, we remove it and switch back to the previous one. This way we ensure all the spilling happens always before the last thrsw. v2 (Juan): - Rework the code to force a last thrsw and remove later if no spilling v3: - Merge functionality inside vir_emit_last_thrsw (Iago) - Add vir_restore_last_thrsw (Juan) v4 (Iago): - Fix/add new comments - Rename variables/parameters v5 (Iago): - Fix comments - Add assertion Cc: mesa-stable Fixes: mesa/mesa#4760 Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com> Part-of: <mesa/mesa!12322> (cherry picked from commit c98ddc77) Conflicts: src/broadcom/compiler/nir_to_vir.c
-
The Wave32 pass manager has been removed a while ago. Fixes: 94a1f45e ("ac/llvm: set target features per function instead of per target machine") Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!12833> (cherry picked from commit 5eda8e5f)
-
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Fixes: 542d40d6 ("nir: Add new GS intrinsics that maintain a count of emitted vertices.") Part-of: <mesa/mesa!12802> (cherry picked from commit edf357b2)
-
Noticed this in passing. Fixes: f3630548 ("crocus: initial gallium driver for Intel gfx 4-7") Part-of: <mesa/mesa!12847> (cherry picked from commit 4149a602)
-
Reworks: * Lionel/Francisco: Add comment Cc: mesa-stable Signed-off-by: Jordan Justen <jordan.l.justen@intel.com> Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <mesa/mesa!12292> (cherry picked from commit 333b2185)
-
Cc: mesa-stable Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!12812> (cherry picked from commit a2a7610e)
-
Sadly need to poke a bit in the src internals to avoid using yet another heap allocated datastructure. Fixes: 52515485 ("nir: Add a nir_instr_remove that recursively removes dead code.") Closes: mesa/mesa#5323 Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!12726> (cherry picked from commit b05cd10b)
-
Dylan Baker authored
-
- Sep 09, 2021
-
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Fixes: e76ae39a ("nir: add support for user defined select control") Fixes: b56451f8 ("nir: add support for user defined loop control") Part-of: <mesa/mesa!12778> (cherry picked from commit c1f724b2)
-
Dylan Baker authored
-
- Sep 08, 2021
-
-
Found while running with libstdc++ debug mode. Fixes the following: Error: attempt to advance a dereferenceable (start-of-sequence) iterator -1 steps, which falls outside its valid range. Cc: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!12682> (cherry picked from commit bb956464)
-
Found while running with libstdc++ debug mode. Fixes the following: Error: attempt to copy-construct an iterator from a singular iterator. Cc: mesa-stable Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!12682> (cherry picked from commit 728ed892)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Fixes: dfb10e4f ("aco/spill: don't count phis as variable access") Part-of: <mesa/mesa!12702> (cherry picked from commit 54f83d71)
-
The previous lowering only wrote a single byte. Fixes: 2f943537 ('aco: add p_extract/p_insert') Reviewed-by: Rhys Perry <pendingchaos02@gmail.com> Part-of: <mesa/mesa!12640> (cherry picked from commit cc4682ed)
-
This estimation was incorrect, the number of waves doesn't only depend of the number of VGPRs. Though, {SPI,COMPUTE}_TMPRING_SIZE.WAVES should limit the number of scratch waves in flight, not sure if limiting it really works. This fixes a GPU hang with an upcoming game, and this might also helps resolving some spurious random GPU hangs. Cc: mesa-stable Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!12700> (cherry picked from commit b31994cf) Conflicts: src/amd/vulkan/radv_shader.c
-
In this case std::array doesn't behave like a regular array, therefore it is NOT okay to index it outside the array, even though std::fill needs us to do so. Change the syntax to do the same thing slightly differently, and add an assertion to make sure the registers are always within the array's bounds. Closes: #5289 Fixes: 0e4747d3 Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Reviewed-by: Tony Wasserka <tony.wasserka@gmx.de> Part-of: <mesa/mesa!12664> (cherry picked from commit 9d20cf27) Conflicts: src/amd/compiler/aco_optimizer_postRA.cpp
-
Avoid a NULL-pointer dereference. Fixes: 2c8a85b7 ("glx: Stash a copy of the XExtCodes in the glx_display") Signed-off-by: Corentin Noël <corentin.noel@collabora.com> Reviewed-by: Adam Jackson <ajax@redhat.com> Part-of: <mesa/mesa!12751> (cherry picked from commit d326d32e)
-
Fixes compiler crashes on: struct Foo { float does_exist_member; }; in vec2 tex; out vec4 color; void main(void) { Foo foo; foo.does_not_exist_member %= 3; /* or any of: <<=, >>=, &=, |=, ^= */ color = vec4(tex.xy, tex.xy); } Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> CC: mesa-stable Reviewed-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!12717> (cherry picked from commit 30b2cc42)
-
Fixes compiler crash on: void main() { gl_FragColor = a += 1; } (a is not declared anywhere) Found with AFL++. Fixes: d1fa69ed ("glsl: do not attempt assignment if operand type not parsed correctly") Signed-off-by: Marcin Ślusarz <marcin.slusarz@intel.com> Reviewed-by: Matt Turner <mattst88@gmail.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!12717> (cherry picked from commit 26302ccd)
-
Without this the following code was successfully compiling. void main() { do int var_1 = 0; while (false); var_1++; } Fixes: a87ac255 ("Initial commit. lol") Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12465> (cherry picked from commit 52893327)
-
We need to clone the previously evaluated loop expression when inlining otherwise we will have conflicts with shadow variables defined in deeper scopes. Fixes: 5c02e2e2 ("glsl: Generate IR for switch statements") Closes: mesa/mesa#5255 Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12465> (cherry picked from commit 174c0579)
-
We need to evaluate the loop-expression of a for loop before we evaluate the loop body otherwise we will find the wrong variable for the following loop. int var_0 = 0; for(; var_0 < 10; var_0++) { const float var_0 = 1.0; gl_FragColor = vec4(0.0, var_0, 0.0, 0.0); } Fixes: a87ac255 ("Initial commit. lol") Closes: mesa/mesa#5262 Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Part-of: <mesa/mesa!12465> (cherry picked from commit 8bbbbb02)
-
Previously STATE_INTERNAL returned 0 for the unhandled states but the outer switch throws the error for unhandled states. Fixes: b4f34977 ("mesa: remove STATE_INTERNAL") Closes: mesa/mesa#5316 Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!12746> (cherry picked from commit 732cd9db)
-
if we're doing a primtype change, the restart needs to be eliminated to avoid losing restart data after the rewrite Fixes: 58307074 ("util/primconvert: handle rewriting of prim-restart draws with unsupported primtype") Acked-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!12625> (cherry picked from commit 5bb747ab)
-
Fixes: bde08ce4 ("llvmpipe: handle compute shader launch with 0 threads") Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!12724> (cherry picked from commit a83a2b98)
-
Cc: mesa-stable Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!12724> (cherry picked from commit dee8b50c)
-
We process all the remaining copy entries one-at-a-time when emitting swaps, so normally we wouldn't need to care about whether the entry is done, except that we need to look at the other entries to split them up and we need to skip this when the copy to be split has already been processed. Closes: mesa/mesa#5307 Fixes: 0ffcb19b ("ir3: Rewrite register allocation") Part-of: <mesa/mesa!12747> (cherry picked from commit f5f94882)
-
At some point I split up the flags into overall/source flags and made copies from immed/const only set IR3_REG_IMMED/IR3_REG_CONST on the source flags, but I forgot to update this. Noticed by inspection. Fixes: 0ffcb19b ("ir3: Rewrite register allocation") Part-of: <mesa/mesa!12747> (cherry picked from commit e7f8d283)
-
Allows VA-API encoding on AMD PITCAIRN Closes: mesa/mesa#5305 Fixes: 43c04ab2 ("radeonsi: separate video hw info based on HW engine individually") Reviewed-by: James Zhu <James.Zhu@amd.com> Part-of: <mesa/mesa!12679> (cherry picked from commit 09aeb59b)
-
Constants could be invalidated via HLSQ_INVALIDATE_CMD which is emitted when new pipeline is bound and in CmdClearAttachments. Also they become invalid after secondary cmd execution. Fixes geometry flickering in Genshin Impact Closes: mesa/mesa#5313 Fixes: 815a85dd "turnip: do not re-emit same vs params" Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!12684> (cherry picked from commit 9ab4bfcb)
-
This is only used pre-a5xx, where we want OUT_WFI. Tested on FD420. Fixes: 8651cfbb (freedreno: emit_marker() cleanup) Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <mesa/mesa!12734> (cherry picked from commit 5d91cf41)
-
We change the hash that is still used to set entry->key. Fixes: d2d642cc "util/fossilize_db: Only allocate entries after full read." Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12725> (cherry picked from commit 8de60a16)
-
Generate a new buffer if OSMesaMakeCurrent is called with a new size Fix a use-after-free error when the old buffer is destroyed Closes: mesa/mesa#5276 Fixes: 26c6f6cf ("gallium/osmesa: Remove the broken buffer-reuse scheme.") Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <mesa/mesa!12685> (cherry picked from commit eed66022)
-
this otherwise gets confused as a vec4 most of the time Cc: mesa-stable@lists.freedesktop.org Reviewed-by: Timur Kristóf <timur.kristof@gmail.com> Part-of: <mesa/mesa!12709> (cherry picked from commit 3b289c9f)
-
Fixes: 80923e8d ("util/format: Add some NEON intrinsics-based u_format_unpack.") Reviewed-by: Emma Anholt <emma@anholt.net> Tested-by: Ross Burton <ross.burton@arm.com> Part-of: <mesa/mesa!12569> (cherry picked from commit 71556766)
-
This is a hardware limitation. Fixes: 1d64a104 "radeonsi: enable dcc image stores on gfx10+" Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!12449> (cherry picked from commit b648d6fb)
-
it's irrelevant whether the shader pointer is valid, the shader cache may still exist Fixes: a9244222 ("zink: split up shader cache per-stage") Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <mesa/mesa!12650> (cherry picked from commit b7534fe8)
-