Skip to content
Snippets Groups Projects
  1. Sep 30, 2023
  2. Aug 14, 2023
  3. Jul 11, 2023
  4. Jul 03, 2023
  5. Jun 15, 2023
    • Daniel Stone's avatar
      xdg-shell: Add suspended toplevel state · c124b641
      Daniel Stone authored
      
      Add a toplevel state to indicate that surface repaints have been
      suspended. This may arise due to occlusion, output power state, etc.
      
      In this state, clients can choose to take meaningful action such as
      suspending any processing which would drive a repaint loop, or
      communicating to the active browser tab that the tab is not
      system-visible, or any other action that would be taken by a client not
      expecting to repaint until further notice.
      
      cf. discussion in wayland/wayland-protocols!99
      
      Signed-off-by: default avatarDaniel Stone <daniels@collabora.com>
      c124b641
  6. May 22, 2023
  7. May 19, 2023
  8. May 18, 2023
  9. May 11, 2023
    • Pekka Paalanen's avatar
      CI: bump ci-templates · 14ae0a9b
      Pekka Paalanen authored
      
      This should fix the following problem when I targeted a MR to
      branch 'color' in Sebastian's fork of wayland-protocols:
      
      $ ci-fairy check-commits --signed-off-by --junit-xml=results.xml
      Traceback (most recent call last):
        File "/usr/bin/ci-fairy", line 33, in <module>
          sys.exit(load_entry_point('ci-fairy==0.1', 'console_scripts', 'ci-fairy')())
        File "/usr/lib/python3.9/site-packages/click/core.py", line 1137, in __call__
          return self.main(*args, **kwargs)
        File "/usr/lib/python3.9/site-packages/click/core.py", line 1062, in main
          rv = self.invoke(ctx)
        File "/usr/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
          return _process_result(sub_ctx.command.invoke(sub_ctx))
        File "/usr/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
          return ctx.invoke(self.callback, **ctx.params)
        File "/usr/lib/python3.9/site-packages/click/core.py", line 763, in invoke
          return __callback(*args, **kwargs)
        File "/usr/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
          return f(get_current_context(), *args, **kwargs)
        File "/usr/lib/python3.9/site-packages/ci_fairy.py", line 1335, in check_commits
          for commit in repo.iter_commits(commit_range):
        File "/usr/lib/python3.9/site-packages/git/objects/commit.py", line 318, in _iter_from_process_or_stream
          finalize_process(proc_or_stream)
        File "/usr/lib/python3.9/site-packages/git/util.py", line 370, in finalize_process
          proc.wait(**kwargs)
        File "/usr/lib/python3.9/site-packages/git/cmd.py", line 447, in wait
          raise GitCommandError(remove_password_if_present(self.args), status, errstr)
      git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
        cmdline: git rev-list cifairy/color..HEAD --
        stderr: 'fatal: bad revision 'cifairy/color..HEAD'
      '
      
      Signed-off-by: default avatarPekka Paalanen <pekka.paalanen@collabora.com>
      14ae0a9b
  10. May 09, 2023
  11. Apr 25, 2023
  12. Apr 18, 2023
  13. Apr 04, 2023
  14. Mar 30, 2023
  15. Mar 25, 2023
    • Faith Ekstrand's avatar
      Add a .mailmap file · c622ae7f
      Faith Ekstrand authored
      
      This will let command-line Git tools re-map my name and e-mail address properly.
      I'm using my personal e-mail address and not my Collabora address because I'm
      not actively contributing to Wayland anymore and this is mostly for letting
      people find me should they dig me up in the project history.
      
      Signed-off-by: default avatarFaith Ekstrand <faith@gfxstrand.net>
      c622ae7f
  16. Feb 27, 2023
    • Jonas Ådahl's avatar
      xdg-output: Remove and tweak contradicting examples · 94482cea
      Jonas Ådahl authored and Simon Ser's avatar Simon Ser committed
      
      The "logical size" as stated by the first paragraph corresponds to the
      monitor size in the global compositor space.
      
      To most clients, this is unnecessary information, and should be ignored,
      but some used the listed examples to derive information that contradicts
      the very definition of what this event communicates.
      
      One example tried to add surface size assumptions, which was not
      correct. Remove this part completely, clients should not try to
      configure their surface sizes from the logical size of a monitor.
      
      The other is the list of size examples; it tried to communicate that a
      compositor sometimes may not scale the viewport of the monitor in its
      global compositor coordinate space, in which case, the logical size
      itself matches the actual resolution. Tweak this wording to make that
      clear that it does not related to any surface size.
      
      Signed-off-by: default avatarJonas Ådahl <jadahl@gmail.com>
      94482cea
  17. Feb 21, 2023
    • Simon Ser's avatar
      xdg-output: clarify goal · cf838fd3
      Simon Ser authored
      
      In the past, xdg-output had only the logical_position and
      logical_size events, then the name and description events were
      added. Later on, they were moved inside wl_output since they aren't
      desktop-specific. However the goals section of the protocol overview
      hasn't been updated accordingly.
      
      Make it clear that this protocol's name and description events should
      not be preferred over wl_output.
      
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      cf838fd3
  18. Feb 12, 2023
  19. Feb 10, 2023
    • Isaac Freund's avatar
      ext-session-lock-v1: relicense to MIT · a9fbc224
      Isaac Freund authored
      All other protocols in wayland-protocols are released under the MIT
      license and this one was only merged with the ISC license by accident.
      
      I am the only person who has touched this protocol in commits and the
      only copyright holder, so relicensing to bring this protocol in line
      with the rest is easy in this case.
      
      References: wayland/wayland-protocols#119
      
      
      Signed-off-by: Isaac Freund's avatarIsaac Freund <mail@isaacfreund.com>
      a9fbc224
    • Isaac Freund's avatar
      ext-session-lock-v1: clarify to fix race · 2e1e07e3
      Isaac Freund authored and Simon Ser's avatar Simon Ser committed
      Clients such as swaylock [1] or waylock [2] provide options to fork and
      detach from the controlling terminal when the session is locked. The
      point of these options is avoid a race on suspending the system. A
      command to suspend the system (e.g. zzz) may safely be chained with
      e.g. waylock as so:
      
      waylock -fork-on-lock && zzz
      
      However, there is no guarantee that the compositor has actually
      blanked all outputs before sending the locked event. Therefore there
      is still a race as new "locked" frames may not have been presented on
      all outputs before the system is suspended.
      
      On my Linux system at least, the current framebuffer seems to be
      preserved on suspend and restored on resume, leading to an "unlocked"
      frame potentially being displayed when the system is resumed. Blanking
      all outputs before suspend eliminates this vulnerability.
      
      Currently clients could theoretically implement such -fork-on-lock
      options a bit better if the compositor supports the presentation-time
      protocol, however no clients I've seen currently do this and it seems
      wise to make clients to do the right thing by default in this security
      sensitive context. The presentation-time protocol is also not sufficient
      in all cases, for example if the compositor has turned off power of an
      output but still exposes it to clients. In this case the client would
      wait forever to get a presentation feedback that will never come.
      
      Unfortunately, the protocol currently states that the locked event will
      be sent immediately on creation of the ext_session_lock_v1 object rather
      than after all normal content is hidden.
      
      Several different approaches have been considered for how to fix this in
      the protocol specification.
      
      One possibility would be to add a new event sent when all normal content
      is hidden. This is however opt-in for clients and therefore less likely
      to be properly implemented by all clients in practice.
      
      Another alternative is to bump the version of the ext_session_lock_v1
      interface and state that the semantics of when the compositor will send
      the locked event. However, this still requires clients to opt-in by
      binding version 2 of the interface. The compositor could technically
      deny the attempts of any version 1 clients to lock the session, but this
      would likely be a bad breaking change for users of version 1 clients.
      While session lock clients should inform the user in some way that their
      attempt to lock the session was denied (e.g. by exiting non-zero) it
      does not seem to be the case that such exit codes are widely checked.
      
      The option to fix the protocol that is all around the most secure is
      changing the semantics of the locked event without bumping the version
      of the interface. This is technically a breaking change, but the failure
      mode is that a client relying on the locked event being sent immediately
      hangs or crashes and the session stays locked.
      
      I also have been unable to find any session lock client in the wild that
      relies on the locked event being sent immediately.
      
      The river wayland compositor [3] in fact already implements the fix for
      this race condition since the 0.2.0 release and has not received any bug
      reports about broken session lock clients yet.
      
      Therefore, I think that making this technically breaking change to the
      protocol is our all around best option in this situation. Prioritizing
      security over compatibility seems like the right trade-off to make for a
      security critical protocol.
      
      [1]: https://github.com/swaywm/swaylock
      [2]: https://github.com/ifreund/waylock
      [3]: https://github.com/riverwm/river
      
      
      
      Signed-off-by: Isaac Freund's avatarIsaac Freund <mail@isaacfreund.com>
      2e1e07e3
    • Isaac Freund's avatar
      ext-session-lock-v1: use RFC 2119 key words · 5dc6efde
      Isaac Freund authored and Simon Ser's avatar Simon Ser committed
      
      Signed-off-by: Isaac Freund's avatarIsaac Freund <mail@isaacfreund.com>
      5dc6efde
  20. Jan 23, 2023
  21. Dec 19, 2022
  22. Nov 29, 2022
  23. Nov 28, 2022
  24. Nov 23, 2022
  25. Nov 21, 2022
  26. Nov 14, 2022
Loading