Skip to content
Snippets Groups Projects
  1. Dec 07, 2018
  2. Dec 06, 2018
  3. Dec 05, 2018
  4. Dec 03, 2018
    • Tobias Klausmann's avatar
      amd/vulkan: meson build - use radv_deps for libvulkan_radeon · 3985a62a
      Tobias Klausmann authored and Emil Velikov's avatar Emil Velikov committed
      Without this the build breaks with:
      
      FAILED: src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o
      cc -Isrc/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha -Isrc/amd/vulkan
      -I../src/amd/vulkan -Isrc/../include -I../src/../include -Isrc -I../src
      -Isrc/mapi -I../src/mapi -Isrc/mesa -I../src/mesa -I../src/gallium/include
      -Isrc/gallium/auxiliary -I../src/gallium/auxiliary -Isrc/amd -I../src/amd
      -Isrc/amd/common -I../src/amd/common -Isrc/compiler -I../src/compiler
      -Isrc/vulkan/util -I../src/vulkan/util -Isrc/vulkan/wsi -I../src/vulkan/wsi
      -Isrc/compiler/nir -I../src/compiler/nir -I/usr/include -I/usr/include/libdrm
      -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
      -std=c99 -O2 -g '-DVERSION="18.3.0-rc5"' -DPACKAGE_VERSION=VERSION
      '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa"
      
      '
      -DGLX_USE_TLS -DHAVE_ST_VDPAU -DENABLE_ST_OMX_BELLAGIO=0
      -DENABLE_ST_OMX_TIZONIA=0 -DHAVE_X11_PLATFORM -DGLX_INDIRECT_RENDERING
      -DGLX_DIRECT_RENDERING -DGLX_USE_DRM -DHAVE_DRM_PLATFORM -DENABLE_SHADER_CACHE
      -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ
      -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT
      -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT
      -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE
      -DHAVE_FUNC_ATTRIBUTE_CONST -DHAVE_FUNC_ATTRIBUTE_FLATTEN
      -DHAVE_FUNC_ATTRIBUTE_MALLOC -DHAVE_FUNC_ATTRIBUTE_PURE
      -DHAVE_FUNC_ATTRIBUTE_UNUSED -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT
      -DHAVE_FUNC_ATTRIBUTE_WEAK -DHAVE_FUNC_ATTRIBUTE_FORMAT
      -DHAVE_FUNC_ATTRIBUTE_PACKED -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL
      -DHAVE_FUNC_ATTRIBUTE_VISIBILITY -DHAVE_FUNC_ATTRIBUTE_ALIAS
      -DHAVE_FUNC_ATTRIBUTE_NORETURN -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS
      -DUSE_X86_64_ASM -DMAJOR_IN_SYSMACROS -DHAVE_SYS_SYSCTL_H -DHAVE_LINUX_FUTEX_H
      -DHAVE_ENDIAN_H -DHAVE_DLFCN_H -DHAVE_STRTOF -DHAVE_MKOSTEMP
      -DHAVE_POSIX_MEMALIGN -DHAVE_TIMESPEC_GET -DHAVE_MEMFD_CREATE -DHAVE_STRTOD_L
      -DHAVE_DLADDR -DHAVE_DL_ITERATE_PHDR -DHAVE_ZLIB -DHAVE_PTHREAD
      -DHAVE_PTHREAD_SETAFFINITY -DHAVE_LIBDRM -DHAVE_LLVM=0x0600
      -DMESA_LLVM_VERSION_PATCH=1 -DHAVE_WAYLAND_PLATFORM -DWL_HIDE_DEPRECATED
      -DHAVE_DRI3 -DHAVE_DRI3_MODIFIERS -Werror=implicit-function-declaration
      -Werror=missing-prototypes -Werror=return-type -fno-math-errno
      -fno-trapping-math -Wno-missing-field-initializers -Wno-format-truncation -O2
      -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables
      -fasynchronous-unwind-tables -fstack-clash-protection -DNDEBUG -fPIC -pthread
      -D__STDC_FORMAT_MACROS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS
      -D__STDC_LIMIT_MACROS -fvisibility=hidden -Wno-override-init
      -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR
      -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_DISPLAY_KHR
      -DVK_USE_PLATFORM_XLIB_XRANDR_EXT  -MD -MQ
      'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o' -MF
      'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o.d' -o
      'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o' -c
      ../src/amd/vulkan/radv_pipeline.c
      In file included from ../src/vulkan/util/vk_alloc.h:29,
                       from ../src/amd/vulkan/radv_private.h:52,
                       from ../src/amd/vulkan/radv_debug.h:27,
                       from ../src/amd/vulkan/radv_pipeline.c:30:
      ../src/../include/vulkan/vulkan.h:54:10: fatal error: wayland-client.h: Datei
      oder Verzeichnis nicht gefunden
       #include <wayland-client.h>
                ^~~~~~~~~~~~~~~~~~
      compilation terminated.
      
      The above command misses the include directory for wayland:
          -I/usr/include/wayland
      
      The missing include is contained in the (until now) unused radv_deps:
      
      if with_platform_wayland
        radv_deps += dep_wayland_client
        radv_flags += '-DVK_USE_PLATFORM_WAYLAND_KHR'
        libradv_files += files('radv_wsi_wayland.c')
      endif
      
      Fixes: 673dda83 "meson: build "radv" vulkan driver for radeon hardware"
      Signed-off-by: default avatarTobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
      Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
      Reviewed-by: default avatarDylan Baker <dylan@pnwbakers.com>
      (cherry picked from commit 9401a2f2)
      3985a62a
    • Karol Herbst's avatar
      nv50,nvc0: Fix gallium nine regression regarding sampler bindings · a7c4368a
      Karol Herbst authored and Emil Velikov's avatar Emil Velikov committed
      The new approach is that samplers don't get unbound even if they won't be used
      in a draw and we should just leave them be as well.
      
      Fixes a regression in multiple windows games using gallium nine and nouveau.
      
      v2: adjust num_samplers to keep track of the highest sampler bound
      v3: rework how to set the new value of num_samplers
      
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106577
      
      
      Fixes: 4d6fab24
             "cso: don't track the number of sampler states bound"
      Signed-off-by: Karol Herbst's avatarKarol Herbst <kherbst@redhat.com>
      Reviewed-by: default avatarIlia Mirkin <imirkin@alum.mit.edu>
      (cherry picked from commit fc0139d2)
      a7c4368a
    • Vinson Lee's avatar
      st/xvmc: Add X11 include path. · ab83cfd2
      Vinson Lee authored and Emil Velikov's avatar Emil Velikov committed
      
      This patch fixes this build error.
      
        CC       tests/xvmc_bench.o
      In file included from tests/xvmc_bench.c:35:
      tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found
               ^~~~~~~~~~~~
      
      Signed-off-by: default avatarVinson Lee <vlee@freedesktop.org>
      Cc: mesa-stable@lists.freedesktop.org
      Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
      (cherry picked from commit 4f74580d)
      ab83cfd2
  5. Nov 30, 2018
  6. Nov 29, 2018
  7. Nov 28, 2018
  8. Nov 27, 2018
  9. Nov 26, 2018
    • Erik Faye-Lund's avatar
      mesa/main: fix incorrect depth-error · d575455b
      Erik Faye-Lund authored and Emil Velikov's avatar Emil Velikov committed
      
      If glGetTexImage or glGetnTexImage is called with a level that doesn't
      exist, we get an error message on this form:
      
      Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0)
      
      This is clearly nonsensical, because these APIs don't even have a
      depth-parameter. The reason is that get_texture_image_dims() return
      all-zero dimensions for non-existent texture-images, and we go on to
      validate these dimensions as if they were user-input, because
      glGetTextureSubImage requires checking.
      
      So let's split this logic in two, so glGetTextureSubImage can have
      stricter input-validation. All arguments that are no longer validated
      are generated internally by mesa, so there's no use in validating them.
      
      Fixes: 42891dba "gettextsubimage: verify zoffset and depth are correct"
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: default avatarJuan A. Suarez <jasuarez@igalia.com>
      (cherry picked from commit c120dbfe)
      d575455b
    • Erik Faye-Lund's avatar
      mesa/main: check cube-completeness in common code · 7d8a9087
      Erik Faye-Lund authored and Emil Velikov's avatar Emil Velikov committed
      
      This check is the only part of dimensions_error_check that isn't about
      error-checking the offset and size arguments of
      glGet[Compressed]TextureSubImage(), so it doesn't really belong in here.
      
      This doesn't make a difference right now, apart for changing the
      presedence of this error. But it will make a difference  for the next
      patch, where we no longer call this method from the non-sub tex-image
      getters.
      
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: default avatarJuan A. Suarez <jasuarez@igalia.com>
      (cherry picked from commit 38af69ad)
      7d8a9087
    • Erik Faye-Lund's avatar
      mesa/main: factor out common error-checking · 55984261
      Erik Faye-Lund authored and Emil Velikov's avatar Emil Velikov committed
      
      This error checking is the same for teximage and texsubimage getters, so
      let's factor it out to its own function.
      
      This will be useful when getteximage and gettexsubimage gets their own
      error checking routines a bit later.
      
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: default avatarJuan A. Suarez <jasuarez@igalia.com>
      (cherry picked from commit 42820c57)
      55984261
    • Erik Faye-Lund's avatar
      mesa/main: factor out tex-image error-checking · 35e9cd34
      Erik Faye-Lund authored and Emil Velikov's avatar Emil Velikov committed
      
      This will be useful when we split error-checking for getteximage and
      gettexsubimage later.
      
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: default avatarJuan A. Suarez <jasuarez@igalia.com>
      (cherry picked from commit 5e0a84f3)
      35e9cd34
    • Erik Faye-Lund's avatar
      mesa/main: remove bogus error for zero-sized images · 1a905e4c
      Erik Faye-Lund authored and Emil Velikov's avatar Emil Velikov committed
      
      The explanation quotes the spec on the following wording to justify the
      error:
      
      "An INVALID_VALUE error is generated if xoffset + width is greater than
       the texture’s width, yoffset + height is greater than the  texture’s
       height, or zoffset + depth is greater than the texture’s depth."
      
      However, this shouldn't generate an error in the case where *all three*
      of width, xoffset and the texture's width are zero. In this case, we end
      up generating an unspecified error.
      
      So let's remove this check, and instead make sure that we consider this
      as an empty texture.
      
      So let's not generate an error, there's non mandated in the spec in
      xoffset/yoffset/zoffset = 0 case. We already avoid doing any work in
      this case, because of the final, non-error generating check in this
      function.
      
      Fixes: b37b35a5 "getteximage: assume texture image is empty for non defined levels"
      Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
      Reviewed-by: default avatarJuan A. Suarez <jasuarez@igalia.com>
      (cherry picked from commit 38bbb612)
      1a905e4c
    • Gert Wollny's avatar
      glsl: free or reuse memory allocated for TF varying · 6b9b7ce3
      Gert Wollny authored and Emil Velikov's avatar Emil Velikov committed
      
      When a shader program is de-serialized the gl_shader_program passed in
      may actually still hold memory allocations for the transform feedback
      varyings. If that is the case, free the varying names and reallocate
      the new storage for the names array.
      
      This fixes a memory leak:
      Direct leak of 48 byte(s) in 6 object(s) allocated from:
       in malloc (/usr/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/libasan.so+0xdb880)
       in transform_feedback_varyings ../../samba/mesa/src/mesa/main/transformfeedback.c:875
       in _mesa_TransformFeedbackVaryings ../../samba/mesa/src/mesa/main/transformfeedback.c:985
       ...
      Indirect leak of 42 byte(s) in 6 object(s) allocated from:
        in __interceptor_strdup (/usr/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/libasan.so+0x761c8)
        in transform_feedback_varyings ../../samba/mesa/src/mesa/main/transformfeedback.c:887
        in _mesa_TransformFeedbackVaryings ../../samba/mesa/src/mesa/main/transformfeedback.c:985
      
      Fixes: ab2643e4
         glsl: serialize data from glTransformFeedbackVaryings
      
      Signed-off-by: default avatarGert Wollny <gert.wollny@collabora.com>
      Reviewed-by: default avatarTapani Pälli <tapani.palli@intel.com>
      (cherry picked from commit f5d05370)
      6b9b7ce3
    • Bas Nieuwenhuizen's avatar
      radv: Fix opaque metadata descriptor last layer. · 02566b97
      Bas Nieuwenhuizen authored and Emil Velikov's avatar Emil Velikov committed
      
      We used the layer count which results in an off by one error.
      
      Not sure this really affects anything.
      
      Fixes: f4e499ec "radv: add initial non-conformant radv vulkan driver"
      Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
      (cherry picked from commit 3c96a1e3)
      02566b97
Loading