- Apr 29, 2020
-
-
Dylan Baker authored
-
Dylan Baker authored
-
- Apr 28, 2020
-
-
Otherwise, we'll hit asserts in brw_compile_cs. Fixes: cf12faef "intel/compiler: Restrict cs_threads to 64" Closes: #2835 Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> Part-of: <mesa/mesa!4746> (cherry picked from commit 81ac741f)
-
Fixes: 8125d796 "intel/dev: Add preliminary device info for Tigerlake" Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Tested-by:
Clayton Craft <clayton.a.craft@intel.com> Part-of: <mesa/mesa!4782> (cherry picked from commit 86f67952)
-
Otherwise we might make a bitset that is too large. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!4751> (cherry picked from commit 4a8d172d)
-
The HW packet requires padding the number of pointers you emit, and we would assertion fail about running out of buffer space if the number of UBOs to be uploaded was odd. Fixes: b4df115d ("freedreno/a6xx: pre-calculate userconst stateobj size") Part-of: <mesa/mesa!4621> (cherry picked from commit 69c8dfd4)
-
Dylan Baker authored
-
- Apr 27, 2020
-
-
After updating vertex inputs being read based on optimized NIR, they may go out of sync with inputs in mesa IR. Which is translated to TGSI and used together with NIR if draw doesn't have llvm. It's much easier to treat such inputs as zero because there is no pass to entirely get rid of them and they don't contribute to shader's output. Fixes: d684fb37 Closes: mesa/mesa#2815 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!4705> (cherry picked from commit eeab9c93)
-
Thanks to VK_EXT_subgroup_size_control, we can end up with gl_SubgroupSize being as low as 8 on Intel. Fixes: d10de253 "anv: Implement VK_EXT_subgroup_size_control" Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!4694> (cherry picked from commit fdf9b674)
-
Ever since Vulkan 1.2, this feature has been in core so enabling the extension is no longer required. Fixes: 4ef3f7e3 "anv: Enable Vulkan 1.2 support" Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!4694> (cherry picked from commit 9c009da2)
-
Fixes dEQP-VK.spirv_assembly.instruction.function_params.sampler_param cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!4684> (cherry picked from commit bc5c4382)
-
The SPIR-V parser sometimes generates casts from specific sampler types like sampler2D to the bare sampler type. This results in a cast which causes heartburn for drivers but is harmless to remove. cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!4684> (cherry picked from commit a1a08a58)
-
cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!4675> (cherry picked from commit 6211e79b)
-
cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Acked-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!4675> (cherry picked from commit a4885df9)
-
Closes: #2812 cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Part-of: <mesa/mesa!4675> (cherry picked from commit a44e6339)
-
We were accidentally asserting that the value had to be a vtn_ssa_value which isn't true if it, for instance, comes from a spec constant. Fixes: fb282a68 "spirv: Implement OpConvertPtrToU and OpConvertUToPtr" Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Acked-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!4675> (cherry picked from commit 64e42976)
-
It avoids calling pkg-config which was searched for in a wrong way, thus breaking setup where unprefixed pkg-config was banned (e.g. on Exherbo). Signed-off-by:
Quentin Glidic <sardemff7+git@sardemff7.net> Fixes: 53f91312 ("meson: fix getting cflags from pkg-config") Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Part-of: <mesa/mesa!4701> (cherry picked from commit 00f5ea9f)
-
Dylan Baker authored
-
- Apr 23, 2020
-
-
We're missing the cases for gen12 leading to those metrics going missing. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 15b7b56e ("intel/perf: add TGL support") Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4586> (cherry picked from commit 086ea1ac)
-
Where they belong. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Acked-by:
Jason Ekstrand <jason@jlekstrand.net> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Rafael Antognolli <rafael.antognolli@intel.com> Reviewed-by:
Mark Janes <mark.a.janes@intel.com> Part-of: <mesa/mesa!4344> (cherry picked from commit dde96d31)
-
This stuff is somewhat specific to the GL extension & drivers. On Vulkan we won't use this, it also made a rather large file. v2: Fix Android build (Lionel) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Acked-by:
Jason Ekstrand <jason@jlekstrand.net> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Rafael Antognolli <rafael.antognolli@intel.com> Reviewed-by:
Mark Janes <mark.a.janes@intel.com> Part-of: <mesa/mesa!4344> (cherry picked from commit 33b9c7a7)
-
Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Acked-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Rafael Antognolli <rafael.antognolli@intel.com> Reviewed-by:
Mark Janes <mark.a.janes@intel.com> Part-of: <mesa/mesa!4344> (cherry picked from commit f5c5574f)
-
The macro "_WINVER" does nothing, the macro definitions that matter for windows API version selection are "_WIN32_WINNT" and "WINVER". The header "sdkddkver.h" (which is included from thousands of different windows-headers) defines "WINVER" to the same value as "_WIN32_WINNT" of only the latter is defined, which explains why this works right now. But we shouldn't depend on that kind of luck, and instead define the right maco. Fixes: 3aee4627 ("meson: add windows compiler checks and libraries") Acked-by:
Dylan Baker <dylan@pnwbakers.com> Part-of: <mesa/mesa!4681> (cherry picked from commit 7f17a0a8)
-
The default behaviour (0) is: "round-nearest-even to n.6 and drop fraction when point sampling" whereas the Vulkan spec simply wants us to floor it (1) "truncate when point sampling". See 15.6.1 in the Vulkan spec. https://www.khronos.org/registry/vulkan/specs/1.2-extensions/html/vkspec.html#textures-normalized-operations The Direct3D spec also mandates this (https://microsoft.github.io/DirectX-Specs/d3d/archive/D3D11_3_FunctionalSpec.htm#7.18.7%20Point%20Sample%20Addressing) This fixes some point-sampling texture precision issues in some Direct3D 9 titles such as Guild Wars 2 and htoL#NiQ: The Firefly Diary that are not present on other vendors. Fixes dEQP-VK.pipeline.sampler.exact_sampling.* https://github.com/Joshua-Ashton/d9vk/issues/450 https://github.com/doitsujin/dxvk/issues/1433 CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!3951> (cherry picked from commit 58f25098)
-
If FS reads gl_ViewportIndex but VS doesn't export it, it should be zero to avoid reading garbage. Closes: mesa/mesa#2818 Fixes: b424d49a ("radv/llvm: fix exporting the viewport index if the fragment shader needs it") Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <mesa/mesa!4687> (cherry picked from commit 7086b38c)
-
Dylan Baker authored
-
Dylan Baker authored
-
If PT_SPRITE_TEX is enabled, PS inputs are overriden at runtime so we can't apply the vs output optim. Closes: mesa/mesa#2747 Fixes: 3ec99755 ("radeonsi: eliminate trivial constant VS outputs") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!4559> (cherry picked from commit 17acff01)
-
Push constants in particular can get picked up by the hardware at weird times that happen *before* 3DPRIMITIVE. Therefore, we need to flush before we emit all our state to ensure that any data they may pick up is in memory in time. This fixes an app which does vkCmdCopyBuffers immediately followed by a vkCmdBeginRenderPass and vkCmdDraw which uses the destination of the copy as a UBO which we push. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!4601> (cherry picked from commit 969aeb6a)
-
Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!4601> (cherry picked from commit ffc84eac)
-
Dylan Baker authored
-
- Apr 22, 2020
-
-
Dylan Baker authored
-
In SPIRV of compute shader in Aztec Ruins benchmark there is: OpControlBarrier %uint_1 %uint_1 %uint_0 // ControlBarrier(Device, Device, rdcspv::MemorySemantics(0)); which is an incorrect translation of glsl barrier(). GLSLang, prior to c3f1cdfa, emitted the OpControlBarrier with Device instead of Workgroup for execution scope. 2365520c covers similar case but isn't applied when execution_scope is SpvScopeDevice. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2742 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Tested-by:
Rafael Antognolli <rafael.antognolli@intel.com> Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!4660> (cherry picked from commit 66229aa1)
-
v2: Bump check to I915_PARAM_HAS_CONTEXT_ISOLATION (v4.16) (Ken) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2803 Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Part-of: <mesa/mesa!4643> (cherry picked from commit f402b7c5)
-
The signedness of enums are undefined, so on platforms with signed enums, this isn't going to work. One such platform is Microsoft Windows. So let's just use an unsigned here instead. Fixes: b1c4c4c7 ("mesa/gallium: automatically lower alpha-testing") Acked-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!4648> (cherry picked from commit 013d9e40)
-
In meson 0.54.0 I fixed the llvm cmake dependency to return "not found" if shared linking is requested. This means that for 0.54.0 and later we don't need to do anything, and for earlier versions we only need to change the logic to force the config-tool method if shared linking is required. Fixes: 821cf694 ("meson: Use cmake to find LLVM when building for window") Acked-by:
Marek Olšák <marek.olsak@amd.com> Reviewed-by:
Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!4556> (cherry picked from commit fdd0ce12)
-
Commit fixes assert that triggers when running dEQP-VK.api.external.memory.android_hardware_buffer.dedicated.buffer#bind_export_import_bind on a debug build of Mesa. Fixes: c79a528d ("anv/android: support import/export of AHardwareBuffer objects") Signed-off-by:
Abhishek Kumar <abhishek4.kumar@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!4655> (cherry picked from commit f06e4ab3)
-
After call to nir_shader_gather_info - inputs_read may have changed so st_nir_assign_vs_in_locations should be called for shader to remain in sync with vbo state. Fixes piglit tests: gl-1.0-fpexceptions gl-1.1-color-material-unused-normal-array arb_vertex_program-unused-attributes regression on several gallium drivers. Fixes: d684fb37 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!4645> (cherry picked from commit 829013d0)
-
Dylan Baker authored
-
Dylan Baker authored
-