Reported and fix suggested by:
Frederic Martinsons <frederic.martinsons@sigfox.com>

Fixes mobile-broadband/ModemManager#438

(cherry picked from commit 20b8d793)

The system template is updated to add new packages required at build
time:

 * libdbus-1-dev is added so that we can autodetect the service
   directory path via the installed pkg-config file.
 * udev is added so that we can autodetect the udev rules directory
   path via the installed pkg-config file.
 * policykit-1 is added so that the i18n operation merging policy
   files is able to use the installed ITS files.
 * bash-completion is added to enable the feature in the meson build.

The 'dist' step in the test is fully skipped for now, as the meson
port doesn't fully support running all unit tests successfully.

(cherry picked from commit 72741004)

(cherry picked from commit aee12967)

(cherry picked from commit d5a992d3)

This reverts commit 09a5052a.

This commit breaks the default disabling of the qcom-soc plugin.

(cherry picked from commit b75d1d50)

We will end up exporting what we shouldn't:

  $ abidiff /tmp/autotools/lib/ModemManager/libmm-shared-icera.so /tmp/meson/lib/ModemManager/libmm-shared-icera.so
  Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 8 Added functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  8 Added functions:

    [A] 'function const gchar* mm_bearer_connection_status_get_string(MMBearerConnectionStatus)'    {mm_bearer_connection_status_get_string}
    [A] 'function GType mm_bearer_connection_status_get_type()'    {mm_bearer_connection_status_get_type}
    [A] 'function const gchar* mm_bearer_status_get_string(MMBearerStatus)'    {mm_bearer_status_get_string}
    [A] 'function GType mm_bearer_status_get_type()'    {mm_bearer_status_get_type}
    [A] 'function gchar* mm_filter_rule_build_string_from_mask(MMFilterRule)'    {mm_filter_rule_build_string_from_mask}
    [A] 'function GType mm_filter_rule_get_type()'    {mm_filter_rule_get_type}
    [A] 'function gchar* mm_port_probe_flag_build_string_from_mask(MMPortProbeFlag)'    {mm_port_probe_flag_build_string_from_mask}
    [A] 'function GType mm_port_probe_flag_get_type()'    {mm_port_probe_flag_get_type}

(cherry picked from commit 101ed567)

When building shared utils modules or plugins, we should not link with
the static libraries built under src/, because that would mean we're
including their symbols as exported by the modules, and it'll break in
runtime.

Instead, just define the correct set of 'include_directories' to be
used in each plugin.

Fixes mobile-broadband/ModemManager#436

(cherry picked from commit 8167bc89)

So that we don't confuse the plugin-specific libhelpers with the core
libhelpers built in src/.

(cherry picked from commit 81b6c1b3)

`libmbim`, `libqmi` and `libqrtr-glib` have started using `feature`
options in their meson builds.

(cherry picked from commit c753f857)

Fixes mobile-broadband/ModemManager#433

(cherry picked from commit 986fbd50)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

To avoid those cases where a plugin does not need a helper library
an empty array is created.

However, when a helper library has to be built, it is not necessary
to include the created static library in an array.

(cherry picked from commit 80f274b3)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

`libmm-test-common` is created using underscores. It also uses
`gio-unix-2.0` as a public dependency but actually it should be
private.

Both issues have been fixed.

(cherry picked from commit db2d2c0c)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

The suspend/resume option does not build properly if journal option
is disabled. This is beacause the journal option is check to add
suspend/resume code.

It has been fixed by replacing journal option check by the
suspend/resume option.

(cherry picked from commit ab805e09)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

At the moment `libsystemd` is check even if `suspend/resume` and
systemd support are not enabled.

This has been changed so `libsystemd` is checked only if any or both
options are enabled.

(cherry picked from commit 39912daa)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

`libqcdm`'s meson build files have been improved slightly by
removing unnecessary variables shortening their contents.

(cherry picked from commit 93a1d7a6)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

(cherry picked from commit fe53de8b)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

(cherry picked from commit 190bf5b3)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

Improved the way the plugins are set to allow a smaller summary.

(cherry picked from commit 09a5052a)

Inigo Martínez authored 3 years ago and Aleksander Morgado committed 3 years ago

Since meson 0.53 it has added a new function to summarize the build
configuration[0].

We changed the summary to make use of it.

[0] https://mesonbuild.com/Release-notes-for-0-53-0.html#add-a-new-summary-function

(cherry picked from commit e075512f)

(cherry picked from commit 15671dc1)

We need the new "Get All Call Info" request support.

Only error out if the required TLVs are missing.

  ../src/mm-iface-modem-voice.c: In function ‘mm_iface_modem_voice_reload_all_calls’:
  ../src/mm-iface-modem-voice.c:2549:64: warning: passing argument 2 of ‘((MMIfaceModemVoice *)g_type_interface_peek((void *)((GTypeInstance *)self)->g_class,  mm_iface_modem_voice_get_type()))->load_call_list’ from incompatible pointer type [-Wincompatible-pointer-types]
   2549 |                                                                reload_all_calls_ready,
        |                                                                ^~~~~~~~~~~~~~~~~~~~~~
        |                                                                |
        |                                                                void (*)(MMIfaceModemVoice *, GAsyncResult *, GTask *) {aka void (*)(struct _MMIfaceModemVoice *, struct _GAsyncResult *, struct _GTask *)}
  ../src/mm-iface-modem-voice.c:2549:64: note: expected ‘GAsyncReadyCallback’ {aka ‘void (*)(struct _GObject *, struct _GAsyncResult *, void *)’} but argument is of type ‘void (*)(MMIfaceModemVoice *, GAsyncResult *, GTask *)’ {aka ‘void (*)(struct _MMIfaceModemVoice *, struct _GAsyncResult *, struct _GTask *)’}

The process_get_all_call_info() was not completing the input GTask on
every possible code path (e.g. when remote party number or call info
wasn't available).

The method is now updated to avoid processing the GTask itself,
instead it will attempt to build the call list and return a GError on
any kind of failure.

Dylan Van Assche authored 3 years ago and Aleksander Morgado committed 3 years ago

Enable AT URCs for calls on top of QMI Voice indications
for AT+QMI devices only. Some AT+QMI devices send unreliable
QMI indications when the host is resuming. In such cases,
AT URCs can be used as a fall back to make calls reliable.

While AT+QMI devices relied before on AT commands to load
call list information and handle AT URCs for async updates,
this is now handled through QMI by forcefully reloading the
call list instead of processing the AT URCs.
This approach is disabled by default through the
MM_IFACE_MODEM_VOICE_INDICATION_CALL_LIST_RELOAD_ENABLED property.
This property is set to true in case of QMI modems.

Dylan Van Assche authored 3 years ago and Aleksander Morgado committed 3 years ago

Calls in a CLCC response in data-only or fax-only mode
do not count as actuall calls.

  ../test/lsudev.c: In function ‘println’:
  ../test/lsudev.c:68:5: warning: function ‘println’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
     68 |     g_string_append_vprintf (output, fmt, args);
        |     ^~~~~~~~~~~~~~~~~~~~~~~

  ../libmm-glib/mm-location-3gpp.c: In function ‘mm_location_3gpp_new_from_string_variant’:
  ../libmm-glib/mm-location-3gpp.c:400:16: warning: unused variable ‘operator_code’ [-Wunused-variable]
    400 |         gchar *operator_code;
        |                ^~~~~~~~~~~~~

Conveniently warned by the compiler...

  ../libmm-glib/mm-3gpp-profile.c: In function ‘mm_3gpp_profile_cmp’:
  ../libmm-glib/mm-3gpp-profile.c:98:1: warning: control reaches end of non-void function [-Wreturn-type]
     98 | }
        | ^

  ../libmm-glib/mm-simple-status.c: In function ‘mm_simple_status_new_from_dictionary’:
  ../libmm-glib/mm-simple-status.c:426:21: warning: declaration of ‘properties’ shadows a global declaration [-Wshadow]
    426 |     MMSimpleStatus *properties;
        |                     ^~~~~~~~~~
  ../libmm-glib/mm-simple-status.c:55:20: note: shadowed declaration is here
     55 | static GParamSpec *properties[PROP_LAST];
        |                    ^~~~~~~~~~